From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#48179: [External] : bug#48179: bookmark-fontify [PATCH] Date: Wed, 5 May 2021 16:43:59 +0000 Message-ID: References: <20210503001358.mjafsjlumdamrlvh@E15-2016.optimum.net> <87zgxcdzh3.fsf@gnus.org> <20210503091204.qhc2tda76wh6345w@E15-2016.optimum.net> <87im40cgxz.fsf@gnus.org> <20210503095828.66mcqkxyznb2vdja@E15-2016.optimum.net> <87v97yan85.fsf@gnus.org> <87lf8uan2m.fsf@gnus.org> <20210504183816.xztxbfi7af6mlbeb@E15-2016.optimum.net> <874kfh8ukz.fsf@gnus.org> <20210505104816.26i45urvktod3322@E15-2016.optimum.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21635"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "48179@debbugs.gnu.org" <48179@debbugs.gnu.org> To: Boruch Baum , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 05 18:53:28 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leKm7-0005Uf-Nm for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 May 2021 18:53:27 +0200 Original-Received: from localhost ([::1]:46746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leKly-0006oj-Lh for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 May 2021 12:53:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41822) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leKdy-0001Ve-FY for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 12:45:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49976) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1leKdy-0003jW-6y for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 12:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1leKdy-0006e2-3p for bug-gnu-emacs@gnu.org; Wed, 05 May 2021 12:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 May 2021 16:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48179 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 48179-submit@debbugs.gnu.org id=B48179.162023305125469 (code B ref 48179); Wed, 05 May 2021 16:45:02 +0000 Original-Received: (at 48179) by debbugs.gnu.org; 5 May 2021 16:44:11 +0000 Original-Received: from localhost ([127.0.0.1]:33277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leKd8-0006cj-V2 for submit@debbugs.gnu.org; Wed, 05 May 2021 12:44:11 -0400 Original-Received: from aserp2130.oracle.com ([141.146.126.79]:60396) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leKd6-0006cZ-KM for 48179@debbugs.gnu.org; Wed, 05 May 2021 12:44:09 -0400 Original-Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 145GdWka072862; Wed, 5 May 2021 16:44:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=e6NrDpvAg0M8lCihueXKcCJmr0q1spXbkvSHuC48NeE=; b=lVWiuMsu2jVYA+/0FeUjdFB6V3+tV38ofwx+XnFFslen/qQIuKT83Oaj0aFupEuWiBe8 gLUktp2UYfpkSWUcEktl5gWkGGy1yoiJ82s/pwbRE5EV+Cf/f8cyIjdK+R+Oo12ERgzL nJ/OwcTQ8HLRZudBUv1xYu1xCqMjDquLaw7Xs25vx/cH2mAWqdx4ihFvMBMZVXeJAtUX s1rB7Q2tkmcj+ri5M7j2xZAfnUu0mujUYJoOqeFYLZ3RwG8StRnaDUme5rWh15NIAEck RHTkuNIDCc+xXdBYwQR4G+2zsJCqIPjjfadymXenpzsvIL6+mgiDOdl0Rr5GiRqtOwD2 cA== Original-Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2130.oracle.com with ESMTP id 38begjaf8d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 05 May 2021 16:44:02 +0000 Original-Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 145GfX0K068354; Wed, 5 May 2021 16:44:01 GMT Original-Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2108.outbound.protection.outlook.com [104.47.58.108]) by userp3020.oracle.com with ESMTP id 38bfus8bvd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 05 May 2021 16:44:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fmsae1siMH24hI40cFcG43I654z06Io/fXCEb3cRXh3Cjt3EqnW5BCd88UFW0Moi2ewUI3sBCkSxkEf4ruQYanolOd4qTmAia6p3norgqZY+kTCk58sso9mKOZ7hQOuWFzt0zyzOnIFlqERS/Y0jn3HTOaJ/NAMdYoBl8SSpjlT3/sayLi3dDKo/zHacq0VlA09cSuMKMMHRBsyH8eJ48tfED0XAaFdV2w70/k3kSdHxtgkrJcILszF2KHmJ8NEkNvg+qRVcUMnCz9z9SmRybwRmqjDuesK8TvJqbTX+jlssg+SJSyD8qDWY1XWrTVeqOdFhFnumTRW8lnl1yfOi1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e6NrDpvAg0M8lCihueXKcCJmr0q1spXbkvSHuC48NeE=; b=fppAdAVS9pt5Y0JB0tlg6Sn1q6OVH50/aZYXZHFh02aqvvbfIe4wmemfRfXjQUAiUsZCpFWcU5kQWoFfJ/hPiZKUy+X1NxSevFNI3SvMK4R/L5C0PN4I4g4DHjN7AmI770LK+Zar2NzgbqrEmRxWZ7yoL+kahFksKyjumPsP9X1l+iPvU7uqzhJpV5k8Q/6LUHNB0yXJCn9RNQGT5+uIht1yhR7Kr73MhdaD/7UnxDGxWdq6yst+ErgoZjAWdgcA0kldC7D29NIHZ31LB16x+qYjmHqqFk9FpKnrr7gR4rWxKMnlO67BSpOR7Jp+HxNitPzQQKXnPOGEU/0RdVk83Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e6NrDpvAg0M8lCihueXKcCJmr0q1spXbkvSHuC48NeE=; b=NAm23D8WTEuFotjoQMNGCI+0RwQQFPCOhmhVYzIb9bpzNVJ0fIRpxynKHzy08p4Hqs621KVjdGg6CveMXN/MXjwEWP0IXgYHcjfJhKQcm/dgJPVY0VH4AWLx0aLqoTWlaGDT4iMaoZ3X5N4PXNZklOBpfhtzffLvU3vb55hXf/c= Original-Received: from SA2PR10MB4474.namprd10.prod.outlook.com (2603:10b6:806:11b::15) by SA2PR10MB4539.namprd10.prod.outlook.com (2603:10b6:806:117::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Wed, 5 May 2021 16:43:59 +0000 Original-Received: from SA2PR10MB4474.namprd10.prod.outlook.com ([fe80::2109:9725:fd4a:6494]) by SA2PR10MB4474.namprd10.prod.outlook.com ([fe80::2109:9725:fd4a:6494%6]) with mapi id 15.20.4087.044; Wed, 5 May 2021 16:43:59 +0000 Thread-Topic: [External] : bug#48179: bookmark-fontify [PATCH] Thread-Index: AQHXQZwnomYyqQOV2EqYXtYd30AHsKrVD1UQ In-Reply-To: <20210505104816.26i45urvktod3322@E15-2016.optimum.net> Accept-Language: en-US Content-Language: en-US authentication-results: gmx.com; dkim=none (message not signed) header.d=none;gmx.com; dmarc=none action=none header.from=oracle.com; x-originating-ip: [138.3.200.14] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a9524695-ac5f-4407-dcac-08d90fe4fb98 x-ms-traffictypediagnostic: SA2PR10MB4539: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fa5chEeyI0vmpuTtb7VjFzB9q8xgxPTMBoZ5RicrBuZ+s+WAcGA7eLWvU658syRXptzQ1GVVMi5hnd/AR+f6HU8sCCiZxrr6fPFnZZyfSmfr7Z/8KqAaiqxm274CXK8WRdJBHlYNe8w5AP690R5CnogEDUWP1WDvjdnwX2RuRW92XfERmKfiFgdKu3yzYauo6pjMHp01Fm3DdrvaQmv2kDYuStHgtXmhojs+nYGQbOdjR5znA3+98t4haf/2NRqmxu7dfQaLdkiuD6nU12G91zoR7Jv2p8Oufu1JvOw9HFVQWivRPlghq0SLLZ58hsSdZkWFdbElNcGwjfEly/NVX7Dahjfiyu2YuUjX3NoEtG0aYRpzsH61AV68oW4eI+cz0DwadkHvoB6ecUuw87iz7dQpm80r7ZxFal0pnDz086ZjzhSaCt5GZUeP5TWWFnroCuH3V+1iK5h5342L9Fml1l6T26eSfTfApVkR1vrgC12W4+lTfFjlvu56cIIixnPmIYgmT8kUsRgTXEB68zIaNIFryO9Li8M8JfmqRmjNubKxb4uT0QGQRTWIlLdJYHlyi0K9ocXueTyOc12GNpXG1c32hmmPliGvhFMBKdZAHRg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR10MB4474.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(136003)(39860400002)(346002)(366004)(396003)(4326008)(6506007)(7696005)(26005)(66446008)(64756008)(66556008)(86362001)(66476007)(66946007)(44832011)(33656002)(76116006)(110136005)(478600001)(38100700002)(8676002)(9686003)(55016002)(52536014)(5660300002)(71200400001)(8936002)(316002)(2906002)(186003)(122000001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 0TqukxRSAMZzJ2iU5uSYkhroxTadSk/9lZggGjAVOIuZMbkxBO8o3RgL4MWlJ8ifCIh4vvvjoMd7VJvapYoVHqOTdjb1B4Wy4r3bZCJaPoOzkYrONN8h2ZcN0o/8ThKO8fMsJUPEoM2Kb8jF3tkfzjTgEYK7Kcjw3TlPu9mGv41xNa4CXMzq/TZri7Wnvomn53bNw68T1D7ZC0zMRAOSvNnUp++hSsMMeb5b6p/TEwg1+tHZJlTZxLOa4fnhpmp9kIdXO5pVEyfDYY6ATCShVveHhom4AqFeUcfHNDsbM9V72vWUnHeJLnIHBntaHcma/JhE419RmprrOvXFqpVd30BGSNPjMatwcc1NMHNOOojxqKXZKEWw0apeRdvMZISV+ZRRxOrB3p362Q9bCJ5q1AHsN5D4/mr9ErP1OYCsitLYYrEGBy5tB/aHiCHLF0Se1e/fVafruFtJfr+be6tRsAQ0djdWCr4Bs1Mr6L9w4xJg83KUjNrEPqDhjr821w5Tbf5ZM8qQ/dWXLKA3gbsk04drbTqB52tke2AC3REGHBoeJzgoOrZV1EaPmllkx+tyBVBRtKYpJwsUv8bCONVev7X+4tyRRqLwEXFJNPX0OqXNDQlPikMYdX9zE7GB+P5wDg3rNwXGh/d+4WR6zy60ddai4wYYQcXMDQAF3WU4q0jWcyRqkOCUZjHa0JgVDr+pHcUgcyGw5/zqglh3peiEqr1lY7IyDDVMd+4fzoCPribuag6rLir1wIscfyec 0RZX8NekKCfis1xludBRMXHDAQeBhtJv8XzGcUZs2Eh1a1OySgREwYdcp2UQSwQ+VUehUEs4fvdSOSlNU3xJvVcEjslJkLjuqo x-ms-exchange-transport-forked: True X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4474.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9524695-ac5f-4407-dcac-08d90fe4fb98 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 May 2021 16:43:59.7167 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0MVojvGSoznzV8ucTlepZezmMEnQ7mxebU1qwmbvwkDLHNVnoSdwowjfgSbC3f3Bjj0e2n3xeVJGSDfdwS4ShQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4539 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9975 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0 mlxscore=0 adultscore=0 bulkscore=0 suspectscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2105050116 X-Proofpoint-GUID: ZaKzC5Ioq4WxjNKKp_SqCybqAlaNWeWf X-Proofpoint-ORIG-GUID: ZaKzC5Ioq4WxjNKKp_SqCybqAlaNWeWf X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9975 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 clxscore=1015 malwarescore=0 mlxlogscore=999 lowpriorityscore=0 bulkscore=0 spamscore=0 adultscore=0 impostorscore=0 priorityscore=1501 suspectscore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2105050116 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205727 Archived-At: > > > It's do-able, but if Drew's contributions are going > > > to be accepted, that should take priority, > > > > If Drew submits patches, they'll be evaluated like > > any other patches, >=20 > My reading of his email was that he was submitting > an entire package. To be clear - 1. I've submitted plenty of patches in the past. They've usually been ignored. I don't plan on submitting a patch along the lines of what you (Boruch) have done for this. 2. File `bookmark+-lit.el' provides the highlighting we're talking about wrt Bookmark+. It depends on code in the other Bookmark+ files. (But they don't depend on it, so if you don't want such highlighting then you need not load it. Someone other than I could either use code from `bookmark+-lit.el' to patch Emacs or use its features or implementation as inspiration or as food for thought. 3. If Emacs maintainers decide to replace `bookmark.el' with Bookmark+ then I'll be glad to (a) incorporate any `bookmark.el` code that's currently used by Bookmark+ into Bookmark+, and (b) clean up the Bookmark + code so it doesn't bother to be compatible with older Emacs versions and it doesn't try to accommodate 3rd-party libraries when they might be available. The resulting library would be renamed `bookmark', (same name we use now, for `bookmark.el') but it would comprise multiple files. File `bookmark+.el' would be renamed `bookmark.el', replacing that existing file. The existing doc is plain-text (in file `bookmark+-doc.el'). It would need to be rewritten to some extent. I could help with that. And I'd make myself available to help with questions etc. #3 would take a while. But I doubt that maintainers would agree to it anyway. They have not, in the past (though Stefan M. did say at one point that it would be good for that to happen). Hope things are clear now. I'm open to Bookmark+ _replacing_ `bookmark.el', and in that case I'd do the cleanup work needed for that. (Someone else would do the GIT fiddling, committing etc.) And I'm open to anyone grabbing and repurposing code from Bookmark+ piecemeal for vanilla Emacs. I won't be doing that, however. As for the replacement possibility, I'd need some reassurance that it would actually happen, before I'd bother to work to make it available. I'm not going to waste time again working on stuff that has no chance of inclusion. Sorry. Been there. Contributing - yes, I'm open to that. If that's not acceptable then, as I say, the code is there; it's GPL; and I offer it. You're free to take any of it you like for Emacs, and I'll even help you understand, if there are questions.