From: Drew Adams <drew.adams@oracle.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Daniel Mendler <mail@daniel-mendler.de>,
"47992@debbugs.gnu.org" <47992@debbugs.gnu.org>,
"jakanakaevangeli@chiru.no" <jakanakaevangeli@chiru.no>
Subject: bug#47992: [External] : bug#47992: 27; 28; Phase out use of `equal` in `add-hook`, `remove-hook`
Date: Sun, 25 Apr 2021 04:57:35 +0000 [thread overview]
Message-ID: <SA2PR10MB44744F5DE7749D99B731389EF3439@SA2PR10MB4474.namprd10.prod.outlook.com> (raw)
In-Reply-To: <jwvv98bvz43.fsf-monnier+emacs@gnu.org>
>> > > you'd make it no longer work at all for
>> > > interpreted lambda forms (except rare cases where they
>> > > might actually be `eq' - e.g., same list structure)?
>> >
>> > It would still work for lambda forms, just differently (arguably,
>> > in a way that's more often right than the current way).
> >
> > Please elaborate. Comparing lambda forms using `eq'?
> > Not clear to me how that works in the general case.
> >
> > (eq (lambda () foo) (lambda () foo)) ?
> >
> > I don't see that it works at all, let alone works more
> > often than the current way:
> > (equal (lambda () foo) (lambda () foo))
>
> IOW, you don't have an opinion either way on the
> proposed change of semantics.
Seems to be your favorite way of (not) communicating:
saying that I have nothing to say.
How about actually elaborating: Tell us how using
`eq' would enable the interpreter to test equality
of lambda forms in the general case (not shared list
structure)?
How would using `eq' "still work for lambda forms,
just differently (arguably, in a way that's more
often right than the current way)"? Forgive me for
not understanding what you mean by that.
___
As for my opinion on the proposed change: I haven't
seen a good argument for using `eq' instead of `equal'
to test for equality in `add|remove-hook' (in the code:
`memq' instead of `member').
I gave good arguments for continuing to use `equal'.
Emacs users use the Elisp interpreter interactively,
and they do use lambda forms with `add|remove-hook',
even though that's not a great idea. `eq' doesn't
cut the mustard at all, for such use.
Barring a good argument for using `eq', I'm not in
favor of such a change. Given a good argument, I
might change my mind. Clear enough?
next prev parent reply other threads:[~2021-04-25 4:57 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-24 12:11 bug#47992: 27; 28; Phase out use of `equal` in `add-hook`, `remove-hook` Daniel Mendler
2021-04-24 20:12 ` bug#47992: [External] : " Drew Adams
2021-04-24 20:23 ` Daniel Mendler
2021-04-24 21:20 ` Drew Adams
2021-04-24 21:34 ` Daniel Mendler
2021-04-24 22:30 ` Stefan Monnier
2021-04-24 22:38 ` Daniel Mendler
2021-04-24 23:04 ` Stefan Monnier
2021-04-24 23:38 ` Daniel Mendler
2021-04-25 1:16 ` Drew Adams
2021-04-25 3:08 ` Stefan Monnier
2021-04-25 4:57 ` Drew Adams
2021-04-25 13:52 ` Stefan Monnier
2021-04-25 1:16 ` Drew Adams
2021-04-25 1:23 ` Drew Adams
2021-04-25 3:10 ` Stefan Monnier
2021-04-25 4:57 ` Drew Adams [this message]
2021-04-25 10:33 ` Daniel Mendler
2021-04-25 13:56 ` Stefan Monnier
2021-05-02 9:09 ` Lars Ingebrigtsen
2021-05-02 10:37 ` Daniel Mendler
2021-05-03 8:50 ` Lars Ingebrigtsen
2021-07-06 14:44 ` Olivier Certner
[not found] ` <877di6udfy.fsf@web.de>
2021-07-04 1:09 ` Lars Ingebrigtsen
2021-07-04 2:35 ` Michael Heerdegen
2021-07-04 2:56 ` Lars Ingebrigtsen
2021-07-04 4:28 ` Michael Heerdegen
2021-07-04 13:36 ` Lars Ingebrigtsen
2021-07-04 17:08 ` bug#47992: [External] : " Drew Adams
2021-07-04 22:45 ` Michael Heerdegen
2021-07-05 12:39 ` Lars Ingebrigtsen
2021-07-06 1:48 ` Richard Stallman
2021-07-06 2:37 ` bug#47992: [External] : " Drew Adams
2021-07-06 3:21 ` Michael Heerdegen
2021-07-07 23:57 ` Richard Stallman
2021-07-06 9:46 ` Arthur Miller
2021-07-07 23:57 ` Richard Stallman
2021-07-08 2:11 ` Arthur Miller
2021-07-04 23:15 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SA2PR10MB44744F5DE7749D99B731389EF3439@SA2PR10MB4474.namprd10.prod.outlook.com \
--to=drew.adams@oracle.com \
--cc=47992@debbugs.gnu.org \
--cc=jakanakaevangeli@chiru.no \
--cc=mail@daniel-mendler.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).