From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#48883: [External] : bug#48883: dired marking bugs Date: Mon, 7 Jun 2021 15:24:11 +0000 Message-ID: References: <20210606203356.muhmgel5m2jwmzpj@E15-2016.optimum.net> <20210606224451.32hmmhpsj3tqt5aj@E15-2016.optimum.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8310"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "48883@debbugs.gnu.org" <48883@debbugs.gnu.org> To: Boruch Baum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 07 17:25:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lqH7r-0001t7-Ul for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Jun 2021 17:25:16 +0200 Original-Received: from localhost ([::1]:59296 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqH7q-000748-Op for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Jun 2021 11:25:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41346) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqH7e-00073x-Uy for bug-gnu-emacs@gnu.org; Mon, 07 Jun 2021 11:25:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44968) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lqH7e-0007Hg-OW for bug-gnu-emacs@gnu.org; Mon, 07 Jun 2021 11:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lqH7e-0002YP-JZ for bug-gnu-emacs@gnu.org; Mon, 07 Jun 2021 11:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Jun 2021 15:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48883 X-GNU-PR-Package: emacs Original-Received: via spool by 48883-submit@debbugs.gnu.org id=B48883.16230794609758 (code B ref 48883); Mon, 07 Jun 2021 15:25:02 +0000 Original-Received: (at 48883) by debbugs.gnu.org; 7 Jun 2021 15:24:20 +0000 Original-Received: from localhost ([127.0.0.1]:56514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqH6y-0002XI-59 for submit@debbugs.gnu.org; Mon, 07 Jun 2021 11:24:20 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:50358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqH6w-0002X1-TU for 48883@debbugs.gnu.org; Mon, 07 Jun 2021 11:24:19 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 157FAd4A097558; Mon, 7 Jun 2021 15:24:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=m2BjDj7Tpa1MVCAaSw83RVUDNakehG4Ug8dPH1V0aUU=; b=XCQ/M48bdo8qAS6/i9FZOEiwRUGxvDSwB/H/E+3QT9zZjhxdcZAJil8MBHAGyv+xiHdF vq3sEo+FTHL60VElty1075yTbzgBSoYWuB9aJHE5lZc/KgwBpI60sVb4Fuv18/E/xk0m ezFrVYnUU5OHmi7w+kV298Pp5hRvFNizEr/rF6TYgrik8iCL1wLmFvdYUhIxe13ASlE2 3Z6fNAbNGytdCSHskD3wBfA8j9EJZNga2zCi6TsAhdgtglK3y9Eo8qpWvvsQFohcxuTT L64juDNP8IjmunjnDo+H38TqAMn5yZpvQkY9LsPS26/hYPwwPLR6fp5gz+t1zjwSz+bW JA== Original-Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 3914quhw51-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 07 Jun 2021 15:24:13 +0000 Original-Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 157FAxPO088564; Mon, 7 Jun 2021 15:24:12 GMT Original-Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1anam02lp2042.outbound.protection.outlook.com [104.47.57.42]) by userp3020.oracle.com with ESMTP id 390k1q50sj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 07 Jun 2021 15:24:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QPi0d+QWwAZws6OmddH0W0LP6eeJGsP+/PKUXl1ZHBEZ6Eh1cWBfjxfkp1trctdOOeXBM8DLXNyHMzqmGeYdWPC971byQWePPO6ArDTOwkocMOjmnTHWRoVsmjJLrebHG0T2vST1zIj2Wx4b+YtpKMxMVNlJNymSA3UZDzO7d+J7IyPitjfo8EFBpoKboXvYcWgOYgO8wOZUL4YkKjjhWXJETm4NdhmO2ET8QFBhuzEAOLTwoUWN6NOLelzPK1b5fja7lWzXoypxJOsvInaettb6nKO9rcyK/c09IB9073Bbeagd+RbDIqgJTTSWwANHmW3u/IlF9XycOOK+1XM6jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m2BjDj7Tpa1MVCAaSw83RVUDNakehG4Ug8dPH1V0aUU=; b=ijoIFPrbFd1jI7tZjEP1HTjnxPV5za+U8N7sWgCK8AI2+zwrZDBFPmWCifjKoknqLw9AKOCIqW88VQWbMNI0WuCbFSy4OToFxB35B+rMMNYbP3m/mTbJol/MQ3feNVxc1uRi1JDP3IiA00kSD+UkgU3tw+9ZFKbDdmL1vuNvtWkEumKFTj8fduZzHUUNzOhMlNmmxbGC6Z3a9UjSC933LITewVIGaXyKNCgRuCm6CkwkMLBpMtzypK1AWryDmUWp3FI9FIMLHuDhDuXRw1szc/dwoaEuubj1DG+ZQ2BSpgwWBIuOuIr8r3H7ZHU6pY2c49WAh7EceTii5AbkX/O0GQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m2BjDj7Tpa1MVCAaSw83RVUDNakehG4Ug8dPH1V0aUU=; b=ux/oI6AlBOk5lyV5tNNd0cMz/2p4OPJXX+FVFOgabahcg8aOeaGrJSVZrGlfrlixU/2AHojUmlxAH9aDpmAyC/uWaSauu6EEyxWs1f7W3Jw7O0BT46DBEI9BBqHoTQTVgGWRfVqZaHWgzNK3Jqu8ItmxwWwOwURo9sf6VZE7q18= Original-Received: from SA2PR10MB4474.namprd10.prod.outlook.com (2603:10b6:806:11b::15) by SA2PR10MB4441.namprd10.prod.outlook.com (2603:10b6:806:11d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.24; Mon, 7 Jun 2021 15:24:11 +0000 Original-Received: from SA2PR10MB4474.namprd10.prod.outlook.com ([fe80::2109:9725:fd4a:6494]) by SA2PR10MB4474.namprd10.prod.outlook.com ([fe80::2109:9725:fd4a:6494%6]) with mapi id 15.20.4195.030; Mon, 7 Jun 2021 15:24:11 +0000 Thread-Topic: [External] : bug#48883: dired marking bugs Thread-Index: AQHXWyWUlSkK36fHfU20M8OHaf+0iKsInOLQ In-Reply-To: <20210606224451.32hmmhpsj3tqt5aj@E15-2016.optimum.net> Accept-Language: en-US Content-Language: en-US authentication-results: gmx.com; dkim=none (message not signed) header.d=none;gmx.com; dmarc=none action=none header.from=oracle.com; x-originating-ip: [73.170.83.28] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 09ab5c42-1389-4830-ad9e-08d929c84d3b x-ms-traffictypediagnostic: SA2PR10MB4441: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: snyKP5v9/u42VXW6OcYGIkukrqidMp7t3wGFddQL2DkKgW2KzTtv7iVJzmla/SCpWnaFh/I29gGsdVykYEKpKKWneIUgDeAv2bXQzyF8T+nv32y27CZDGS08P/iso3ldak4S07CrKCmFYTWgr+lSGFCgQo52TG3Ksj8xtTYMEA29+/KRl609g/+FYYtPwJ6TbW4FSlcZF0wtutpuvCo7/5jCyETkZ6yrUp3K9sysr4yHfqIikxatX14XoncyjQ01OyQLZWyTKK6HmH/2cHvCpVnZfeyhoRgsenubtcgiPzUqFkBtTu4VHZTERSSNVSCrvbzI0bFus9QquI7+XdzzZK6nFPe7bBn+kpM3lsgbFfZsMaOwMyLKRpnypch5jV+kU0yKeKKKsS4zRBDWvuEZQwpb51HRpqfLUbztkCvR9k1FTP3/Gqbe/SGX7StVwExKT22obW7LrSYHieMeaqYN1FGkaxNql4oJ8Ef711PnqheySy+cDscL7Ljj2yFx0F3uDHU9AtiF0Fi+HNro5zMi5D+2eUC2YheAGLExVwH7J1kolC9bq7S+5KuV5XmJeH7Jok0z1q7SCt9dQWgoAB7dhmp2pbHN/89ZK7NdhfPajAY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR10MB4474.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(39860400002)(376002)(396003)(366004)(346002)(55016002)(9686003)(86362001)(2906002)(186003)(71200400001)(52536014)(6916009)(4326008)(478600001)(33656002)(64756008)(66476007)(66446008)(83380400001)(66946007)(8936002)(76116006)(8676002)(6506007)(26005)(316002)(5660300002)(38100700002)(66556008)(7696005)(122000001)(44832011); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: rueoCXsd8rPRaYEObeTB4/e/z8/RHbx4T5wIL+Zm41sLiJOGmMVhohogvb7Fao951EShnzDSw0UwTintwX0wwyCXr9CgWU1lvyQBRMkgIpl7ssUbv96o7rfehChv5sIIJQraWmEidkHteIWUCMfZQFNIdUev/XpK9PMTG8Cj7EXj7AXHp5Ecr5xIXSfgtOTg70DMEs7yGXuswxgx0m+u2oe0hQagYE+ySlJJwcVk8FCU4MtXyA6uaUZWTg6m/Mj/TtgcMuFilldYKHP/8bcIl0aPuuSPAo080xapw1fnXxF8WD6UUG9CAVKtVPHVv3flv+6ffcgy/uaNEdnUpYBlJkwg744u1lY19WFhfa5T9J+3uYCih9cUdcjintnXLiIUJiMOzOigBfe08cFdNcrUKUCpVLbyU1e8j0BQ3htV8+DlAJn2gh/maPvCUHa1+jSkTY7j2FeeQrs5FIbCrpZ1myI2ShC8CN8EkJjsVMvgMc7fNZY558BFjGxvE2PZRmpnGUDk1RbaIBJEi29B9JIug7usvX8fuQHBHhaiBrZ0H0V/fTgn6emC8rZ8BmG8xN8N+aLRiBH7lyHzvoZVZitX8sqs1ijPcaZmPVM3ORXif3L09fgnsfusM8WYcKoKj9RuVVk58nQgTC6VmYXX776Ip/ed7J1012cpvbGjq3BRwf4W0LmIQIUrykU8wXI/Nfvy2ChD6A1WES2Wv2XNyCAEj+W7J3uYzsw2/shk3S5G47HVd0Bm+dv71md74+n1 CztLqaNOLwCT92pBhPTKss1FdocHvRZjhSseVuFsM37gAiLQ8UkSdcfXHLD4GkCf0dKXnDMzLgYTquUdTMIfZPJGWX+zuDK0vW x-ms-exchange-transport-forked: True X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4474.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 09ab5c42-1389-4830-ad9e-08d929c84d3b X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2021 15:24:11.4704 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9Nqp4bn5+b5Suz2Q3cy58N2urroRylWhi7eERIrBP67xDm+D1gMYKonibObek3Q9dgf6291flTo6FgMtITkmbA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4441 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10008 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 adultscore=0 malwarescore=0 phishscore=0 mlxlogscore=999 suspectscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2106070110 X-Proofpoint-ORIG-GUID: z6UV1eAv4glpsYuvskAu9yq76vet1LHq X-Proofpoint-GUID: z6UV1eAv4glpsYuvskAu9yq76vet1LHq X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10008 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0 phishscore=0 spamscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 adultscore=0 mlxscore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2106070110 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208186 Archived-At: > > In the second `while' (the one for negative movement), > > change (save-excursion (funcall function)) to this: > > (when (dired-get-filename nil t) ; <=3D=3D=3D=3D=3D=3D=3D > > (save-excursion (funcall function))) >=20 > I don't like that change because it allows operations > on '.' and '..' which makes me uncomfortable. OK. I disagree that ALL operations on `.' and `..' should be disallowed, but what you say follows what will likely be wanted for vanilla Emacs, I expect. My own position (used in Dired+), is that Dired operations can in principle be anything. They are operations on the buffer and its text, first and foremost. Only some of them are operations on files and dirs listed in the buffer. My position (for Dired+, and suggested but not expected for vanilla Dired) is that it's up to the particular function whether and how it might be relevant for `.' or `..'. Some operations might make sense; others might not. The idea that NO operation could make sense on `.' or `..' would be misguided, IMO. It's unnecessarily limiting. `.' and `..' are just names for certain directories. Dired doesn't outlaw operations on other lines that name directories. [The same is true for shell commands, BTW. They don't exclude acting on `.' or `..'.] > What I see as possibly the issue is function `dired-between-files'. I'm > not equipped to perform a 'git blame', but the function's comment > indicated a change at some point, and I suspect that's when the bug > arose. The bug exists at least as far back as Emacs 20. Yes, we could consider that the bug is in `dired-move-to-filename' (used by `dired-between-files'). So far, I've chosen to consider it to be just in `dired-repeat-over-lines'. > > IMO, there's nothing wrong with marking `.' or `..', > > and nothing wrong with Dired having some operations > > that work on them. >=20 > I don't feel comfortable with that. Do you have > any specific case in mind? See above. =20 BTW, even vanilla Emacs presents some specific cases. It lets `dired-get-filename' treat `.' and `..' as regular file names, with non-nil arg NO-ERROR-IF-NOT-FILEP. And `dired-find-file' operates normally on `.' and `..'. [That has always been the case, AFAIK. But before Emacs 21 it didn't use `dired-get-filename' (via `dired-get-file-for-visit'). Starting with 21, it has, passing non-nil NO-ERROR-IF-NOT-FILEP.] Likewise, `dired-mouse-find-file-other-window' operates on `.' and `..'.