From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#63708: 29.0.60; rust-ts-mode not properly handling apostrophe Date: Tue, 30 May 2023 00:14:29 +0000 Message-ID: References: <8T8C4l5XryyVmB2cBTnmhGMnoELwHA2y1u1ZeMlg1WaQKzrPeOoe6L5hOQq3JPdsnG9r-puSlQfNZ091qBCGpVco-mC6ruhsQs0SvaPjkjQ=@proton.me> <_LWjNGLzmmtpm2gEwOaBZlTVCwvU9yxUyJzIl3yo3ol48dKWbMabBOpLzZ2UhWJ2_yPjVT-j2Jb-oUP8nLaju6ztGjFTNq-2PZqgTjv5gSM=@proton.me> <83r0qzgwtb.fsf@gnu.org> <83edmzgqm9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2458"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 63708@debbugs.gnu.org, casouri@gmail.com To: =?UTF-8?Q?=D0=99=D0=BE=D1=80=D0=B4=D0=B0=D0=BD_?= =?UTF-8?Q?=D0=9C=D0=B8=D0=BB=D0=B0=D0=B4=D0=B8=D0=BD=D0=BE=D0=B2?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 30 02:16:31 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q3n2N-0000Pv-Oy for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 May 2023 02:16:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q3n1z-0005WO-Jg; Mon, 29 May 2023 20:16:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3n1v-0005Uo-H9 for bug-gnu-emacs@gnu.org; Mon, 29 May 2023 20:16:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q3n1u-00026a-9E for bug-gnu-emacs@gnu.org; Mon, 29 May 2023 20:16:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q3n1t-0005aa-Oq for bug-gnu-emacs@gnu.org; Mon, 29 May 2023 20:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 May 2023 00:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63708 X-GNU-PR-Package: emacs Original-Received: via spool by 63708-submit@debbugs.gnu.org id=B63708.168540570221403 (code B ref 63708); Tue, 30 May 2023 00:16:01 +0000 Original-Received: (at 63708) by debbugs.gnu.org; 30 May 2023 00:15:02 +0000 Original-Received: from localhost ([127.0.0.1]:59466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3n0n-0005YQ-Rf for submit@debbugs.gnu.org; Mon, 29 May 2023 20:15:02 -0400 Original-Received: from mail-4018.proton.ch ([185.70.40.18]:32381) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3n0l-0005YB-D1 for 63708@debbugs.gnu.org; Mon, 29 May 2023 20:14:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail3; t=1685405685; x=1685664885; bh=OJSnRovF6qEPhRz4DjjBWroRBUpzMEO2vNgsit3RdmE=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=fQAXqum0aNUG8Lh0LPXyBGyVoYwbetnwcXgpY9Qz/rmVvpuO9e+er1EV9gJNycjYz LM4eCDMpVesKUJEaJk5UJzb0CxyLSf6o8zFnvbCXpvhJEMrTHRYD2KRwS7G8nlSb9A ViDw7Fcn70ogYfVK0Y2FX8evaKVSe4G90lRqvcZBrGM2rl/+g4lcZsVM/4oPaYZGtw P5jb6mN3WaGbss4YwNMNEiaWqYl9Pln8QpG31RiZlVXP2aIChJIJVbXHqJX6b7QIgw yDbSUnYKbn1kGFVO3dgwLai7wozUOn+J+//lj0QvkBkpeD27+sZS44Dtt1h9BIwBvh tW+j2ZyNZAxoQ== In-Reply-To: Feedback-ID: 44397038:user:proton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262614 Archived-At: On Monday, May 29th, 2023 at 10:54, =D0=99=D0=BE=D1=80=D0=B4=D0=B0=D0=BD = =D0=9C=D0=B8=D0=BB=D0=B0=D0=B4=D0=B8=D0=BD=D0=BE=D0=B2 = wrote: > Here's a patch that takes into account both your and Randy's remarks. It = fixes both rust-ts-mode and go-ts-mode in a total of 15 lines. Thanks! One tiny nit: In the commit message: * lisp/progmodes/go-ts-mode.el= (go-ts-mode) the (go-ts-mode) part should be (go-ts-mode--syntax-table). Y= ou could also mention the bug # in the commit message somewhere, too - I pe= rsonally like to do it in the first line if it fits like so: Blah blah comm= it message (Bug#63708) Otherwise, looks good to me! Thanks for working on this. >=20 > $ git diff --stat HEAD~ HEAD > lisp/progmodes/go-ts-mode.el | 1 + > lisp/progmodes/rust-ts-mode.el | 14 ++++++++++++-- > 2 files changed, 13 insertions(+), 2 deletions(-) >=20 > Cheers! YM