unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Randy Taylor <dev@rjt.dev>
To: "Йордан Миладинов" <yordanm@proton.me>
Cc: Eli Zaretskii <eliz@gnu.org>, 63708@debbugs.gnu.org, casouri@gmail.com
Subject: bug#63708: 29.0.60; rust-ts-mode not properly handling apostrophe
Date: Tue, 30 May 2023 00:14:29 +0000	[thread overview]
Message-ID: <S7-X7ihZqxf2JCA5iE0pGBYrSBiVQJlKSXw80Mbe5WmUgBXu20TAMjQDLO927JYaW2f8ULnleGtDFjTH_lZWz2s4G0z_Dy3uUkBGwk4WC80=@rjt.dev> (raw)
In-Reply-To: <LRqBQWtaNnSFNln0RIAIFyN4WUYWq1juTn7IvGv7R1tLvefcQ6v5fvI1tvvcWVTMElJHRW0pvNJiinGiTSpqUh-TgsfEcjehCUVAtXORV14=@proton.me>

On Monday, May 29th, 2023 at 10:54, Йордан Миладинов <yordanm@proton.me> wrote:
> Here's a patch that takes into account both your and Randy's remarks. It fixes both rust-ts-mode and go-ts-mode in a total of 15 lines.

Thanks! One tiny nit: In the commit message: * lisp/progmodes/go-ts-mode.el (go-ts-mode) the (go-ts-mode) part should be (go-ts-mode--syntax-table). You could also mention the bug # in the commit message somewhere, too - I personally like to do it in the first line if it fits like so: Blah blah commit message (Bug#63708)

Otherwise, looks good to me! Thanks for working on this.

> 
> $ git diff --stat HEAD~ HEAD
> lisp/progmodes/go-ts-mode.el | 1 +
> lisp/progmodes/rust-ts-mode.el | 14 ++++++++++++--
> 2 files changed, 13 insertions(+), 2 deletions(-)
> 
> Cheers! YM





  parent reply	other threads:[~2023-05-30  0:14 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-24 21:40 bug#63708: 29.0.60; rust-ts-mode not properly handling apostrophe yordanm--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-24 22:05 ` bug#63709: " yordanm--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-25  5:28   ` Eli Zaretskii
2023-05-25  5:31 ` bug#63708: " Eli Zaretskii
2023-05-25 12:52   ` Randy Taylor
2023-05-25 13:13     ` Eli Zaretskii
2023-05-26  2:21       ` Randy Taylor
2023-05-26 19:14         ` yordanm--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-27  3:00           ` Randy Taylor
2023-05-28 19:51             ` yordanm--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-28 19:52               ` yordanm--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-29 11:25                 ` Eli Zaretskii
2023-05-29 13:34                   ` Randy Taylor
2023-05-29  1:29               ` Randy Taylor
2023-05-29 12:13                 ` Eli Zaretskii
2023-05-29 12:18                   ` Randy Taylor
2023-05-29 13:13                     ` Eli Zaretskii
2023-05-29 13:20                       ` Randy Taylor
2023-05-29 14:13                   ` yordanm--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-29 14:27                     ` Eli Zaretskii
2023-05-29 14:54                       ` Йордан Миладинов
2023-05-29 14:59                         ` Eli Zaretskii
2023-05-30  0:14                         ` Randy Taylor [this message]
2023-05-30  9:44                           ` yordanm--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-03  8:35                             ` Eli Zaretskii
2023-05-30  9:10 ` Йордан Миладинов

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='S7-X7ihZqxf2JCA5iE0pGBYrSBiVQJlKSXw80Mbe5WmUgBXu20TAMjQDLO927JYaW2f8ULnleGtDFjTH_lZWz2s4G0z_Dy3uUkBGwk4WC80=@rjt.dev' \
    --to=dev@rjt.dev \
    --cc=63708@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=eliz@gnu.org \
    --cc=yordanm@proton.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).