From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Mauger via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#47358: 28.0.50; sql-list-tables: quotes are cumbersome, no need for it; include history Date: Tue, 05 Jul 2022 01:17:59 +0000 Message-ID: References: <864kh1nfo5.fsf@protected.rcdrun.com> <87sfnr9snr.fsf@gnus.org> Reply-To: Michael Mauger Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26395"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Kangas , 47358@debbugs.gnu.org, Jean Louis To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 05 03:19:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8XDd-0006fU-Jj for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Jul 2022 03:19:13 +0200 Original-Received: from localhost ([::1]:46148 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8XDc-0003OK-Bt for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Jul 2022 21:19:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58522) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8XDS-0003O1-L0 for bug-gnu-emacs@gnu.org; Mon, 04 Jul 2022 21:19:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54964) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o8XDS-000236-Cv for bug-gnu-emacs@gnu.org; Mon, 04 Jul 2022 21:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o8XDS-0008Gk-7S for bug-gnu-emacs@gnu.org; Mon, 04 Jul 2022 21:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Mauger Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Jul 2022 01:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47358 X-GNU-PR-Package: emacs Original-Received: via spool by 47358-submit@debbugs.gnu.org id=B47358.165698390131733 (code B ref 47358); Tue, 05 Jul 2022 01:19:02 +0000 Original-Received: (at 47358) by debbugs.gnu.org; 5 Jul 2022 01:18:21 +0000 Original-Received: from localhost ([127.0.0.1]:48860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8XCi-0008Fe-HL for submit@debbugs.gnu.org; Mon, 04 Jul 2022 21:18:21 -0400 Original-Received: from mail-40133.protonmail.ch ([185.70.40.133]:28342) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8XCf-0008FM-5f for 47358@debbugs.gnu.org; Mon, 04 Jul 2022 21:18:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1656983883; x=1657243083; bh=j55dbG7O0EpTiy35LtRUG5os/ap6lrN9dv0Nqyi+eE0=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:Feedback-ID:From:To:Cc:Date:Subject:Reply-To: Feedback-ID:Message-ID; b=kjUtCPCC1+bzMsJHIs73A7nN72/mQJMCvSh7AI9uQ3/ZIq4If7MkotMhgnrdcCOJq xRoIrdernPaFQTWmbbnHtKdXTqcXC4craYTA/Gbhn+co6bS/w++Q2EmZy+D3BLrzhb XxbmvWbBqFdo3dknAqqgD0ePbYOvO3CnfJM3GyznxcVD7/oB/0Opj+03A3ImUiebCz wg2AzIClwYL3Vr7gqwCDd8x+GNV8qLrqb9Ee4VxxrOMhJZbp0i5BVjDqm/jUMrjz3j dPpwi+u0MTAcfiUpu5hCNdjePBd2/eJaIHTqjyzAAkY6vDO0K5wazzaY6/dVGL35wU ncD2OL59mTymg== In-Reply-To: <87sfnr9snr.fsf@gnus.org> Feedback-ID: 119932:user:proton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" X-ACL-Warn: , Michael Mauger Xref: news.gmane.io gmane.emacs.bugs:236078 Archived-At: Lars, your analysis was correct--they value is merely inserted into whateve= r command the dialect uses to display the table structure and relies upon t= he underlying command interpreter's rules. I understand the desire to not = make typing of the double quotes required even if they are required in the = underlying command then being consistent with what the underlying parser re= quires is not particularly onerous. The handling of the double quotes becom= es a challenge when the underlying cli does not accept the same table-name = syntax as the "list tables" command requires. I am playing around with completion (and the insertion of enclosing dquotes= when required) in code and in the minibuffer but that'll be a little while= before that is ready. I'll take a look at the smaller bugs first and move = on to this. I do use sql-mode every day (I was a predominantly Oracle user = for many years, but PostgreSQL and a little MS SQL Server and SQLite have b= ecome my current emphasis). -- MICHAEL@MAUGER.COM // FSF and SFConservancy // GNU Emacs sql.el maintainer ------- Original Message ------- On Sunday, June 26th, 2022 at 2:38 PM, Lars Ingebrigtsen w= rote: > Stefan Kangas stefan@marxist.se writes: > > > Jean Louis bugs@gnu.support writes: > > > > > When executing C-c C-l t in sql-interactive-mode then tables are > > > completed with quotes like "activities" instead of just activities. > > > > > > It would be good not to use quotes, it is more usable that > > > way. Internally the table could require quotes to be called, but for > > > user to complete a string or name of table should not be necessary. > > > > > > Additionally I propose to include history for the function > > > sql-list-tables as calling tables' definitions may be frequent with s= ome > > > users, and other mini buffer entries are not relevant to it. > > > > I'm copying in the sql.el maintainer here. Michael, could you please ta= ke a > > look at the above feature request? > > > I'm not very familiar with sql.el, but if I read the code correctly, > `C-c C-l t' just outputs the data the SQL server spits back at us? So > if you're using PostgreSQL, I guess that means that that's how > PostgreSQL formats the CREATE TABLE statement. > > But I may be mistaken -- perhaps Michael has some comments here. > > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no