Re: [Reuben Thomas] browse-url.el Opera support

[Reuben Thomas <rrt@sc3d.org>]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1788 bytes --]

> Let me add another more down-to-earth argument: if free software
> support non-free tools, like Opera in browse-url.el in this example,
> it becomes the free software people's work to make it work.  The emacs
> maintainers have to apply the patches, document it, change the code
> whenever the tool changes its API, etc.  This takes time, aka money.
> It is not clear why Emacs maintainers should donate time to people
> that don't give anything back.

But it's becoming clear to me that here too, it depends. After all, Emacs
supports Windows and Netscape. It's a bit ironic that if you're a non-free
system with a near-monopoly (as Windows is and Netscape was) you can get
support. Opera, as a non-free product, is much less offensive (in
particular, it tries to be standards-compliant, and Opera Software don't
go around foisting new "standards" on the world) but it's too small to be
worth supporting...

> Unless the corporation's is mainly interested in pursuing non-free
> software for its own sake, it may make economical sense for them to
> re-license their software,

Sadly, Opera seem to make most of their money from licensing their
browser.

> Regarding your modified browse-url.el:
>
> It is very difficult to evaluate your work when you send the entire
> file, instead of a patch (use 'diff -u').

Attached. The diff is against browse-url.el as shipped with Emacs 21.3.1;
if you'd like it against CVS or something else, please ask.

> In any case, I don't think
> anyone has requested removing support for already supported non-free
> tools, like Netscape.

I've removed the other changes...

> Also, changing the type of existing variables,
> like browse-url-generic-args,

...including this.

-- 
http://www.mupsych.org/~rrt/ | The only person worth beating is yourself

[-- Attachment #2: Type: TEXT/PLAIN, Size: 3591 bytes --]

--- /usr/share/emacs/21.3/lisp/net/browse-url.el	2003-10-27 14:35:16.000000000 +0100
+++ /home/rrt/elisp/browse-url.el	2004-01-18 23:18:36.000000000 +0100
@@ -215,7 +215,7 @@
 
 ;; To invoke different browsers for different URLs:
 ;;      (setq browse-url-browser-function '(("^mailto:" . browse-url-mail)
-;;      				    ("." . browse-url-netscape)))
+;;				    ("." . browse-url-netscape)))
 
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 ;;; Code:
@@ -226,6 +226,7 @@
 (eval-when-compile (require 'thingatpt)
                    (require 'term)
 		   (require 'dired)
+                   (require 'cl)
 		   (require 'w3-auto nil t))
 
 (defgroup browse-url nil
@@ -788,7 +789,7 @@
 
 When called non-interactively, optional second argument NEW-WINDOW is
 used instead of `browse-url-new-window-flag'."
-  (interactive (browse-url-interactive-arg "URL: "))  
+  (interactive (browse-url-interactive-arg "URL: "))
   (apply 'start-process (concat "gnome-moz-remote " url)
 	 nil
 	 "gnome-moz-remote"
@@ -1079,10 +1080,44 @@
 (defun browse-url-generic (url &optional new-window)
   ;; new-window ignored
   "Ask the WWW browser defined by `browse-url-generic-program' to load URL.
-Default to the URL around or before point.  A fresh copy of the
-browser is started up in a new process with possible additional arguments
-`browse-url-generic-args'.  This is appropriate for browsers which
-don't offer a form of remote control."
+Default to the URL around or before point.  A fresh copy of the browser
+is started up in a new process with possible additional arguments
+`browse-url-generic-args', in which the URL is substituted for
+`__URL__' if it exists, or added as a final argument if not."
+  (interactive (browse-url-interactive-arg "URL: "))
+  (unless browse-url-generic-program
+    (error "No browser defined (`browse-url-generic-program')"))
+  (let (found-tok)
+    (let ((args
+           (mapcar
+            (lambda (s)
+              (if (string-match "__URL__" s)
+                  (progn
+                    (setq found-tok t)
+                    (replace-match url t t s))
+                s))
+            browse-url-generic-args)))
+      (unless found-tok
+        (setq args (append args (list url))))
+      (apply 'start-process (concat browse-url-generic-program " " url) nil
+             browse-url-generic-program
+             args))))
+
+; Values for browse-url-generic-args
+;
+; These could be put in a list indexed by browser name to allow common
+; browsers to be chosen from a list and the method of starting the URL
+; (same window, new window, new tab) to be an option.
+;
+; Browser            Same window                   New window                               New tab
+;
+; Opera              ""                            -remote openURL(__URL__,new-window)      -remote openURL(__URL__,new-page)
+; Konqueror          ??                            ""                                       ??
+; Mozilla            -remote openURL(__URL__)      -remote openURL(__URL__,new-window)      -remote openURL(__URL__,new-tab)
+; gnome-moz-remote   --raise __URL__               --raise --newwin __URL__                 --raise --remote=openURL(__URL__,new-tab)
+; lynx-xterm         n/a                            xterm -e lynx __URL__                    n/a
+
+  ;; new-window ignored
   (interactive (browse-url-interactive-arg "URL: "))
   (if (not browse-url-generic-program)
     (error "No browser defined (`browse-url-generic-program')"))

[-- Attachment #3: Type: text/plain, Size: 148 bytes --]

_______________________________________________
Bug-gnu-emacs mailing list
Bug-gnu-emacs@gnu.org
http://mail.gnu.org/mailman/listinfo/bug-gnu-emacs