From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alp Aker Newsgroups: gmane.emacs.bugs Subject: bug#8470: ns_dumpglyphs_stretch creates display artifacts Date: Sun, 10 Apr 2011 19:32:55 -0400 (EDT) Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII X-Trace: dough.gmane.org 1302486019 15658 80.91.229.12 (11 Apr 2011 01:40:19 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 11 Apr 2011 01:40:19 +0000 (UTC) To: 8470@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 11 03:40:14 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q966v-0003Ro-47 for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Apr 2011 03:40:13 +0200 Original-Received: from localhost ([127.0.0.1]:43704 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q966u-0006yZ-Jg for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Apr 2011 21:40:12 -0400 Original-Received: from [140.186.70.92] (port=57151 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q95bB-0000iP-Qd for bug-gnu-emacs@gnu.org; Sun, 10 Apr 2011 21:07:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q95bA-0003M8-CI for bug-gnu-emacs@gnu.org; Sun, 10 Apr 2011 21:07:25 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46969) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q95bA-0003M4-9Q for bug-gnu-emacs@gnu.org; Sun, 10 Apr 2011 21:07:24 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Q95FX-0006bO-Ah; Sun, 10 Apr 2011 20:45:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alp Aker Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Apr 2011 00:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 8470 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.130248265825296 (code B ref -1); Mon, 11 Apr 2011 00:45:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 11 Apr 2011 00:44:18 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q95En-0006Zu-CM for submit@debbugs.gnu.org; Sun, 10 Apr 2011 20:44:18 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q947v-00052q-SP for submit@debbugs.gnu.org; Sun, 10 Apr 2011 19:33:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q947p-0002BM-LL for submit@debbugs.gnu.org; Sun, 10 Apr 2011 19:33:02 -0400 Original-Received: from lists.gnu.org ([199.232.76.165]:50701) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q947p-0002AJ-Id for submit@debbugs.gnu.org; Sun, 10 Apr 2011 19:33:01 -0400 Original-Received: from [140.186.70.92] (port=36217 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q947o-0000d4-LR for bug-gnu-emacs@gnu.org; Sun, 10 Apr 2011 19:33:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q947n-00028H-FC for bug-gnu-emacs@gnu.org; Sun, 10 Apr 2011 19:33:00 -0400 Original-Received: from exprod7og115.obsmtp.com ([64.18.2.217]:42957) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1Q947n-00028A-6U for bug-gnu-emacs@gnu.org; Sun, 10 Apr 2011 19:32:59 -0400 Original-Received: from mb2i1.ns.pitt.edu ([136.142.11.153]) by exprod7ob115.postini.com ([64.18.6.12]) with SMTP ID DSNKTaI+J8BB24/g/CEN7eb6izsFCy976Iez@postini.com; Sun, 10 Apr 2011 16:32:59 PDT Original-Received: from unixs1.cis.pitt.edu ([136.142.4.246]) by pitt.edu (PMDF V6.3-x11 #31505) with ESMTP id <0LJG00BC4MQV2X@mb2i1.ns.pitt.edu> for bug-gnu-emacs@gnu.org; Sun, 10 Apr 2011 19:32:55 -0400 (EDT) X-X-Sender: aker@unixs1.cis.pitt.edu X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Mailman-Approved-At: Sun, 10 Apr 2011 20:44:15 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 10 Apr 2011 20:45:03 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-Mailman-Approved-At: Sun, 10 Apr 2011 21:40:08 -0400 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:45745 Archived-At: ns_dumpglyphs_stretch (in nsterm.m) checks to make sure that it doesn't overwrite a window's right fringe or scroll bar. It doesn't perform an analogous check for overruns on the left. This can cause display artifacts to appear when a window is horizontally scrolled. Here is a screenshot showing an extreme example of what can happen: http://www.pitt.edu/~aker/screenshot.png The problem has been around since at least 23.2.1 and still exists in the trunk. The following patch (against the latest nsterm.m) appears to fix the problem: *** nsterm.m 2011-04-10 19:21:28.000000000 -0400 --- nsterm-rev.m 2011-04-10 19:23:54.000000000 -0400 *************** *** 2981,2986 **** --- 2981,2995 ---- - (WINDOW_BOX_RIGHT_EDGE_X (s->w) - WINDOW_RIGHT_FRINGE_WIDTH (s->w))); r[i].size.width -= overrun; + + /* truncate to avoid overwriting to left of the window box */ + int leftoverrun = (WINDOW_BOX_LEFT_EDGE_X (s->w) + + WINDOW_LEFT_FRINGE_WIDTH (s->w)) - s->x; + if (0 < leftoverrun) + { + r[i].origin.x += leftoverrun; + r[i].size.width -= leftoverrun; + } /* XXX: Try to work between problem where a stretch glyph on a partially-visible bottom row will clear part of the