error in tmm-menubar caused by selecting current frame

error in tmm-menubar caused by selecting current frame

[David Casperson]

In GNU Emacs 21.3.1 (sparc-sun-solaris2.8, X toolkit)
 of 2003-05-25 on csfac007.unbc.ca
configured using `configure  --prefix=/ld1/local'
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: en_US.ISO8859-1
  value of $LC_CTYPE: en_US.ISO8859-1
  value of $LC_MESSAGES: C
  value of $LC_MONETARY: en_US.ISO8859-1
  value of $LC_NUMERIC: en_US.ISO8859-1
  value of $LC_TIME: en_US.ISO8859-1
  value of $LANG: en_US.ISO8859-1
  locale-coding-system: iso-latin-1
  default-enable-multibyte-characters: t

> Please describe exactly what actions triggered the bug
> and the precise symptoms of the bug:

running emacs -q
and then typing

C-x 5 2                ;; cause multiple frames to exist
C-x d RET              ;; with truly distinct names
M-`                    ;; menu-bar
b                      ;;   buffers
f                      ;;     frames
0                      ;;       (The current frame, perhaps not labelled
                       ;;        with 0)

causes

menu-bar-select-frame: Wrong type argument: framep, nil

-----

The following seems to work as a patch

*** /ld1/local/share/emacs/21.3/lisp/menu-bar.el	Tue Apr 23 08:13:16 2002
--- /tmp/menu-bar.el	Tue Feb  8 12:46:03 2005
***************
*** 1008,1017 ****
--- 1008,1018 ----
    (interactive)
    (let (frame)
      (dolist (f (frame-list))
        (when (equal last-command-event (frame-parameter f 'name))
  	(setq frame f)))
+   (setq frame (or frame (selected-frame)))
    (make-frame-visible frame)
    (raise-frame frame)
    (select-frame frame)))

  (defun menu-bar-update-buffers-1 (elt)
---

Yes, selecting the current frame is a little silly, but it shouldn't cause
a lisp-y error message.

Yours sincerely,
David
-- 
Dr. David Casperson                          |  casper@unbc.ca
Computer Science                             |  x6672    Fax.5544