From: Gabriel <gabriel376@hotmail.com>
To: 60073@debbugs.gnu.org
Subject: bug#60073: 30.0.50; [PATCH] Tab bar group format not applied to current
Date: Wed, 14 Dec 2022 17:16:24 -0300 [thread overview]
Message-ID: <PH8PR19MB7070310B60AFEF560BBFB61F8BE09@PH8PR19MB7070.namprd19.prod.outlook.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]
Description:
The user option 'tab-bar-tab-group-format-function' is not applied to
current group tab, only to other group tabs. I suspect this is not
intentional and could be fixed by the attached patch.
Steps:
1) emacs -Q (master "42c757913a4c6acc07f8904df7def6b720bb23b4")
2) Enable tab bar and create some tabs and groups:
(progn
(tab-bar-mode 1)
(tab-bar-change-tab-group "group1")
(tab-new)
(tab-bar-change-tab-group "group2")
(tab-new)
(tab-bar-change-tab-group "group2")
(tab-new)
(tab-bar-change-tab-group "group3"))
3) Set a custom function to format group tabs:
(progn
(defun my-tab-bar-group-format (tab i)
(format "<%s (%s)>"
(funcall tab-bar-tab-group-function tab)
i))
(setopt tab-bar-format '(tab-bar-format-tabs-groups)
tab-bar-tab-group-format-function 'my-tab-bar-group-format))
4) Change tabs a couple of times with 'C-x t o' ('tab-next')
Result: The 'tab-bar-tab-group-format-function' is not applied to format
the current group tab, only to other group tabs. See attach patch for a
proposed fix. If this behavior is intentional, I propose to update the
doc string.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-incorrect-format-of-current-tab-bar-group.patch --]
[-- Type: text/x-diff, Size: 996 bytes --]
From da2025d524da5b76e4f2bc81d51899d9b798888c Mon Sep 17 00:00:00 2001
From: Gabriel do Nascimento Ribeiro <gabriel376@hotmail.com>
Date: Wed, 14 Dec 2022 17:10:28 -0300
Subject: [PATCH 1/1] Fix incorrect format of current tab bar group
* lisp/tab-bar.el (tab-bar--format-tab-group): Make proper use of
'tab-bar--format-tab-group' to format the current tab bar group.
---
lisp/tab-bar.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el
index 162e63fe23..65e424080d 100644
--- a/lisp/tab-bar.el
+++ b/lisp/tab-bar.el
@@ -882,7 +882,7 @@ tab-bar--format-tab-group
`((,(intern (format "group-%i" i))
menu-item
,(if current-p
- (propertize (funcall tab-bar-tab-group-function tab)
+ (propertize (funcall tab-bar-tab-group-format-function tab i)
'face 'tab-bar-tab-group-current)
(funcall tab-bar-tab-group-format-function tab i))
,(if current-p 'ignore
--
2.34.1
[-- Attachment #3: Type: text/plain, Size: 13 bytes --]
---
Gabriel
next reply other threads:[~2022-12-14 20:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 20:16 Gabriel [this message]
2022-12-15 15:04 ` bug#60073: 30.0.50; [PATCH] Tab bar group format not applied to current Gabriel
2022-12-15 18:04 ` Juri Linkov
2022-12-15 18:05 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH8PR19MB7070310B60AFEF560BBFB61F8BE09@PH8PR19MB7070.namprd19.prod.outlook.com \
--to=gabriel376@hotmail.com \
--cc=60073@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).