From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Shynur Xie Newsgroups: gmane.emacs.bugs Subject: bug#65735: [PATCH] key-translate should use the 1st key of a key sequence Date: Thu, 7 Sep 2023 13:42:18 +0000 Message-ID: References: <87edjafmfu.fsf@gmail.com> <83zg1yz9e7.fsf@gnu.org> <87a5tyfb6t.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40578"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "65735@debbugs.gnu.org" <65735@debbugs.gnu.org> To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 07 15:43:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qeFHt-000AMI-WC for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Sep 2023 15:43:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qeFHk-0005tZ-N2; Thu, 07 Sep 2023 09:43:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeFHh-0005rx-DI for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 09:43:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qeFHg-0000Ce-WD for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 09:43:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qeFHi-0007N4-Jj for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 09:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Shynur Xie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Sep 2023 13:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65735 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65735-submit@debbugs.gnu.org id=B65735.169409415028279 (code B ref 65735); Thu, 07 Sep 2023 13:43:02 +0000 Original-Received: (at 65735) by debbugs.gnu.org; 7 Sep 2023 13:42:30 +0000 Original-Received: from localhost ([127.0.0.1]:38904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeFHB-0007M2-JS for submit@debbugs.gnu.org; Thu, 07 Sep 2023 09:42:29 -0400 Original-Received: from mail-dm6nam04olkn2075.outbound.protection.outlook.com ([40.92.45.75]:41830 helo=NAM04-DM6-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeFH8-0007Lp-LA for 65735@debbugs.gnu.org; Thu, 07 Sep 2023 09:42:28 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bpRhYE6+MOCtS5L7otqHnz1DXzflheBkIXnylW25Rnt2nLI/XSJ5Hcu7PRikXXzJxCnWRkeXsanhgrjeettVWPSBZJvDDUETRpbki/ELvlFl9HDmToWf6qQHWsh3v9dq3RMCPqQ1ey0nJnzdOABo1QP6JzXNo3s3tg0Yru/X2EUULNfd66gmU7uXJMLkdLGEcvBTAddPBhb7ahEZyA2WuGFrYuWWWWcePzQW4HANVH1ZZrUVKcz7EwVLngiRJ6yeyKFHqGtZqNhYOagTs0kxQZyBnN3nzKGKSvrmnphglSmcF2of6aaXak802Sxup8rVFVgAWsVs3nnPqwQnWOZcug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CKKtkjxXKiYZqSqohTJHMd+o7QP+v4xu9qGbkFlJJdE=; b=jTEgkgsPjAX6CMCFj2aiCVVeIeWBOOr9PAKxr1Rp4LzDQ36qMWOuFTUM1g5gkmIA3pa8NcoaM6j3MqIZPodu8aU80w0KHgVxeESEMtSO7qErhAJ9FPrNUlo6Ir6z/VVKc/ZM/wRykxisqGa/JOgo8548uZRlU2O99MGAjwYnUttVKRFCqb2yQyLAkZvlds4ELFeQq0i0crFL/jDj4GeVdRtT2kBRvzNVC5/4vGdRWrPvMOn45BWbVEbraKPRkuaLvnq1aRvvJT/dRQVaXJdVJwqX3ybcyk+JstjVji7mIyjR4iUqxUhpMmobN/CyzH3lYCZN27LIHp6gwstl7k+yBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CKKtkjxXKiYZqSqohTJHMd+o7QP+v4xu9qGbkFlJJdE=; b=tJKEs6QrFJ78LgEhaugqGaFZDAN7j2GG7qynfPWlLI2uMcPqifsrha5hrtt6NzoThiABCC496wAr+gd19as0xiWl5DJ0YNiHJxcE2C/Y1XdL/lYs2HaOeAa+Qg7X8vifAp8mkg2SFqa1+FYgP/TyL0bHZdnchL8GJj9mqvq78kWNlkvGaAyPUTpAZU0SKxrAPiHEJyAlm/ZkL5/AZC4XolNaNtzREkcru9rYfoUdqA7svuO56Pjo+RDwCX9E0+jZtY+yeH/uJIiLEPVYbBSHMg1YlHWltScDSkws2S/j2YEmU8Ty5pm3QMhFQU7sWWpE0UCqNQwRDny48NZrd2n9YA== Original-Received: from PH0PR11MB7470.namprd11.prod.outlook.com (2603:10b6:510:288::7) by DS0PR11MB6446.namprd11.prod.outlook.com (2603:10b6:8:c5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.34; Thu, 7 Sep 2023 13:42:18 +0000 Original-Received: from PH0PR11MB7470.namprd11.prod.outlook.com ([fe80::d0b8:54f7:2a45:2983]) by PH0PR11MB7470.namprd11.prod.outlook.com ([fe80::d0b8:54f7:2a45:2983%5]) with mapi id 15.20.6745.034; Thu, 7 Sep 2023 13:42:18 +0000 Thread-Topic: bug#65735: [PATCH] key-translate should use the 1st key of a key sequence Thread-Index: AQHZ30ZWfTedSoNs3EuVYxTxkKMnFrAPAnNxgAAGEr6AAD3V/YAAHRJQ In-Reply-To: <87a5tyfb6t.fsf@gmail.com> Accept-Language: en-US, zh-CN Content-Language: en-US x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [Y5EUUQGr0nO5t5qcVX2JV5i5DZGUD5UP] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB7470:EE_|DS0PR11MB6446:EE_ x-ms-office365-filtering-correlation-id: c5a587d0-a237-4767-3795-08dbafa840e6 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pBaltfVS6sS1GmDqEI0qayQ7UMoYIfsbj92udRhORxo89EerPL3iYHdwRunQzizTYOSK0Ow0ZYRg5GxHBUV4yKoCHWHHqcn5gNvlUWKqdE1fkX+MX3n/cmbMBNqN6QyuyM4Ui8/zfblg8Fiib8FlzTSCAkF3jP68AqTdqlRpbuzIhKuoswbAiqRdCn6Tc9l1NEYB1sSjAGyt9W8mdhpuacttzecO/d53iVuYO1R8w/li8raZRVFlB8yLcSkJjflV6rRhCoteShRjO7yoUZdU5nCVGZZuVnZkYLI0cATdtDyLjGENWvkat3Sw3X28dQrKLSJjJX/xIB9Y+B7Kl3HB9iQnXae6vsb5AOMFvvVI4uz8OIe+cOkFwOzmgWZceAdzFFMF5FSDOjF56aDkYXU8ObL0a3V2kg3gkE8GlOU42ESBNfxqU1LBB25WUA2fOzr8G86rKK72ioTi+cayVjF+LO8qsbkpSQuMMWtlEao5nkiC0bcn/TUe8C6kuaPIda9h9WIobbKk6yGpibfsOltcF2s5FvC3gKK8XoHFt1XmE5QG3wRHwM42SG8Vd1BvYg+u x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: swxz42lHQDxCYL4ZZFWBLRAELNqjDYEsNSwqTnj7to6Tv/QRYUZaa2wajd/TvF6W+iNzg8H42FV2V7ag5SWiI4FvE4PEYqb9BVQerD/ep4sx9dy45czSd5FIiFsKkKohFxl1QZNf9lCLNWaCADUbZ5CHy658yrcpMS1lgRHYPHl48YN8ID//nuFPXirGSgFZd1uB1T2ayb+g1wVpWOhRpnxJPqKR03cJe2CEWLzsS9FFHyndykhar+/24CyobJ1MBGZaqHxsUmkklfEIbxtiNYTYbIYyi4wCa5xUBZSmjjS+onqcmIF2W2a9XrSAZ2FmP+eg5VVEF8KQgRlv4HFLCGYEQWcFSvI2nVHSkENuDGaM2+2areiZSqDRwy5qQfcnTNttaCVi2KAfu9fcu83+Tr5ZHrvqMj32/I4GhjC5JTnndOPBHSJghha4gKXJblICW4lNlWyyF0PM6pXKgFpjKLt16BYWN6ueixXupgXlyaDpBHtfczYRtmNUQJJ0GdmofN+qMwvWBCe6BiskliNFrARjSQ03nRdL2fnex++l80M3C2NwiAgInJaFLx172fliQUS8hqzKg4DVI4D7sWQFAl+08fgvNibQhMEywQRbdzoxdNpmgbDX8zYLqW0NTrtJkxFXyq6NWAa7hHmeIAgOfzz8z4YcmalXJTGyVQWf9KGKdIHxabWlmN/aryDJooPThbdHFunoXtHJELcBt6ks5W8A0Pe/0DO8pWccPM1zSgKrKocXRJ+a0sVGtc riVSzs7ZfF76oBWgxDW80LBUU0MwxouQDN8eCPJ57exGYmdsKPRJdTKVtX4kxpFUJHEOsk0YUVv1omk79mxkZXy4SUZp4lakp6 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB7470.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: c5a587d0-a237-4767-3795-08dbafa840e6 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2023 13:42:18.0661 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6446 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269657 Archived-At: > Robert:=0A= > Perhaps we should also check that `from' and `to' specify single=0A= > keys, although that might be overkill.=0A= =0A= Not necessary IMO.=0A= As a regular Emacs user, I would read its docstring before using this=0A= function; the docstring already explains how to use it very clearly.=0A= Moreover, there're several examples in the elisp manual for reference:=0A= =0A= +----------------------------------------------------+=0A= | -- Function: key-translate from to |=0A= | ... ... |=0A= | Here=92s an example of ... |=0A= | (key-translate "C-x" "") |=0A= | (keymap-global-set "" 'kill-region) |=0A= +----------------------------------------------------+=0A= =0A= > Robert:=0A= > do you have a copyright assignment on file?=0A= =0A= Yes.=0A= =0A= > Robert:=0A= > --- i/lisp/simple.el=0A= > +++ w/lisp/simple.el=0A= =0A= > - (keyboard-translate ?\C-h ?\C-?)=0A= > - (keyboard-translate ?\C-? ?\C-d))=0A= > - (keyboard-translate ?\C-h ?\C-h)=0A= > - (keyboard-translate ?\C-? ?\C-?))))=0A= > + (key-translate "C-h" "DEL")=0A= > + (key-translate "DEL" "C-d"))=0A= > + (key-translate "C-h" "C-h")=0A= > + (key-translate "DEL" "DEL"))))=0A= =0A= The docstring of `keyboard-translate' does suggest using=0A= `key-translate'; similarly, `define-key' suggests using `keymap-set'.=0A= =0A= FWIW, I noticed that there're also some `define-key' invocations in=0A= the file "lisp/simple.el".=