From: Shynur Xie <one.last.kiss@outlook.com>
To: Eli Zaretskii <eliz@gnu.org>, Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "65700@debbugs.gnu.org" <65700@debbugs.gnu.org>
Subject: bug#65700: time when gcs-done is updated needs to be clarified
Date: Thu, 7 Sep 2023 15:23:08 +0000 [thread overview]
Message-ID: <PH0PR11MB747079C03D3AA87ABD1CA6DFD7EEA@PH0PR11MB7470.namprd11.prod.outlook.com> (raw)
In-Reply-To: <837cp2yr9l.fsf@gnu.org>
> Eli:
>
> > I'm not a native English speaker. Does the POST in `post-gc-hook'
> > mean the functions will run when GC is DONE?
>
> Its being "done" doesn't necessarily have to include updating the
> count of GCs. The main job of GC is already done by the time the
> hook is called.
Thanks for explaining. Yes, "Its being 'done' doesn't necessarily
have to include updating the count of GCs."
My point is, IF "the functions will run when GC is DONE" THEN when
these functions are being executed, the `gcs-DONE' should have been
updated.
> Eli:
>
> > > Is this an intended behavior? If so, I think the docstring of
> > > these variables (such as `gcs-done', `gc-elapsed', ...) need to
> > > clarify when the variable is updated.
>
> > And `garbage-collection-messages'.
>
> What about it?
Mentioning it here is just for reference. Maybe you want clarify when
the variable/message is updated/generated in the docstring.
> Stefan:
> Hmm... that doesn't really explain in which way this affects your
> code.
It does.
> `gcs-done` will be always smaller by 1
That's it.
next prev parent reply other threads:[~2023-09-07 15:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-02 13:00 bug#65700: time when gcs-done is updated needs to be clarified Shynur Xie
2023-09-07 9:14 ` Eli Zaretskii
2023-09-07 13:38 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-07 14:35 ` Shynur Xie
2023-09-07 14:47 ` Eli Zaretskii
2023-09-07 15:23 ` Shynur Xie [this message]
2023-09-07 16:52 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-07 17:19 ` Shynur Xie
2023-09-12 10:14 ` Shynur Xie
2023-09-12 12:53 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-12 18:07 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-07 14:58 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-07 15:08 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB747079C03D3AA87ABD1CA6DFD7EEA@PH0PR11MB7470.namprd11.prod.outlook.com \
--to=one.last.kiss@outlook.com \
--cc=65700@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).