From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#74786: [PATCH] Add custom args to test compile step Date: Sat, 04 Jan 2025 19:05:55 +0000 Message-ID: References: <86wmg62pfs.fsf@gnu.org> <87wmg643g4.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8711"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Robert Pluim , 74786@debbugs.gnu.org, Eli Zaretskii , "J.P." To: "O'Brien, Will" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 04 20:07:27 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tU9Ud-00026T-AU for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Jan 2025 20:07:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tU9UK-0005UL-It; Sat, 04 Jan 2025 14:07:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tU9UE-0005Tt-Vm for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 14:07:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tU9UE-0003fO-NI for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 14:07:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:From:Date:To:Subject; bh=y8gLd2lK/eYDx8PXKqgRETnYLc0/DTMfGJK4SDucPkY=; b=dGcI21zCkLwFNwagZWEBt3T3nWCK1TK4utrlMaDxPfNKYe7JkYlHGv3TvKj+k6cjKE2Hrr7GAWWJ4qq6XNoQIoca0AjAk4kEhjrdFBK9EsPlbEAZD0gwW6U74WpEgGOCZQQBNkZIHv5/ycPFaDirSVr4dVr93Dn7OFcN1Gcv3l83yMdMIEhCFkr/hKE0KZGFmDTK2qA1cP/8XJxXJcN5VHHEorimiCadCIik8UWJK5PbuhSxAVJoleC5un3dqYxqpwMIEltIWwXnb67T39PjXtgtCjZ//IsfGjETVRCleyb/lqIAeGs4zoL/0X2gxmiBK3kfwolyjvik306rNWBbvA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tU9UE-0007tw-H3 for bug-gnu-emacs@gnu.org; Sat, 04 Jan 2025 14:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Jan 2025 19:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74786 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74786-submit@debbugs.gnu.org id=B74786.173601757330295 (code B ref 74786); Sat, 04 Jan 2025 19:07:02 +0000 Original-Received: (at 74786) by debbugs.gnu.org; 4 Jan 2025 19:06:13 +0000 Original-Received: from localhost ([127.0.0.1]:57392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tU9TR-0007sZ-00 for submit@debbugs.gnu.org; Sat, 04 Jan 2025 14:06:13 -0500 Original-Received: from mail-4018.proton.ch ([185.70.40.18]:52327) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tU9TM-0007s0-Gm for 74786@debbugs.gnu.org; Sat, 04 Jan 2025 14:06:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail3; t=1736017561; x=1736276761; bh=y8gLd2lK/eYDx8PXKqgRETnYLc0/DTMfGJK4SDucPkY=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=nK6ISeQBCky9aT9KmP1DWSRnDE/6jWbAz01NYk8k8emZXmJDGPu7jY4hUjfVldmXx 3BIlcUNYGQk5tpCk6Uo4eJ1Ir9K+sg8BxnKaUZU7bosMuLqNBKb43BNM1pLxLFCJqt JBJ2U9ZoRkr7j/7ZE4eoRAj1IYMYT9V9ibBu76GPIBA1Fz5PStnGpOLxXpMRpYU2tQ Uh9Q+vxmWzyE50gMLdRejL0TaaETLpX1osaEBMxT4j50zPD9tlrV/O8aLk7T+AANF5 WT0jTRCWN6/sU0JuJnpTs+dLmolm0+kvliOW41votjnZmvdKywG+mRoBfBTuLGbgvf 57/99T+GRWPZQ== In-Reply-To: Feedback-ID: 44397038:user:proton X-Pm-Message-ID: e35d7f9155d9dd04e57da588cb5d3798a5ee1a5b X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298453 Archived-At: On Thursday, January 2nd, 2025 at 06:21, O'Brien, Will wrote: >=20 >=20 > On Wed, Jan 01 2025 at 23:50, Randy Taylor dev@rjt.dev wrote: >=20 > > Thanks, the patch looks good to me. > > There is a typo: > > + "Return the flags for test invoation." > > ^invocation >=20 >=20 > Fixed. >=20 > [...] >=20 > > > I think that we can remove the `-run` flag from this function. > > > What do others think? Also, should this be a separate bug/patch > > > (if indeed it is a bug) or I can incorporate this change into the > > > current change set. > >=20 > > I believe you are correct, we can get rid of the -run flag. > > Please incorporate these changes as part of this patch. >=20 >=20 > Done. >=20 > > (Side note, maybe we should actually pass the package to > > go test instead of relying on default directory but > > don't worry about that for this patch). >=20 >=20 > Will raise a new issue. >=20 > best > -- > will Thanks, looks good to me. Eli, please install if you have no further comments. Thanks in advance.