From: Randy Taylor <dev@rjt.dev>
To: "O'Brien, Will" <will.08rien@gmail.com>
Cc: Robert Pluim <rpluim@gmail.com>,
74786@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>,
"J.P." <jp@neverwas.me>
Subject: bug#74786: [PATCH] Add custom args to test compile step
Date: Sat, 04 Jan 2025 19:05:55 +0000 [thread overview]
Message-ID: <OdsGyVhBHH3Ru221mc8-w-yiaJImLANYkLpO_UfCbPS-PgYRwEGuM7uv_WOu7ai6r5ufsJ2aiNEVjk9HrzrDUpEFLJaJTOpa1cX-7Bez_4A=@rjt.dev> (raw)
In-Reply-To: <m28qrtea0d.fsf@gmail.com>
On Thursday, January 2nd, 2025 at 06:21, O'Brien, Will <will.08rien@gmail.com> wrote:
>
>
> On Wed, Jan 01 2025 at 23:50, Randy Taylor dev@rjt.dev wrote:
>
> > Thanks, the patch looks good to me.
> > There is a typo:
> > + "Return the flags for test invoation."
> > ^invocation
>
>
> Fixed.
>
> [...]
>
> > > I think that we can remove the `-run` flag from this function.
> > > What do others think? Also, should this be a separate bug/patch
> > > (if indeed it is a bug) or I can incorporate this change into the
> > > current change set.
> >
> > I believe you are correct, we can get rid of the -run flag.
> > Please incorporate these changes as part of this patch.
>
>
> Done.
>
> > (Side note, maybe we should actually pass the package to
> > go test instead of relying on default directory but
> > don't worry about that for this patch).
>
>
> Will raise a new issue.
>
> best
> --
> will
Thanks, looks good to me.
Eli, please install if you have no further comments. Thanks in
advance.
next prev parent reply other threads:[~2025-01-04 19:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 10:18 bug#74786: [PATCH] Add custom args to test compile step O'Brien, Will
2024-12-11 15:45 ` Eli Zaretskii
2024-12-11 15:58 ` Robert Pluim
2024-12-11 16:31 ` O'Brien, Will
2024-12-15 2:17 ` Randy Taylor
2024-12-17 8:34 ` O'Brien, Will
2024-12-19 16:20 ` O'Brien, Will
2024-12-20 16:14 ` O'Brien, Will
2025-01-01 23:50 ` Randy Taylor
2025-01-02 11:21 ` O'Brien, Will
2025-01-04 19:05 ` Randy Taylor [this message]
2025-01-05 12:43 ` Eli Zaretskii
2024-12-17 2:41 ` J.P.
2024-12-17 8:32 ` O'Brien, Will
2024-12-11 16:30 ` O'Brien, Will
2024-12-11 17:10 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='OdsGyVhBHH3Ru221mc8-w-yiaJImLANYkLpO_UfCbPS-PgYRwEGuM7uv_WOu7ai6r5ufsJ2aiNEVjk9HrzrDUpEFLJaJTOpa1cX-7Bez_4A=@rjt.dev' \
--to=dev@rjt.dev \
--cc=74786@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=jp@neverwas.me \
--cc=rpluim@gmail.com \
--cc=will.08rien@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).