From: "赵 纪阳" <zjyzhaojiyang@hotmail.com>
To: Theodor Thornhill <theo@thornhill.no>
Cc: "61142@debbugs.gnu.org" <61142@debbugs.gnu.org>
Subject: bug#61142: 回复: bug#61142: 回复: bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions
Date: Mon, 6 Feb 2023 02:34:12 +0000 [thread overview]
Message-ID: <OSZP286MB141766B19BE7950C65D99BBFA8DA9@OSZP286MB1417.JPNP286.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <878rhb7qss.fsf@thornhill.no>
[-- Attachment #1: Type: text/plain, Size: 1704 bytes --]
Hi Theo
This patch works well for me. Great! Thanks!
________________________________
发件人: Theodor Thornhill <theo@thornhill.no>
发送时间: 2023年2月6日 5:20
收件人: Eli Zaretskii <eliz@gnu.org>
抄送: zjyzhaojiyang@hotmail.com <zjyzhaojiyang@hotmail.com>; 61142@debbugs.gnu.org <61142@debbugs.gnu.org>
主题: Re: bug#61142: 回复: bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions
Theodor Thornhill <theo@thornhill.no> writes:
> Theodor Thornhill <theo@thornhill.no> writes:
>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>>>> Cc: "61142@debbugs.gnu.org" <61142@debbugs.gnu.org>
>>>> Date: Sun, 05 Feb 2023 20:19:19 +0100
>>>> From: Theodor Thornhill via "Bug reports for GNU Emacs,
>>>> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>>>
>>>> +(defvar c-ts-common-nestable-if-statement-p t
>>>> + "Does the current parser nest if-else statements?
>>>> +
>>>> +T if the current tree-sitter grammar nests the else if
>>>> +statements, NIL otherwise.")
>>>
>>> A nit: we use t and nil, lowercase, to refer to these two symbols.
>>>
>>> Thanks.
>>
>> Thanks!
>>
>> Theo
>
> I added some small tweaks, and will add the following as a test later:
>
I made even further tweaks, and while testing the c variant I noticed
that the C tests weren't actually working. There were missing rules for
many of the cases in the tests, so I added some more rules to the
c-ts-mode indentation and added a big-ish test with some wonky but
seemingly working indentation.
Because the tests are now working I think this is good to go, so unless
somebody objects I'll install this sometime tomorrow :-)
Theo
[-- Attachment #2: Type: text/html, Size: 3246 bytes --]
next prev parent reply other threads:[~2023-02-06 2:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <handler.61142.B.16749811447164.ack@debbugs.gnu.org>
2023-02-01 8:46 ` bug#61142: Acknowledgement (29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions) 太阳
2023-02-04 10:45 ` bug#61142: 29.0.60; java-ts-mode - Wrong indentation for the body of multiple lines conditions Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-05 7:53 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-05 7:54 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-05 9:20 ` Eli Zaretskii
2023-02-05 9:28 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-05 10:15 ` Eli Zaretskii
2023-02-05 10:25 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-05 10:59 ` Eli Zaretskii
2023-02-05 13:09 ` bug#61142: 回复: " 赵 纪阳
2023-02-05 19:19 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-05 19:30 ` Eli Zaretskii
2023-02-05 19:32 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-05 20:12 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-05 21:20 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-06 2:34 ` 赵 纪阳 [this message]
2023-02-06 6:45 ` bug#61142: 回复: " Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OSZP286MB141766B19BE7950C65D99BBFA8DA9@OSZP286MB1417.JPNP286.PROD.OUTLOOK.COM \
--to=zjyzhaojiyang@hotmail.com \
--cc=61142@debbugs.gnu.org \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).