From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#74461: [PATCH] Add go-work-ts-mode Date: Thu, 02 Jan 2025 00:53:00 +0000 Message-ID: References: <87ttbzd16p.fsf@disroot.org> <86jzcl81py.fsf@gnu.org> <877c8l55he.fsf@disroot.org> <1C8B596E-785F-435D-AFEA-A2382FDA6AD8@disroot.org> <69C7AB3A-F058-4EBC-922E-3C24D1F4A9CB@disroot.org> <0F06447F-3926-4F70-86F0-5F512598A362@disroot.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33412"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Stefan Monnier , 74461@debbugs.gnu.org To: Gabriel Santos Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 02 01:54:23 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tT9Tj-0008at-9C for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Jan 2025 01:54:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tT9TR-0008UR-0R; Wed, 01 Jan 2025 19:54:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tT9TO-0008Ty-GK for bug-gnu-emacs@gnu.org; Wed, 01 Jan 2025 19:54:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tT9TO-0007Ht-7l for bug-gnu-emacs@gnu.org; Wed, 01 Jan 2025 19:54:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:From:Date:To:Subject; bh=jU4w4+HXe/d6OdfHVrLK1u3iKVtdygxBte96hHjf9EE=; b=He3e1KOL90C/kUtw39eqGcZcGYJJIaKKkilyoRW7jvy0GB+IfQgT5DzO03dx38TXS3L70BXn0scCzf9EDQfqnqKNmYOXuzQpIho/YaGb5Mp5WgSn7Lvy6JEJBblgJgGPd7cyDnSeXwsEYtwi6vGOBXwllKCV3XFKuvwXA/Bwl0eABFh3BijM2iwRvp345mru8X85ysrM0YAy7BTV8twdZZkhSfV+wHM5+GLp+IXjyBLnvjXEqCtTE+6ECSBbMXT3coJpz2lS8sH87Th5pl6kgHGBlDqmoIru0V63XA95sl8Z6LX8VFU9hbYIGTCWXZzq+zTfrEbn75gTZsQzFkEOEg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tT9TN-0007C3-Qr for bug-gnu-emacs@gnu.org; Wed, 01 Jan 2025 19:54:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Jan 2025 00:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74461 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74461-submit@debbugs.gnu.org id=B74461.173577919527593 (code B ref 74461); Thu, 02 Jan 2025 00:54:01 +0000 Original-Received: (at 74461) by debbugs.gnu.org; 2 Jan 2025 00:53:15 +0000 Original-Received: from localhost ([127.0.0.1]:40957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tT9Sc-0007Az-Sf for submit@debbugs.gnu.org; Wed, 01 Jan 2025 19:53:15 -0500 Original-Received: from mail-4018.proton.ch ([185.70.40.18]:20777) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tT9SZ-0007Ak-6Q for 74461@debbugs.gnu.org; Wed, 01 Jan 2025 19:53:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail3; t=1735779184; x=1736038384; bh=jU4w4+HXe/d6OdfHVrLK1u3iKVtdygxBte96hHjf9EE=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=RVnZX9asqQ7LHZ/VrUpvFrfJdTtLC0BsS0dYFw6VbFkrOAFj+8HRuY029PEu94JO1 R+NUF90DrcQUCeQXU9iDbsblMQW1cy0aRgrBro559Or0DY8MOooIYsWGDBmU4d6keo A7zJkG14gBDPZiYi7ewuPRbbWrrRbqLi0Q61NNPQsGm7hyPEc49sHbaRxBbosQwLGF /O+3OdCOJ/W0OkB+wGAh1fQk+j0aNYCbaJnophgD/tbYgbwUA+9JpoSD+n7T1xVvrG lpW3ukr88FLUDh575FIZi1L/mBQU7dZhWWsFggY0Jh/J7n43bCRyOTfW1SrennGGXc BTXDq6zxJq4AQ== In-Reply-To: <0F06447F-3926-4F70-86F0-5F512598A362@disroot.org> Feedback-ID: 44397038:user:proton X-Pm-Message-ID: 00873bd26a705ddf5e63a1948ff3c77a78592d5b X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298076 Archived-At: On Wednesday, December 25th, 2024 at 15:17, Gabriel Santos wrote: >=20 >=20 > Actually, since it's not that big of an issue, I'll send in the patch now= . >=20 > Em 22 de dezembro de 2024 09:12:21 BRT, Gabriel Santos gabrielsantosdesou= za@disroot.org escreveu: >=20 > > > I'll make the changes you requested and send the updated patch after = I'm done. > >=20 > > I just finished updating the patch, > > but I think it's best to only send it after > > the point about *--in-directive-p is clarified. I just replied to that in another email. > > -- > > Gabriel Santos >=20 >=20 > -- > Gabriel Santos Thanks, I've got a few comments. Recently, a commentary section: ;;; Tree-sitter language versions was added to go-ts-mode. Perhaps you can adapt what you wrote in the commentary section to that? - :syntax-table go-ts-mode--syntax-table Did you mean to remove this for go-work-ts-mode instead? The commit also mentions `go-work-ts-mode--syntax-table' which doesn't exist anymore.