unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Randy Taylor <dev@rjt.dev>
To: Gabriel Santos <gabrielsantosdesouza@disroot.org>
Cc: Eli Zaretskii <eliz@gnu.org>,
	Stefan Monnier <monnier@iro.umontreal.ca>,
	74461@debbugs.gnu.org
Subject: bug#74461: [PATCH] Add go-work-ts-mode
Date: Thu, 02 Jan 2025 00:53:00 +0000	[thread overview]
Message-ID: <JC8uBkNgHc2L0Nb6Bmz2YhUww1-6wsyNmLaEQeBN3Ixbm79oda_mq8EUM1vKAivlDPE9ihbK7t9gaj4LfsAQ_oSmek0Xff4XW_2rTGX17KE=@rjt.dev> (raw)
In-Reply-To: <0F06447F-3926-4F70-86F0-5F512598A362@disroot.org>

On Wednesday, December 25th, 2024 at 15:17, Gabriel Santos <gabrielsantosdesouza@disroot.org> wrote:
> 
> 
> Actually, since it's not that big of an issue, I'll send in the patch now.
> 
> Em 22 de dezembro de 2024 09:12:21 BRT, Gabriel Santos gabrielsantosdesouza@disroot.org escreveu:
> 
> > > I'll make the changes you requested and send the updated patch after I'm done.
> > 
> > I just finished updating the patch,
> > but I think it's best to only send it after
> > the point about *--in-directive-p is clarified.

I just replied to that in another email.

> > --
> > Gabriel Santos
> 
> 
> --
> Gabriel Santos

Thanks, I've got a few comments.

Recently, a commentary section:
;;; Tree-sitter language versions
was added to go-ts-mode. Perhaps you can adapt what you wrote in
the commentary section to that?

-  :syntax-table go-ts-mode--syntax-table
Did you mean to remove this for go-work-ts-mode instead?
The commit also mentions `go-work-ts-mode--syntax-table'
which doesn't exist anymore.





  reply	other threads:[~2025-01-02  0:53 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-21 10:49 bug#74461: [PATCH] Add go-work-ts-mode Gabriel Santos via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-21 16:02 ` Eli Zaretskii
     [not found]   ` <F23F09F1-D3C4-4133-AC46-67E7E1C35BDA@disroot.org>
2024-11-21 19:14     ` Eli Zaretskii
2024-11-22  0:13 ` Gabriel Santos via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-22  2:36 ` Randy Taylor
2024-11-22 10:15 ` Gabriel Santos via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-30 10:17   ` Eli Zaretskii
2024-11-30 11:24     ` Gabriel Santos via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-01 20:42       ` Randy Taylor
2024-12-01 23:00         ` Gabriel Santos via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-02  6:12           ` Stefan Kangas
2025-01-02  6:14             ` Stefan Kangas
2024-12-22  3:10       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-22 11:32         ` Gabriel Santos via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-22 12:12           ` Gabriel Santos via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-25 20:17             ` Gabriel Santos via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-02  0:53               ` Randy Taylor [this message]
2025-01-02  1:53                 ` Gabriel Santos via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-22 15:33           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-22 16:05             ` Gabriel Santos via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-23  3:31             ` Dmitry Gutov
2025-01-02  0:32           ` Randy Taylor
2025-01-02  0:57             ` Gabriel Santos via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-18 22:57 ` Gabriel Santos via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-22  2:33 ` bug#74461: [PACH] " Gabriel Santos via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-22  7:04   ` Eli Zaretskii
2025-01-02  2:24 ` bug#74461: [PATCH] " Gabriel Santos via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-04 19:13   ` Randy Taylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='JC8uBkNgHc2L0Nb6Bmz2YhUww1-6wsyNmLaEQeBN3Ixbm79oda_mq8EUM1vKAivlDPE9ihbK7t9gaj4LfsAQ_oSmek0Xff4XW_2rTGX17KE=@rjt.dev' \
    --to=dev@rjt.dev \
    --cc=74461@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=gabrielsantosdesouza@disroot.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).