From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#60805: [PATCH] Extend go-ts-mode with command to add docstring to function Date: Sat, 21 Jan 2023 03:30:40 +0000 Message-ID: References: <87sfgdtga2.fsf@thornhill.no> <875yd4njdc.fsf@thornhill.no> <87r0vpv7fp.fsf@thornhill.no> <87a62dkkj5.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36144"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Evgeni Kolev , Eli Zaretskii , 60805@debbugs.gnu.org To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 21 04:31:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJ4b5-0009Am-VW for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Jan 2023 04:31:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJ4av-0003Bd-MJ; Fri, 20 Jan 2023 22:31:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJ4as-0003BK-H8 for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2023 22:31:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pJ4as-0002QC-9a for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2023 22:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pJ4ar-0003LZ-Oj for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2023 22:31:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Jan 2023 03:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60805 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60805-submit@debbugs.gnu.org id=B60805.167427185312847 (code B ref 60805); Sat, 21 Jan 2023 03:31:01 +0000 Original-Received: (at 60805) by debbugs.gnu.org; 21 Jan 2023 03:30:53 +0000 Original-Received: from localhost ([127.0.0.1]:47651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJ4ai-0003L9-L3 for submit@debbugs.gnu.org; Fri, 20 Jan 2023 22:30:52 -0500 Original-Received: from mail-4323.proton.ch ([185.70.43.23]:28219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJ4ag-0003Kr-53 for 60805@debbugs.gnu.org; Fri, 20 Jan 2023 22:30:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1674271843; x=1674531043; bh=L7oFQCIrLHKltaBeQ8KFaPr+9ajc+njdjj8df8NTYl8=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=Np9g2hanEy1rczdkSsVgffLC2z0NYFTOys6IoFOTpc6kDQ16o8fg1sljdEBRRQqVO JVD4dvHYRXSjbA5NTcf1PW3I+rTMa6kS/WLBVzlx46Xk37FITccmpyRUYv+7BUl/AL Uvw9xepsV1KsVkz+sFX02/xVPl+yJ4J+GyU/RIsrcnPLRaAqSMl8NR1ZrYvUDbotFn Iwtk2XsDVtrPpdKwo/M/S3kK1CZZGCo0DuJAeBMFRi5CS9ruy1kIj4t0l2z3+ktFI5 EaZgYOeoQAWTWrfQRB1HneUc1Xq+VjGSV6nL59LYkT4EDus6s5w6ynXn8kMXwhOfFR HG9QxlTrC8eeQ== In-Reply-To: <87a62dkkj5.fsf@thornhill.no> Feedback-ID: 44397038:user:proton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253818 Archived-At: On Friday, January 20th, 2023 at 15:39, Theodor Thornhill via "Bug reports = for GNU Emacs, the Swiss army knife of text editors" wrote: >=20 > Evgeni Kolev evgenysw@gmail.com writes: >=20 > > I'm sending an updated patch. The improvement is that empty lines are > > not considered comments. Example: > > ``` > > // unrelated comment > >=20 > > // docstring > > func sum(a, b int) int { > > return a + b > > } > > ``` > > With point in the function body, C-c C-d jumps to "// docstring" > > instead of "// unrelated comment". > >=20 > > Patch is below. >=20 >=20 > Thanks! >=20 > @Randy, anything you want to add? Only thing I would consider is if C-c C-d is the best keybind for it. go-mo= de seems to use C-c C-d to describe the expression at point. Not sure what = else we would use C-c C-d for so it seems fine to me. And if we decide to h= ave something similar to this across other ts modes, it would be nice if we= could keep them consistent. If everyone's happy with C-c C-d, then I am to= o. Otherwise, it looks good to me. Thanks for continuing to work on go-ts-mode= , I should probably stop slacking so much ;). >=20 > By the way, the patch doesn't apply cleanly on my system, could you > resend the patch as an attachment, maybe?=20 Indeed. Evgeni, in the future can you submit all your patches as attachment= s? I've never been able to apply them cleanly and I'm not sure why. > And also, have you done the paperwork for emacs contributions? He should be good here, he submitted a big go-ts-mode patch a few weeks ago= :). >=20 > Theo