From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#61302: 29.0.60; rust-ts-mode does not show function-invocation on field-properties Date: Mon, 06 Feb 2023 02:06:23 +0000 Message-ID: References: <6209c097-0369-828a-7513-d8afb73fd7f0@secure.kjonigsen.net> <11c83963-752c-e4c0-40a0-876b32a08017@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5584"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jostein@kjonigsen.net, 61302@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 06 03:07:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pOqun-0001Hh-29 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Feb 2023 03:07:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pOquZ-00027h-QC; Sun, 05 Feb 2023 21:07:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOquS-000273-C8 for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2023 21:07:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pOquL-0001sD-Pj for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2023 21:07:08 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pOquL-0003r9-Lt for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2023 21:07:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Feb 2023 02:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61302 X-GNU-PR-Package: emacs Original-Received: via spool by 61302-submit@debbugs.gnu.org id=B61302.167564919914794 (code B ref 61302); Mon, 06 Feb 2023 02:07:01 +0000 Original-Received: (at 61302) by debbugs.gnu.org; 6 Feb 2023 02:06:39 +0000 Original-Received: from localhost ([127.0.0.1]:46979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOqty-0003qY-LX for submit@debbugs.gnu.org; Sun, 05 Feb 2023 21:06:39 -0500 Original-Received: from mail-4317.proton.ch ([185.70.43.17]:13191) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOqtw-0003qI-5d for 61302@debbugs.gnu.org; Sun, 05 Feb 2023 21:06:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1675649189; x=1675908389; bh=bDpsUh3X0mzyU/3dbc2la8Ns220C4qmMwmKdPWMdVx4=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=Ia0BJS9+mH38P4kpelKq1iH9Iv79OYQtLKD7Hn55USPgXTqrzbxTSvj4jxv+yUpNE mI1tOrPP0lR8fqaPsKPnlww+TGgnKhw62impptP/H7WzwglobpoRK3+LX5yUuKjh1r Q1TYRadygKHbLwgsbkT1fQqewC8aPW4SppOGK+n5zOEfNv+IndEOTVDhh9ud43c/ql qOReikKXWg4ccG4BRW1lpQD/qIxFbyOjfnmFMQIMDfGB8M1Q6/bmRfy/8Axa7tO4uA 6RUBdrtQ35ECjrI0UqZgMx31UJUKkR539ssb/s9YrhKtWe6iLz3/wGHX5dtERITiPG 2NBFx0mqyhFIA== In-Reply-To: <11c83963-752c-e4c0-40a0-876b32a08017@yandex.ru> Feedback-ID: 44397038:user:proton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254918 Archived-At: On Sunday, February 5th, 2023 at 16:56, Dmitry Gutov wro= te: > Hi Randy, >=20 > Maybe I was too quick to commit the change. But let's discuss it. No, it's fine. You can also see my reply to Jostein. BTW thanks for your work on the other modes and sorry for my lack of replie= s, I've been busy as of late. >=20 > On 05/02/2023 23:30, Randy Taylor wrote: >=20 > > That's expected (at least to me) because it's a property. >=20 >=20 > It's both a property and a function, isn't it? Sure. But it's still a property, and I wanted them all highlighted the same= (or at least the ability to do so). >=20 > > The same > > applies to c-ts-mode and go-ts-mode as well. >=20 >=20 > Regarding c-ts-mode, it might be a simple oversight, given that > constructs like >=20 > p->handler (it) >=20 >=20 > do not come up very often. But if we take js-ts-mode, for example, where > a property is often a function, the property name is highlighted as a > function in a funcall. Maybe in c-ts-mode it's not common, but in c++-ts-mode it is and it shares = those rules. >=20 > And speaking of c-ts-mode, this can fix that omission: >=20 > diff --git a/lisp/progmodes/c-ts-mode.el b/lisp/progmodes/c-ts-mode.el > index 5093c3980b6..3740130be30 100644 > --- a/lisp/progmodes/c-ts-mode.el > +++ b/lisp/progmodes/c-ts-mode.el > @@ -470,7 +470,9 @@ c-ts-mode--font-lock-settings > :language mode > :feature 'function > '((call_expression > - function: (identifier) @font-lock-function-name-face)) > + function: > + [(identifier) @font-lock-function-name-face > + (field_expression field: (field_identifier) > @font-lock-function-name-face)])) >=20 > :language mode > :feature 'variable Haven't tested it, but the patch looks good to me, thanks.