From: Randy Taylor <dev@rjt.dev>
To: Ankit Gadiya <ankit@argp.in>
Cc: Eli Zaretskii <eliz@gnu.org>, 70939@debbugs.gnu.org
Subject: bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode
Date: Tue, 28 May 2024 02:30:18 +0000 [thread overview]
Message-ID: <H_3zn9CiC1a0wWgGAyVRb48Zllow_ftFw1kALviv-l8vByV56sg3iIDQ85u-Zj5VtJvzS3gUtx--WhMIRRWhrURciq_3ZT1bwgXRMipmUjQ=@rjt.dev> (raw)
In-Reply-To: <zxHBUkwwmI9VaBCKiAgd9TFsBXDOAw38CyreM3gzyqsF6dBMqrUNcVZapL9WfsFP3UyCNlqlFI0FStQ96UzQWRkndZq8QyidyuhC8xp5iDk=@rjt.dev>
On Friday, May 24th, 2024 at 22:35, Randy Taylor <dev@rjt.dev> wrote:
>
> On Saturday, May 18th, 2024 at 05:54, Ankit Gadiya via "Bug reports for GNU Emacs, the Swiss army knife of text editors" bug-gnu-emacs@gnu.org wrote:
>
> > [...]
> >
> > I'm submitting an updated Patch with the following changes:
> > * Add commit log
> > * Fix the text formatting.
> > * Update the keybindings to use the C-c C-t prefix.
> > * Improve regexp matching to be more strict.
> > * Define =go-ts-mode-build-tags= variable in the module and use it in the test
> > functions.
> >
> > --
> > Ankit
>
>
> Thanks.
>
> Sorry for the delay in reviewing, I've been having internet troubles since last Friday. I'll take a look at this next week.
>
> A few quick things I noticed on a glance:
>
> + (let* ((node (go-ts-mode--find-defun-at start))
> + (name (treesit-defun-name node))
>
> Indentation is off on the name line - looks like a TAB was used? Should only be spaces everywhere. Double check the rest is OK.
>
> +region. It is bound to 'C-c C-t' in 'go-ts-mode'.
> ^ C-c C-t t
>
> +package of the current buffer. It is bound to 'C-c C-p' in 'go-ts-mode'.
> ^ C-c C-t p
>
> + "List of go build tags for the test commands."
> ^ Go
>
> + "Return a list with names of all defuns in the range."
> We should probably say what the range actually is (START to END) - not sure if we have a convention for that wording already.
A few more nits:
+ "Return compile flag for build tags.
^ the
+This function respects `go-ts-mode-build-tags' variable for specifying
^ the
+ "Return a list with names of all defuns in the range."
^ the
Indentation is also off in go-ts-mode-test-function-at-point.
When we run C-c C-t t outside of a function, we get:
go test -v -run '^nil$'
Should we maybe not bother running anything at all? What do you think?
Do we know how other packages behave under similar circumstances?
next prev parent reply other threads:[~2024-05-28 2:30 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 14:04 bug#70939: [PATCH] Add commands to run unit tests in go-ts-mode Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-14 16:52 ` Eli Zaretskii
2024-05-14 17:24 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-14 17:59 ` Eli Zaretskii
2024-05-15 2:36 ` Randy Taylor
2024-05-15 4:55 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-16 2:32 ` Randy Taylor
2024-05-16 8:27 ` Eli Zaretskii
2024-05-16 15:03 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-16 16:01 ` Eli Zaretskii
2024-05-18 9:54 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-25 2:35 ` Randy Taylor
2024-05-28 2:30 ` Randy Taylor [this message]
2024-05-28 19:58 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-19 18:17 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-21 2:40 ` Randy Taylor
2024-06-23 14:46 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-26 2:26 ` Randy Taylor
2024-06-26 11:27 ` Eli Zaretskii
2024-06-26 12:31 ` Randy Taylor
2024-07-06 19:44 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-06 22:08 ` Stefan Kangas
2024-07-06 22:30 ` Dmitry Gutov
2024-07-07 7:26 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-10 23:43 ` Randy Taylor
2024-07-11 7:33 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-11 14:21 ` Randy Taylor
2024-07-12 6:23 ` Eli Zaretskii
2024-07-12 11:10 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-12 11:21 ` Eli Zaretskii
2024-07-21 6:05 ` Eli Zaretskii
2024-06-23 14:56 ` Eli Zaretskii
2024-05-17 2:27 ` Randy Taylor
2024-05-18 8:55 ` Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-15 11:21 ` Eli Zaretskii
2024-05-16 1:24 ` Randy Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='H_3zn9CiC1a0wWgGAyVRb48Zllow_ftFw1kALviv-l8vByV56sg3iIDQ85u-Zj5VtJvzS3gUtx--WhMIRRWhrURciq_3ZT1bwgXRMipmUjQ=@rjt.dev' \
--to=dev@rjt.dev \
--cc=70939@debbugs.gnu.org \
--cc=ankit@argp.in \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).