From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#63708: 29.0.60; rust-ts-mode not properly handling apostrophe Date: Mon, 29 May 2023 01:29:31 +0000 Message-ID: References: <83pm6pm0yz.fsf@gnu.org> <2MdRTHLlZtWDlCx6Ky-LFtla6-aBBs4PlNgTuatIC-h4OIuKdPmsmWsIokUQ9LBMHNvH_ooIvMUlQH8F8XOjNrEUUdC9FtR1l_e6RZSy7xU=@rjt.dev> <837cswmu5a.fsf@gnu.org> <8T8C4l5XryyVmB2cBTnmhGMnoELwHA2y1u1ZeMlg1WaQKzrPeOoe6L5hOQq3JPdsnG9r-puSlQfNZ091qBCGpVco-mC6ruhsQs0SvaPjkjQ=@proton.me> <_LWjNGLzmmtpm2gEwOaBZlTVCwvU9yxUyJzIl3yo3ol48dKWbMabBOpLzZ2UhWJ2_yPjVT-j2Jb-oUP8nLaju6ztGjFTNq-2PZqgTjv5gSM=@proton.me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35959"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 63708@debbugs.gnu.org, casouri@gmail.com To: =?UTF-8?Q?=D0=99=D0=BE=D1=80=D0=B4=D0=B0=D0=BD_?= =?UTF-8?Q?=D0=9C=D0=B8=D0=BB=D0=B0=D0=B4=D0=B8=D0=BD=D0=BE=D0=B2?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 29 03:30:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q3RiM-0009Db-KW for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 29 May 2023 03:30:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q3Ri8-0000cG-Df; Sun, 28 May 2023 21:30:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3Ri3-0000c3-BP for bug-gnu-emacs@gnu.org; Sun, 28 May 2023 21:30:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q3Rhy-000098-Jl for bug-gnu-emacs@gnu.org; Sun, 28 May 2023 21:30:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q3Rhy-0001IH-9b for bug-gnu-emacs@gnu.org; Sun, 28 May 2023 21:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 May 2023 01:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63708 X-GNU-PR-Package: emacs Original-Received: via spool by 63708-submit@debbugs.gnu.org id=B63708.16853237984936 (code B ref 63708); Mon, 29 May 2023 01:30:02 +0000 Original-Received: (at 63708) by debbugs.gnu.org; 29 May 2023 01:29:58 +0000 Original-Received: from localhost ([127.0.0.1]:56697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3Rht-0001HY-M2 for submit@debbugs.gnu.org; Sun, 28 May 2023 21:29:57 -0400 Original-Received: from mail-4323.proton.ch ([185.70.43.23]:34093) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3Rhq-0001HJ-AM for 63708@debbugs.gnu.org; Sun, 28 May 2023 21:29:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail3; t=1685323787; x=1685582987; bh=SLpIEbOEoGEsnK5Oxs081QGz/+GAto5JYFUD1N8fbj4=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=1ES/mmk5BDBvRjhErNbWDYB0C5MooT34rMAi7iSULg6yZ+SOp24193D/S6bnseQg0 S8VWC+bSGaoU8Lp3RH4JuoD5fAAo6U0qDvJCKwZHPDLUB3T+pytxXZilDLk5xjdJeZ 3qZ2eBwhvWM9Sw1DZ52YWfgZezteI9d4yarhqxP7qrGXnARUUYHOHPL+coNksz2dOb ExfVV5DoG/4zfeqbe2qorUN2uaZJFq4vQCyIc6M3vHHffX5Cewq6wesVdB23oBgkQh riKk6ZQDxnsP0xXhCK0xbnY7qInvCdJZePky4ZiAf1aAtnsL2IJK1ETH3165bmW3Or wwmwDMsHdrqRg== In-Reply-To: <_LWjNGLzmmtpm2gEwOaBZlTVCwvU9yxUyJzIl3yo3ol48dKWbMabBOpLzZ2UhWJ2_yPjVT-j2Jb-oUP8nLaju6ztGjFTNq-2PZqgTjv5gSM=@proton.me> Feedback-ID: 44397038:user:proton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262554 Archived-At: On Sunday, May 28th, 2023 at 15:51, =D0=99=D0=BE=D1=80=D0=B4=D0=B0=D0=BD = =D0=9C=D0=B8=D0=BB=D0=B0=D0=B4=D0=B8=D0=BD=D0=BE=D0=B2 = wrote: > Thanks for the comments! >=20 > Here's the updated review + the same trick applied for Go as well as I di= scovered the same bug in go-ts-mode. Thanks. For go-ts-mode I think we can just update the syntax table directly= like in your first patch to rust-ts-mode, since apostrophes don't have any= other meaning (to my knowledge). >=20 > > On Saturday, May 27th, 2023 at 6:00 AM, Randy Taylor dev@rjt.dev > wrot= e: > >=20 > > Do we want to use string-to-syntax here? >=20 >=20 > I believe we do as this is what both the old c-mode and the new c-ts-mode= define. What I meant was using the string-to-syntax function, like so: (string-to-s= yntax "\"") Makes it a little easier to read instead of a magic number. >=20 > If you're going to commit these fixes for both Rust and Go, would you lik= e me to go through all native treesiter modes, check for the same bug and e= ventually apply the same fix? I won't be committing them (don't have the ability) but Eli likely will. If you'd like to go through them all and check, that would be great. Howeve= r, for non-trivial contributions (i.e. more than 15 lines of code changes a= cross all your contributions I believe) you will need to assign copyright t= o the FSF, otherwise the changes can't be accepted. Eli can send you the fo= rm to fill out if you're interested.