* bug#1904: 23.0.60; [PATCH] sql-sqlite doesn't work
@ 2009-01-14 18:57 ` Ian Eure
2009-02-14 3:45 ` bug#1904: marked as done (23.0.60; [PATCH] sql-sqlite doesn't work) Emacs bug Tracking System
0 siblings, 1 reply; 5+ messages in thread
From: Ian Eure @ 2009-01-14 18:57 UTC (permalink / raw)
To: emacs-pretest-bug, alex, mmaug
The (sql-sqlite) function prompts for username, password, and server
even though these don’t apply to SQLite. Further, it adds options for
them (--host, --user, --password) to the arguments of sql-sqlite-
program. The SQLite CLI doesn’t understand or support these, and
returns this error if they’re provided:
sqlite3: unknown option: -user=ieure
(The sqlite 2.8.x binary behaves in the same way.)
For these reasons, I’ve taken the following measures:
1. Removed 'user, 'password and 'server from :sqli-login for sqlite
in sql-product-alist; this prevents them from being read from the user
when (sql-sqlite) is invoked.
2. Removed the addition of the --host, --user, and --password
arguments to 'params in (sql-connect-sqlite).
Patch against Emacs CVS HEAD (sql-mode 2.0.2) follows.
--- sql.el.~1.61.~ 2009-01-14 10:44:58.000000000 -0800
+++ sql.el 2009-01-14 10:50:09.000000000 -0800
@@ -356,7 +356,7 @@
:sqli-prompt-length 0)
(sqlite
:font-lock sql-mode-sqlite-font-lock-keywords
- :sqli-login (user password server database)
+ :sqli-login (database)
:sqli-connect sql-connect-sqlite
:sqli-prompt-regexp "^sqlite> "
:sqli-prompt-length 8)
@@ -2611,12 +2611,6 @@
(let ((params))
(if (not (string= "" sql-database))
(setq params (append (list sql-database) params)))
- (if (not (string= "" sql-server))
- (setq params (append (list (concat "--host=" sql-server)) params)))
- (if (not (string= "" sql-password))
- (setq params (append (list (concat "--password=" sql-password))
params)))
- (if (not (string= "" sql-user))
- (setq params (append (list (concat "--user=" sql-user)) params)))
(if (not (null sql-sqlite-options))
(setq params (append sql-sqlite-options params)))
(set-buffer (apply 'make-comint "SQL" sql-sqlite-program
In GNU Emacs 23.0.60.1 (i386-apple-darwin9.6.0, NS apple-appkit-949.43)
of 2009-01-14 on neutron.local
Windowing system distributor `Apple', version 10.3.949
configured using `configure '--with-ns''
Important settings:
value of $LC_ALL: nil
value of $LC_COLLATE: nil
value of $LC_CTYPE: nil
value of $LC_MESSAGES: nil
value of $LC_MONETARY: nil
value of $LC_NUMERIC: nil
value of $LC_TIME: nil
value of $LANG: nil
value of $XMODIFIERS: nil
locale-coding-system: nil
default-enable-multibyte-characters: t
Major mode: Diff
Minor modes in effect:
diff-auto-refine-mode: t
erc-track-mode: t
erc-track-minor-mode: t
erc-spelling-mode: t
erc-ring-mode: t
erc-pcomplete-mode: t
erc-netsplit-mode: t
erc-match-mode: t
erc-button-mode: t
erc-fill-mode: t
erc-autojoin-mode: t
erc-irccontrols-mode: t
erc-noncommands-mode: t
erc-readonly-mode: t
erc-scrolltobottom-mode: t
which-function-mode: t
twit-mode: t
yas/minor-mode: t
ime-bindings: t
shell-dirtrack-mode: t
show-paren-mode: t
recentf-mode: t
iswitchb-mode: t
auto-insert-mode: t
tooltip-mode: t
mouse-wheel-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
global-auto-composition-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
size-indication-mode: t
column-number-mode: t
line-number-mode: t
transient-mark-mode: t
abbrev-mode: t
Recent input:
C-v C-v C-v C-v C-v C-v C-v C-v C-v C-v C-v C-v C-v
C-v C-v C-x k RET C-x b s h e l <return> M-> c d SPC
~ / P r <tab> e m <tab> <return> c v s SPC u p SPC
- A <return> C-x 1 C-p C-p C-p C-p C-p C-p C-p C-p
C-SPC M-b M-b M-b M-b M-b M-b M-w M-> r m SPC C-y <return>
c v s SPC u p SPC C-y <return> s v n SPC <M-backspace>
x c s a SPC a r <backspace> <backspace> <backspace>
<backspace> <backspace> <backspace> <backspace> c v
s SPC u p <return> C-p C-x b s q l C-g C-x b s q l
. e l <return> C-x k RET C-x b s q l . e l <return>
C-x k RET M-> C-p C-p M-- M-z SPC M-> r m SPC C-y <return>
c v s SPC u p SPC C-y <return> C-p C-p C-p C-e C-c
C-x C-f RET C-x v = C-s s q l - c o n n e c t - s q
l i t e C-s C-n C-n C-n C-n C-n C-n C-n C-n C-n C-h
v p r o g <tab> m <tab> C-g C-n C-p C-p C-p C-a C-n
M-m C-SPC C-n C-n C-n C-n C-n C-n C-p C-e C-w C-d <tab>
C-h v w r <tab> <tab> i <tab> <M-backspace> e <backspace>
e <backspace> v f <tab> <backspace> <backspace> b e
f <tab> o <backspace> - <tab> w <tab> <backspace> s
a <tab> <return> M-: M-( s e q SPC <backspace> <backspace>
t q SPC b e f M-/ - M-/ SPC n i l C-e <return> C-x
C-s C-x v = M-> M-< C-x C-w C-g C-SPC M-> M-w <menu-bar>
<help-menu> <send-emacs-bug-report>
Recent messages:
Making completion list... [2 times]
Type C-x 1 to delete the help window, C-M-v to scroll help.
Scanning for dabbrevs...100% [2 times]
nil
Saving file /Users/ieure/Projects/emacs/lisp/progmodes/sql.el...
Wrote /Users/ieure/Projects/emacs/lisp/progmodes/sql.el
Finding changes in /Users/ieure/Projects/emacs/lisp/progmodes/
sql.el...done
Mark set [2 times]
Quit
Mark set
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#1904: 23.0.60; [PATCH] sql-sqlite doesn't work
@ 2009-01-15 14:06 Chong Yidong
0 siblings, 0 replies; 5+ messages in thread
From: Chong Yidong @ 2009-01-15 14:06 UTC (permalink / raw)
To: Michael Mauger; +Cc: 1904, Ian Eure
Hi Michael, could you evaluate this bug report and patch? Thanks.
Ian Eure <ian@digg.com> wrote:
> The (sql-sqlite) function prompts for username, password, and server
> even though these don’t apply to SQLite. Further, it adds options for
> them (--host, --user, --password) to the arguments of sql-sqlite-
> program. The SQLite CLI doesn’t understand or support these, and
> returns this error if they’re provided:
>
> sqlite3: unknown option: -user=ieure
>
> (The sqlite 2.8.x binary behaves in the same way.)
>
> For these reasons, I’ve taken the following measures:
>
> 1. Removed 'user, 'password and 'server from :sqli-login for sqlite
> in sql-product-alist; this prevents them from being read from the user
> when (sql-sqlite) is invoked.
> 2. Removed the addition of the --host, --user, and --password
> arguments to 'params in (sql-connect-sqlite).
>
> Patch against Emacs CVS HEAD (sql-mode 2.0.2) follows.
--- sql.el.~1.61.~ 2009-01-14 10:44:58.000000000 -0800
+++ sql.el 2009-01-14 10:50:09.000000000 -0800
@@ -356,7 +356,7 @@
:sqli-prompt-length 0)
(sqlite
:font-lock sql-mode-sqlite-font-lock-keywords
- :sqli-login (user password server database)
+ :sqli-login (database)
:sqli-connect sql-connect-sqlite
:sqli-prompt-regexp "^sqlite> "
:sqli-prompt-length 8)
@@ -2611,12 +2611,6 @@
(let ((params))
(if (not (string= "" sql-database))
(setq params (append (list sql-database) params)))
- (if (not (string= "" sql-server))
- (setq params (append (list (concat "--host=" sql-server)) params)))
- (if (not (string= "" sql-password))
- (setq params (append (list (concat "--password=" sql-password)) params)))
- (if (not (string= "" sql-user))
- (setq params (append (list (concat "--user=" sql-user)) params)))
(if (not (null sql-sqlite-options))
(setq params (append sql-sqlite-options params)))
(set-buffer (apply 'make-comint "SQL" sql-sqlite-program
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#2313: 23.0.90; sql-sqlite: --password, --user, --server won't work with sqlite
@ 2009-02-12 22:28 ` Xavier Maillard
2009-02-14 3:45 ` bug#2313: marked as done (23.0.90; sql-sqlite: --password, --user, --server won't work with sqlite) Emacs bug Tracking System
0 siblings, 1 reply; 5+ messages in thread
From: Xavier Maillard @ 2009-02-12 22:28 UTC (permalink / raw)
To: emacs-pretest-bug
when calling sql-sqlite, it asks for a user, a password, a host
to connect to a database. Problem is sqlite3 (dunno for other
sqlite versions) will refuse to do anything with these parameters
and just dies.
Here is the output of sqlite3 -help on my machine (slackware
GNU/linux):
Usage: sqlite3 [OPTIONS] FILENAME [SQL]
FILENAME is the name of an SQLite database. A new database is created
if the file does not previously exist.
OPTIONS include:
-init filename read/process named file
-echo print commands before execution
-[no]header turn headers on or off
-bail stop after hitting an error
-interactive force interactive I/O
-batch force batch I/O
-column set output mode to 'column'
-csv set output mode to 'csv'
-html set output mode to HTML
-line set output mode to 'line'
-list set output mode to 'list'
-separator 'x' set output field separator (|)
-nullvalue 'text' set text string for NULL values
-version show SQLite version
I guess this patch would be enough:
*** /tmp/sql.el.orig 2009-02-12 23:22:31.000000000 +0100
--- /tmp/sql.el 2009-02-12 23:23:30.000000000 +0100
***************
*** 356,362 ****
:sqli-prompt-length 0)
(sqlite
:font-lock sql-mode-sqlite-font-lock-keywords
! :sqli-login (user password server database)
:sqli-connect sql-connect-sqlite
:sqli-prompt-regexp "^sqlite> "
:sqli-prompt-length 8)
--- 356,362 ----
:sqli-prompt-length 0)
(sqlite
:font-lock sql-mode-sqlite-font-lock-keywords
! :sqli-login (database)
:sqli-connect sql-connect-sqlite
:sqli-prompt-regexp "^sqlite> "
:sqli-prompt-length 8)
***************
*** 2611,2622 ****
(let ((params))
(if (not (string= "" sql-database))
(setq params (append (list sql-database) params)))
- (if (not (string= "" sql-server))
- (setq params (append (list (concat "--host=" sql-server)) params)))
- (if (not (string= "" sql-password))
- (setq params (append (list (concat "--password=" sql-password)) params)))
- (if (not (string= "" sql-user))
- (setq params (append (list (concat "--user=" sql-user)) params)))
(if (not (null sql-sqlite-options))
(setq params (append sql-sqlite-options params)))
(set-buffer (apply 'make-comint "SQL" sql-sqlite-program
--- 2611,2616 ----
and the mandatory ChangeLog entry:
2009-02-12 Xavier Maillard <xma@gnu.org>
* sql.el (sql-connect-sqlite, sql-product-alist): user, password
and server are irrelevant for sqlite, remove them.
Hope that'll help
In GNU Emacs 23.0.90.1 (i686-pc-linux-gnu, GTK+ Version 2.12.12)
of 2009-02-10 on zogzog
Windowing system distributor `The X.Org Foundation', version 11.0.10402000
configured using `configure '--without-xft''
Important settings:
value of $LC_ALL: nil
value of $LC_COLLATE: en_US.UTF-8
value of $LC_CTYPE: fr_FR.UTF-8
value of $LC_MESSAGES: en_US.UTF-8
value of $LC_MONETARY: fr_FR.UTF-8
value of $LC_NUMERIC: en_US.UTF-8
value of $LC_TIME: en_US.UTF-8
value of $LANG: en_US.UTF-8
value of $XMODIFIERS: nil
locale-coding-system: utf-8-unix
default-enable-multibyte-characters: t
Major mode: Fundamental
Minor modes in effect:
t: t
rcirc-track-minor-mode: t
eev-mode: t
shell-dirtrack-mode: t
jabber-activity-mode: t
auto-insert-mode: t
global-hi-lock-mode: t
hi-lock-mode: t
show-paren-mode: t
global-auto-revert-mode: t
display-time-mode: t
recentf-mode: t
icomplete-mode: t
desktop-save-mode: t
auto-image-file-mode: t
tooltip-mode: t
mouse-wheel-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
global-auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
column-number-mode: t
transient-mark-mode: t
abbrev-mode: t
Recent input:
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <up> <return> <return> P . S . <left> <left>
<left> <left> P . C-e <backspace> : SPC f e e l SPC
f r e e SPC t o SPC d i s t r i b u t e SPC t h i s
SPC m e s s a g e SPC t o SPC t h e SPC * r i g h t
* SPC e e v SPC l i s t SPC i f SPC a p p l i c a b
l e . <down> <down> <down> <down> <up> <up> <up> <up>
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up>
<up> <up> <up> <up> <up> <up> <down> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<up> <return> R e g a r d s , <return> <up> <up> <up>
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up>
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up>
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up>
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up>
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <down>
<down> C-SPC <right> C-w <backspace> SPC <backspace>
<backspace> SPC <left> <left> <left> <left> C-e " <backspace>
C-a <right> <right> <right> <right> <right> <backspace>
C-c C-c M-x m y - s e n d <tab> <return> M-x e m a
c s - b u <backspace> <backspace> r e <backspace> <backspace>
<backspace> <backspace> <backspace> <backspace> <backspace>
<backspace> b u g <backspace> <backspace> <backspace>
r e p o <tab> r <tab> <return>
Recent messages:
Wrote /home/xma/var/queue/out-1
Sending...done
Sending out-1...
Sending...
Added to /home/xma/mail/OUT-SENT
Sending...done
Sending out-1...done
All sent or no message to send.
Making completion list...
Killing buffer *Completions*
Xavier
--
http://www.gnu.org
http://www.april.org
http://www.lolica.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#1904: marked as done (23.0.60; [PATCH] sql-sqlite doesn't work)
2009-01-14 18:57 ` bug#1904: 23.0.60; [PATCH] sql-sqlite doesn't work Ian Eure
@ 2009-02-14 3:45 ` Emacs bug Tracking System
0 siblings, 0 replies; 5+ messages in thread
From: Emacs bug Tracking System @ 2009-02-14 3:45 UTC (permalink / raw)
To: Glenn Morris
[-- Attachment #1: Type: text/plain, Size: 872 bytes --]
Your message dated Fri, 13 Feb 2009 22:38:20 -0500
with message-id <jm7i3tk7rn.fsf@fencepost.gnu.org>
and subject line Re: 23.0.60; [PATCH] sql-sqlite doesn't work
has caused the Emacs bug report #1904,
regarding 23.0.60; [PATCH] sql-sqlite doesn't work
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)
--
1904: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1904
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems
[-- Attachment #2: Type: message/rfc822, Size: 7149 bytes --]
From: Ian Eure <ian@digg.com>
To: emacs-pretest-bug@gnu.org, alex@gnu.org, mmaug@yahoo.com
Subject: 23.0.60; [PATCH] sql-sqlite doesn't work
Date: Wed, 14 Jan 2009 10:57:49 -0800
Message-ID: <FF72C955-7A33-457D-948A-5E71EC6B52B0@digg.com>
The (sql-sqlite) function prompts for username, password, and server
even though these don’t apply to SQLite. Further, it adds options for
them (--host, --user, --password) to the arguments of sql-sqlite-
program. The SQLite CLI doesn’t understand or support these, and
returns this error if they’re provided:
sqlite3: unknown option: -user=ieure
(The sqlite 2.8.x binary behaves in the same way.)
For these reasons, I’ve taken the following measures:
1. Removed 'user, 'password and 'server from :sqli-login for sqlite
in sql-product-alist; this prevents them from being read from the user
when (sql-sqlite) is invoked.
2. Removed the addition of the --host, --user, and --password
arguments to 'params in (sql-connect-sqlite).
Patch against Emacs CVS HEAD (sql-mode 2.0.2) follows.
--- sql.el.~1.61.~ 2009-01-14 10:44:58.000000000 -0800
+++ sql.el 2009-01-14 10:50:09.000000000 -0800
@@ -356,7 +356,7 @@
:sqli-prompt-length 0)
(sqlite
:font-lock sql-mode-sqlite-font-lock-keywords
- :sqli-login (user password server database)
+ :sqli-login (database)
:sqli-connect sql-connect-sqlite
:sqli-prompt-regexp "^sqlite> "
:sqli-prompt-length 8)
@@ -2611,12 +2611,6 @@
(let ((params))
(if (not (string= "" sql-database))
(setq params (append (list sql-database) params)))
- (if (not (string= "" sql-server))
- (setq params (append (list (concat "--host=" sql-server)) params)))
- (if (not (string= "" sql-password))
- (setq params (append (list (concat "--password=" sql-password))
params)))
- (if (not (string= "" sql-user))
- (setq params (append (list (concat "--user=" sql-user)) params)))
(if (not (null sql-sqlite-options))
(setq params (append sql-sqlite-options params)))
(set-buffer (apply 'make-comint "SQL" sql-sqlite-program
In GNU Emacs 23.0.60.1 (i386-apple-darwin9.6.0, NS apple-appkit-949.43)
of 2009-01-14 on neutron.local
Windowing system distributor `Apple', version 10.3.949
configured using `configure '--with-ns''
Important settings:
value of $LC_ALL: nil
value of $LC_COLLATE: nil
value of $LC_CTYPE: nil
value of $LC_MESSAGES: nil
value of $LC_MONETARY: nil
value of $LC_NUMERIC: nil
value of $LC_TIME: nil
value of $LANG: nil
value of $XMODIFIERS: nil
locale-coding-system: nil
default-enable-multibyte-characters: t
Major mode: Diff
Minor modes in effect:
diff-auto-refine-mode: t
erc-track-mode: t
erc-track-minor-mode: t
erc-spelling-mode: t
erc-ring-mode: t
erc-pcomplete-mode: t
erc-netsplit-mode: t
erc-match-mode: t
erc-button-mode: t
erc-fill-mode: t
erc-autojoin-mode: t
erc-irccontrols-mode: t
erc-noncommands-mode: t
erc-readonly-mode: t
erc-scrolltobottom-mode: t
which-function-mode: t
twit-mode: t
yas/minor-mode: t
ime-bindings: t
shell-dirtrack-mode: t
show-paren-mode: t
recentf-mode: t
iswitchb-mode: t
auto-insert-mode: t
tooltip-mode: t
mouse-wheel-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
global-auto-composition-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
size-indication-mode: t
column-number-mode: t
line-number-mode: t
transient-mark-mode: t
abbrev-mode: t
Recent input:
C-v C-v C-v C-v C-v C-v C-v C-v C-v C-v C-v C-v C-v
C-v C-v C-x k RET C-x b s h e l <return> M-> c d SPC
~ / P r <tab> e m <tab> <return> c v s SPC u p SPC
- A <return> C-x 1 C-p C-p C-p C-p C-p C-p C-p C-p
C-SPC M-b M-b M-b M-b M-b M-b M-w M-> r m SPC C-y <return>
c v s SPC u p SPC C-y <return> s v n SPC <M-backspace>
x c s a SPC a r <backspace> <backspace> <backspace>
<backspace> <backspace> <backspace> <backspace> c v
s SPC u p <return> C-p C-x b s q l C-g C-x b s q l
. e l <return> C-x k RET C-x b s q l . e l <return>
C-x k RET M-> C-p C-p M-- M-z SPC M-> r m SPC C-y <return>
c v s SPC u p SPC C-y <return> C-p C-p C-p C-e C-c
C-x C-f RET C-x v = C-s s q l - c o n n e c t - s q
l i t e C-s C-n C-n C-n C-n C-n C-n C-n C-n C-n C-h
v p r o g <tab> m <tab> C-g C-n C-p C-p C-p C-a C-n
M-m C-SPC C-n C-n C-n C-n C-n C-n C-p C-e C-w C-d <tab>
C-h v w r <tab> <tab> i <tab> <M-backspace> e <backspace>
e <backspace> v f <tab> <backspace> <backspace> b e
f <tab> o <backspace> - <tab> w <tab> <backspace> s
a <tab> <return> M-: M-( s e q SPC <backspace> <backspace>
t q SPC b e f M-/ - M-/ SPC n i l C-e <return> C-x
C-s C-x v = M-> M-< C-x C-w C-g C-SPC M-> M-w <menu-bar>
<help-menu> <send-emacs-bug-report>
Recent messages:
Making completion list... [2 times]
Type C-x 1 to delete the help window, C-M-v to scroll help.
Scanning for dabbrevs...100% [2 times]
nil
Saving file /Users/ieure/Projects/emacs/lisp/progmodes/sql.el...
Wrote /Users/ieure/Projects/emacs/lisp/progmodes/sql.el
Finding changes in /Users/ieure/Projects/emacs/lisp/progmodes/
sql.el...done
Mark set [2 times]
Quit
Mark set
[-- Attachment #3: Type: message/rfc822, Size: 1506 bytes --]
From: Glenn Morris <rgm@gnu.org>
To: 1904-done@emacsbugs.donarmstrong.com
Subject: Re: 23.0.60; [PATCH] sql-sqlite doesn't work
Date: Fri, 13 Feb 2009 22:38:20 -0500
Message-ID: <jm7i3tk7rn.fsf@fencepost.gnu.org>
Installed, given that it looks fine and two people have come up with
the same solution. (Bugs 1904, 2313).
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#2313: marked as done (23.0.90; sql-sqlite: --password, --user, --server won't work with sqlite)
2009-02-12 22:28 ` bug#2313: 23.0.90; sql-sqlite: --password, --user, --server won't work with sqlite Xavier Maillard
@ 2009-02-14 3:45 ` Emacs bug Tracking System
0 siblings, 0 replies; 5+ messages in thread
From: Emacs bug Tracking System @ 2009-02-14 3:45 UTC (permalink / raw)
To: Glenn Morris
[-- Attachment #1: Type: text/plain, Size: 904 bytes --]
Your message dated Fri, 13 Feb 2009 22:38:20 -0500
with message-id <jm7i3tk7rn.fsf@fencepost.gnu.org>
and subject line Re: 23.0.60; [PATCH] sql-sqlite doesn't work
has caused the Emacs bug report #1904,
regarding 23.0.90; sql-sqlite: --password, --user, --server won't work with sqlite
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)
--
1904: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1904
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems
[-- Attachment #2: Type: message/rfc822, Size: 8409 bytes --]
From: Xavier Maillard <xma@gnu.org>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.90; sql-sqlite: --password, --user, --server won't work with sqlite
Date: Thu, 12 Feb 2009 23:28:08 +0100
Message-ID: <200902122228.n1CMS8vN003708@zogzog.maillard.mobi>
when calling sql-sqlite, it asks for a user, a password, a host
to connect to a database. Problem is sqlite3 (dunno for other
sqlite versions) will refuse to do anything with these parameters
and just dies.
Here is the output of sqlite3 -help on my machine (slackware
GNU/linux):
Usage: sqlite3 [OPTIONS] FILENAME [SQL]
FILENAME is the name of an SQLite database. A new database is created
if the file does not previously exist.
OPTIONS include:
-init filename read/process named file
-echo print commands before execution
-[no]header turn headers on or off
-bail stop after hitting an error
-interactive force interactive I/O
-batch force batch I/O
-column set output mode to 'column'
-csv set output mode to 'csv'
-html set output mode to HTML
-line set output mode to 'line'
-list set output mode to 'list'
-separator 'x' set output field separator (|)
-nullvalue 'text' set text string for NULL values
-version show SQLite version
I guess this patch would be enough:
*** /tmp/sql.el.orig 2009-02-12 23:22:31.000000000 +0100
--- /tmp/sql.el 2009-02-12 23:23:30.000000000 +0100
***************
*** 356,362 ****
:sqli-prompt-length 0)
(sqlite
:font-lock sql-mode-sqlite-font-lock-keywords
! :sqli-login (user password server database)
:sqli-connect sql-connect-sqlite
:sqli-prompt-regexp "^sqlite> "
:sqli-prompt-length 8)
--- 356,362 ----
:sqli-prompt-length 0)
(sqlite
:font-lock sql-mode-sqlite-font-lock-keywords
! :sqli-login (database)
:sqli-connect sql-connect-sqlite
:sqli-prompt-regexp "^sqlite> "
:sqli-prompt-length 8)
***************
*** 2611,2622 ****
(let ((params))
(if (not (string= "" sql-database))
(setq params (append (list sql-database) params)))
- (if (not (string= "" sql-server))
- (setq params (append (list (concat "--host=" sql-server)) params)))
- (if (not (string= "" sql-password))
- (setq params (append (list (concat "--password=" sql-password)) params)))
- (if (not (string= "" sql-user))
- (setq params (append (list (concat "--user=" sql-user)) params)))
(if (not (null sql-sqlite-options))
(setq params (append sql-sqlite-options params)))
(set-buffer (apply 'make-comint "SQL" sql-sqlite-program
--- 2611,2616 ----
and the mandatory ChangeLog entry:
2009-02-12 Xavier Maillard <xma@gnu.org>
* sql.el (sql-connect-sqlite, sql-product-alist): user, password
and server are irrelevant for sqlite, remove them.
Hope that'll help
In GNU Emacs 23.0.90.1 (i686-pc-linux-gnu, GTK+ Version 2.12.12)
of 2009-02-10 on zogzog
Windowing system distributor `The X.Org Foundation', version 11.0.10402000
configured using `configure '--without-xft''
Important settings:
value of $LC_ALL: nil
value of $LC_COLLATE: en_US.UTF-8
value of $LC_CTYPE: fr_FR.UTF-8
value of $LC_MESSAGES: en_US.UTF-8
value of $LC_MONETARY: fr_FR.UTF-8
value of $LC_NUMERIC: en_US.UTF-8
value of $LC_TIME: en_US.UTF-8
value of $LANG: en_US.UTF-8
value of $XMODIFIERS: nil
locale-coding-system: utf-8-unix
default-enable-multibyte-characters: t
Major mode: Fundamental
Minor modes in effect:
t: t
rcirc-track-minor-mode: t
eev-mode: t
shell-dirtrack-mode: t
jabber-activity-mode: t
auto-insert-mode: t
global-hi-lock-mode: t
hi-lock-mode: t
show-paren-mode: t
global-auto-revert-mode: t
display-time-mode: t
recentf-mode: t
icomplete-mode: t
desktop-save-mode: t
auto-image-file-mode: t
tooltip-mode: t
mouse-wheel-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
global-auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
column-number-mode: t
transient-mark-mode: t
abbrev-mode: t
Recent input:
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <up> <return> <return> P . S . <left> <left>
<left> <left> P . C-e <backspace> : SPC f e e l SPC
f r e e SPC t o SPC d i s t r i b u t e SPC t h i s
SPC m e s s a g e SPC t o SPC t h e SPC * r i g h t
* SPC e e v SPC l i s t SPC i f SPC a p p l i c a b
l e . <down> <down> <down> <down> <up> <up> <up> <up>
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up>
<up> <up> <up> <up> <up> <up> <down> <down> <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<up> <return> R e g a r d s , <return> <up> <up> <up>
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up>
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up>
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up>
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up>
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <down>
<down> C-SPC <right> C-w <backspace> SPC <backspace>
<backspace> SPC <left> <left> <left> <left> C-e " <backspace>
C-a <right> <right> <right> <right> <right> <backspace>
C-c C-c M-x m y - s e n d <tab> <return> M-x e m a
c s - b u <backspace> <backspace> r e <backspace> <backspace>
<backspace> <backspace> <backspace> <backspace> <backspace>
<backspace> b u g <backspace> <backspace> <backspace>
r e p o <tab> r <tab> <return>
Recent messages:
Wrote /home/xma/var/queue/out-1
Sending...done
Sending out-1...
Sending...
Added to /home/xma/mail/OUT-SENT
Sending...done
Sending out-1...done
All sent or no message to send.
Making completion list...
Killing buffer *Completions*
Xavier
--
http://www.gnu.org
http://www.april.org
http://www.lolica.org
[-- Attachment #3: Type: message/rfc822, Size: 1506 bytes --]
From: Glenn Morris <rgm@gnu.org>
To: 1904-done@emacsbugs.donarmstrong.com
Subject: Re: 23.0.60; [PATCH] sql-sqlite doesn't work
Date: Fri, 13 Feb 2009 22:38:20 -0500
Message-ID: <jm7i3tk7rn.fsf@fencepost.gnu.org>
Installed, given that it looks fine and two people have come up with
the same solution. (Bugs 1904, 2313).
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-02-14 3:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <jm7i3tk7rn.fsf@fencepost.gnu.org>
2009-01-14 18:57 ` bug#1904: 23.0.60; [PATCH] sql-sqlite doesn't work Ian Eure
2009-02-14 3:45 ` bug#1904: marked as done (23.0.60; [PATCH] sql-sqlite doesn't work) Emacs bug Tracking System
2009-02-12 22:28 ` bug#2313: 23.0.90; sql-sqlite: --password, --user, --server won't work with sqlite Xavier Maillard
2009-02-14 3:45 ` bug#2313: marked as done (23.0.90; sql-sqlite: --password, --user, --server won't work with sqlite) Emacs bug Tracking System
2009-01-15 14:06 bug#1904: 23.0.60; [PATCH] sql-sqlite doesn't work Chong Yidong
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).