From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#43677: 27.1; Calc holidays off-by-one error, incorrect business day calculation Date: Wed, 30 Sep 2020 18:12:43 +0200 Message-ID: References: <0FA74B6A-DD93-41D7-91C4-ED4EB881E2DD@acm.org> <87blhn757u.fsf@gnus.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3627"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Aaron Zeng , 43677@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 30 18:13:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNej9-0000ny-OJ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Sep 2020 18:13:11 +0200 Original-Received: from localhost ([::1]:48092 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNej8-0004t2-Mx for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Sep 2020 12:13:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57278) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNej0-0004rY-I4 for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 12:13:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49511) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kNej0-0003aa-8T for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 12:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kNej0-0004bN-4d for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 12:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Sep 2020 16:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43677 X-GNU-PR-Package: emacs Original-Received: via spool by 43677-submit@debbugs.gnu.org id=B43677.160148237017668 (code B ref 43677); Wed, 30 Sep 2020 16:13:02 +0000 Original-Received: (at 43677) by debbugs.gnu.org; 30 Sep 2020 16:12:50 +0000 Original-Received: from localhost ([127.0.0.1]:32822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNeio-0004au-CZ for submit@debbugs.gnu.org; Wed, 30 Sep 2020 12:12:50 -0400 Original-Received: from mail238c50.megamailservers.eu ([91.136.10.248]:41958 helo=mail56c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNeim-0004ak-8Y for 43677@debbugs.gnu.org; Wed, 30 Sep 2020 12:12:49 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1601482365; bh=cIMbz9v9+0MDUiIqTs7XoOMhMwsc+Y29hNhlqETtR7o=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=mMygUrNNaORsJTOZ2a8eh2wUbrD9nbycz4PNVP0uChGMDv5XA9XFHqpbIo3hDffUO QilcpSRR/m1fdIMkcU+nUt3/lLqmnuiz4uwmA0bJYNH/SE989OubGvoeOgQyu9zrVa 7gn8tNRzmV+57sQNSKk16d4bZT/cvbHtJ97umm0I= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-304ee655.032-75-73746f71.bbcust.telenor.se [85.230.78.48]) (authenticated bits=0) by mail56c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 08UGChFu012999; Wed, 30 Sep 2020 16:12:45 +0000 In-Reply-To: <87blhn757u.fsf@gnus.org> X-Mailer: Apple Mail (2.3445.104.17) X-CTCH-RefID: str=0001.0A782F18.5F74AE7D.007F, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=UqsdyN4B c=1 sm=1 tr=0 a=63Z2wlQ1NB3xHpgKFKE71g==:117 a=63Z2wlQ1NB3xHpgKFKE71g==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=OocQHUDgAAAA:8 a=6vsFli9YysuZqjTay7IA:9 a=CjuIK1q_8ugA:10 a=xUZTl98r3Qw_uB5NK3jt:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189382 Archived-At: 30 sep. 2020 kl. 15.40 skrev Lars Ingebrigtsen : > That's quite a stretch to be bisecting, though... Bisecting is logarithmic so large stretches are seldom a problem. You = can also bisect restricted to one path which reduces the number of = versions dramatically. (Building old versions of Emacs, on the other = hand -- that can be messy!) But you don't have to! I found it. The error was introduced in the = calendar changes between c9f618db441 and fd1f1603a4f, during which the = internal date numbering changed: date Jan 1, 1 AD went from date 0 to 1. = However, the business days code remained unchanged and thus started = getting the weekdays wrong. Of course there were no tests but that is excusable since this was 2012 = and tests weren't invented back then. I'll put together a patch a little later today or tomorrow.