From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#62043: [PATCH] Fix enums appearing as structs in c-ts-base-mode's imenu Date: Wed, 8 Mar 2023 15:27:18 -0800 Message-ID: References: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22270"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62043@debbugs.gnu.org To: Randy Taylor Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 09 00:28:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pa3Ct-0005ds-Bk for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Mar 2023 00:28:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pa3CV-0005aZ-OK; Wed, 08 Mar 2023 18:28:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pa3CU-0005a8-Gw for bug-gnu-emacs@gnu.org; Wed, 08 Mar 2023 18:28:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pa3CU-0001u8-89 for bug-gnu-emacs@gnu.org; Wed, 08 Mar 2023 18:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pa3CU-0008W7-4W for bug-gnu-emacs@gnu.org; Wed, 08 Mar 2023 18:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Mar 2023 23:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62043 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 62043-submit@debbugs.gnu.org id=B62043.167831806332710 (code B ref 62043); Wed, 08 Mar 2023 23:28:02 +0000 Original-Received: (at 62043) by debbugs.gnu.org; 8 Mar 2023 23:27:43 +0000 Original-Received: from localhost ([127.0.0.1]:50404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pa3CB-0008VU-HV for submit@debbugs.gnu.org; Wed, 08 Mar 2023 18:27:43 -0500 Original-Received: from mail-pj1-f52.google.com ([209.85.216.52]:36791) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pa3C9-0008VF-Gb for 62043@debbugs.gnu.org; Wed, 08 Mar 2023 18:27:41 -0500 Original-Received: by mail-pj1-f52.google.com with SMTP id cp7-20020a17090afb8700b0023756229427so4193126pjb.1 for <62043@debbugs.gnu.org>; Wed, 08 Mar 2023 15:27:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678318056; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YVxBB9y38CpTS2e1AFvCBzjMbqfjmjjKZiCXmdFvKZ4=; b=JosZv5EJVcnMwHMxC6Tc5CeAvDXF2TEkDnnVeetPMthwj3whZqXtu8EBWOWzTqyb5n jKdIqHIaVquVKtxSQpNWbl7wCNH/oWDVlWRNctFpciC/JLPuJgpqhyp65wqmEV4Slx1M yf6LyGiVK21cLN84lUnV2Dsf0Fhwd3Gm414mDNKbQjlO5fGGDTr3HVsVumCW+39CLT2G rlU/SaspUotE+4oZGX9i+X7V24PZspSU3BAUnxjTAYGx12zXdxEr3PXpx16/bplITczP QYtmWYmhzqfYPtyHKf9UKunOfSMMR0UvUwKZH+/H6uDQvH1cMAf+X99fiyakf1m9l/Sg qKzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678318056; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YVxBB9y38CpTS2e1AFvCBzjMbqfjmjjKZiCXmdFvKZ4=; b=N1n6eAIgBeIv9Yv8QVj6mACb1FTS4AWmzmd4ATglLH+9xQjynCbdL71aLwjxq3eFls Fn8iRNXiwixw+Vw+lje4bSS+JQFXBJigmUwqF2ilu0Zo3kSnSFBFU4oMOAjZ0QDVUBnE yvZo/MrHI8kkZ1CH3nC8MiXyRjLNrOMsyk7MNcUVmSXwaEEtN5kdtITy8uJCL5COcbgL Fx1njSpuXe+kw+dTpXDRABSEmbtDdB2SArFqxixkFe7+ZRkqENJzsy2DL5u1pp50QnPx w7sayq3YYxoWem++Jxhz33iTTLgoafjLYXbvtjcKKKw6sL4Jp1rmPGHPEtLrJkV/tomV FnWg== X-Gm-Message-State: AO0yUKWLcTnIbHxho819/uawuiusMngfHgSDGV9E2WITgGstVXejOkMt HuysmAE7rKq0QlB+2y36ctpLaYZRbsplQA== X-Google-Smtp-Source: AK7set96hcJhIhBuOrOlltiFpVRwjXkFvjyMQmqJ92xrCUD0mbMSewaMI3m6OfEG2xZm51LFCWnEeg== X-Received: by 2002:a17:903:1251:b0:19e:d60a:e9e with SMTP id u17-20020a170903125100b0019ed60a0e9emr10282218plh.42.1678318055616; Wed, 08 Mar 2023 15:27:35 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id u3-20020a170902e80300b0019a6e8ceb49sm10291546plg.259.2023.03.08.15.27.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Mar 2023 15:27:34 -0800 (PST) In-Reply-To: X-Mailer: Apple Mail (2.3731.400.51.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257570 Archived-At: > On Mar 7, 2023, at 5:49 PM, Randy Taylor wrote: >=20 > X-Debbugs-CC: casouri@gmail.com >=20 > With {c, c++}-ts-mode, enums appear as structs in imenu. The attached = patch fixes this. >=20 > Example: > enum Thing { A, B, C }; >=20 > Should appear as Enum Thing > <0001-Fix-enums-appearing-as-structs-in-c-ts-base-mode-s-i.patch> Thanks! I wonder what determines which categories to merge together and = which to not? If we separate Enums, should we also separate Unions? Yuan=