From: Kelly Dean <kelly@prtime.org>
To: 19513@debbugs.gnu.org
Subject: bug#19513: shift-select-mode fails to be fully buffer-local
Date: Sun, 25 Jan 2015 08:50:35 +0000 [thread overview]
Message-ID: <FDvmyzR5S5FNEmUr7rdNV3hatFn9SCBcpDZ033kep6I@local> (raw)
In-Reply-To: <U8z6hQIc2IE0cbBYLA7BLfg1BDVOfcYWbvmtNGX6CfD@local>
The bug was caused because handle-shift-selection sets transient-mark-mode globally to a cons with 'only as the car, then when the motion command occurs in the other buffer, handle-shift-selection sets transient-mark-mode globally to remove that cons, so back in the first buffer, when handle-shift-selection is called again, the cons is gone, so there's no trigger to deactivate the mark.
Setting transient-mark-mode buffer-locally instead of globally fixes the bug.
I was about to send a patch, but when I checked to make sure it applied to trunk, I discovered Stefan already fixed this bug in commit 5d2638bd in June 2014--more than three months before 24.4 was released.
next prev parent reply other threads:[~2015-01-25 8:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 1:06 bug#19513: shift-select-mode fails to be fully buffer-local Kelly Dean
2015-01-05 2:09 ` Stefan Monnier
2015-01-06 6:59 ` Kelly Dean
2015-01-06 15:24 ` Stefan Monnier
2015-01-06 19:20 ` Kelly Dean
2015-01-06 21:06 ` Stefan Monnier
2015-01-25 8:50 ` Kelly Dean [this message]
2015-01-25 15:16 ` Stefan Monnier
2015-01-26 4:16 ` Kelly Dean
2015-01-26 6:15 ` Eli Zaretskii
2015-01-25 15:40 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FDvmyzR5S5FNEmUr7rdNV3hatFn9SCBcpDZ033kep6I@local \
--to=kelly@prtime.org \
--cc=19513@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).