From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#7754: 24.0.50; easy-menu: fix misnamed keywords Date: Wed, 29 Dec 2010 07:26:08 -0800 Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1293638021 29442 80.91.229.12 (29 Dec 2010 15:53:41 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 29 Dec 2010 15:53:41 +0000 (UTC) To: 7754@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 29 16:53:37 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PXyLJ-0004Lv-Gn for geb-bug-gnu-emacs@m.gmane.org; Wed, 29 Dec 2010 16:53:37 +0100 Original-Received: from localhost ([127.0.0.1]:57178 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PXyLI-0004vy-VU for geb-bug-gnu-emacs@m.gmane.org; Wed, 29 Dec 2010 10:53:37 -0500 Original-Received: from [140.186.70.92] (port=53660 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PXyL9-0004tq-OX for bug-gnu-emacs@gnu.org; Wed, 29 Dec 2010 10:53:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PXyL8-0003xp-Jz for bug-gnu-emacs@gnu.org; Wed, 29 Dec 2010 10:53:27 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59439) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PXyL8-0003xk-H9 for bug-gnu-emacs@gnu.org; Wed, 29 Dec 2010 10:53:26 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PXxpm-0004Qg-VW; Wed, 29 Dec 2010 10:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Dec 2010 15:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 7754 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: Original-Received: via spool by submit@debbugs.gnu.org id=B.129363602516982 (code B ref -1); Wed, 29 Dec 2010 15:21:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 29 Dec 2010 15:20:25 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PXxpB-0004Pr-5Q for submit@debbugs.gnu.org; Wed, 29 Dec 2010 10:20:25 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PXxp9-0004Pg-L8 for submit@debbugs.gnu.org; Wed, 29 Dec 2010 10:20:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PXxvo-0006lJ-55 for submit@debbugs.gnu.org; Wed, 29 Dec 2010 10:27:16 -0500 Original-Received: from lists.gnu.org ([199.232.76.165]:47544) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PXxvo-0006lF-2s for submit@debbugs.gnu.org; Wed, 29 Dec 2010 10:27:16 -0500 Original-Received: from [140.186.70.92] (port=42871 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PXxvn-0005lE-1Z for bug-gnu-emacs@gnu.org; Wed, 29 Dec 2010 10:27:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PXxvk-0006ka-Ar for bug-gnu-emacs@gnu.org; Wed, 29 Dec 2010 10:27:14 -0500 Original-Received: from rcsinet10.oracle.com ([148.87.113.121]:61184) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PXxvk-0006kS-4K for bug-gnu-emacs@gnu.org; Wed, 29 Dec 2010 10:27:12 -0500 Original-Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id oBTFR72I021984 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 29 Dec 2010 15:27:09 GMT Original-Received: from acsmt354.oracle.com (acsmt354.oracle.com [141.146.40.154]) by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id oBTFMllN024029 for ; Wed, 29 Dec 2010 15:27:07 GMT Original-Received: from abhmt020.oracle.com by acsmt354.oracle.com with ESMTP id 913885981293636366; Wed, 29 Dec 2010 07:26:06 -0800 Original-Received: from dradamslap1 (/10.159.216.195) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 29 Dec 2010 07:26:05 -0800 X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcunbLcFINI/HDEiSVKbV+hI6XgEWQ== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 29 Dec 2010 10:21:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:42915 Archived-At: Easy-menu uses a non-standard :active keyword to mean what :enable means in regular menus. Similarly, it used to use :included to mean what :visible means. The latter inconsistency was fixed long ago, by aliasing. The former has never been fixed. I see no conflict in the code - no reason not to just use :enable (e.g. alias :active to :enable and ultimately deprecate :active). >From the `easy-menu-define' doc string (in two places, one for a "menu", the other for an "item": :visible INCLUDE INCLUDE is an expression; this (menu|item) is only visible if this expression has a non-nil value. `:included' is an alias for `:visible'. :active ENABLE ENABLE is an expression; the (menu|item) is enabled for selection whenever this expression's value is non-nil. I see no reason to treat the misnamed :active any different from the misnamed :included. Note: I sent this request to emacs-devel on 2009-05-22, but got no response. Here is that mail: > From: Drew Adams Sent: Friday, May 22, 2009 3:07 PM > > Why does easymenu.el use :active instead of :enable? This > inconsistency just makes things more complex for users, without > any gain (that I can see). > > The code even translates :active to :enable! Why not just > accept :enable? And then perhaps we could sooner or later > deprecate :active. > > Shouldn't we just choose one or the other, :enable or > :active, and stick to it consistently? In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2010-12-20 on 3249CTO Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.4) --no-opt --cflags -Ic:/imagesupport/include'