From: JD Smith <jdtsmith@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: 70576@debbugs.gnu.org
Subject: bug#70576: [PATCH] `repeat-echo-message-string': support repeat keymap "hints"
Date: Fri, 26 Apr 2024 10:37:51 -0400 [thread overview]
Message-ID: <FDB853F1-60B6-4ACF-8E08-337567CB3CBC@gmail.com> (raw)
In-Reply-To: <86h6fo3e7e.fsf@mail.linkov.net>
> On Apr 26, 2024, at 2:06 AM, Juri Linkov <juri@linkov.net> wrote:
>
> I feel uneasy about reusing the form (STRING . DEFN)
> that has another meaning:
>
> a cons (STRING . DEFN), meaning that DEFN is the definition
> (DEFN should be a valid definition in its own right) and
> STRING is the menu item name (which is used only if the containing
> keymap has been created with a menu name, see make-keymap),
>
> Can the same instead be achieved by using symbol properties?
> For example:
> (defvar-keymap expreg-repeat-map
> :doc "Repeat map for `expreg' actions."
> :repeat t
> "\\" 'expreg-expand
> "|" 'expreg-contract)
>
> (put 'expreg-expand 'repeat-hint "expand")
> (put 'expreg-contract 'repeat-hint "contract")
Thanks for taking a look. A property on the command could work (and then you need no :name). It would be somewhat harder to maintain the structure for long keymaps, e.g. if a command changes. I do note that menu-item with :filter is commonly recommended for non-menu dynamic bindings, so there is some precedent of reusing menu functionality in other contexts. Of course a new wrapper macro could also be developed to ease this. Do you anticipate any specific issues?
next prev parent reply other threads:[~2024-04-26 14:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 22:31 bug#70576: [PATCH] `repeat-echo-message-string': support repeat keymap "hints" JD Smith
2024-04-26 6:06 ` Juri Linkov
2024-04-26 14:37 ` JD Smith [this message]
2024-04-28 6:58 ` Juri Linkov
2024-04-28 12:45 ` JD Smith
2024-04-28 16:38 ` Juri Linkov
2024-05-02 6:48 ` Juri Linkov
2024-05-02 7:16 ` Eli Zaretskii
2024-05-02 11:47 ` JD Smith
2024-05-02 16:16 ` Juri Linkov
2024-05-02 18:14 ` Eli Zaretskii
2024-05-03 6:23 ` Juri Linkov
2024-05-03 7:15 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FDB853F1-60B6-4ACF-8E08-337567CB3CBC@gmail.com \
--to=jdtsmith@gmail.com \
--cc=70576@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).