From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#13177: 24.3.50; doc of `read-char-by-name' Date: Fri, 21 Dec 2012 00:04:50 -0800 Message-ID: References: <4AF22BD1F38E4AF2A650D1F537B47069@us.oracle.com><8762431shy.fsf@mail.jurta.org><9D74DAC118B44C3DAF75A8CFC6AE7FB3@us.oracle.com> <87d2y32641.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1356077164 21173 80.91.229.3 (21 Dec 2012 08:06:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 21 Dec 2012 08:06:04 +0000 (UTC) Cc: 13177@debbugs.gnu.org To: "'Chong Yidong'" , "'Stefan Monnier'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 21 09:06:18 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TlxcU-0005wD-7O for geb-bug-gnu-emacs@m.gmane.org; Fri, 21 Dec 2012 09:06:14 +0100 Original-Received: from localhost ([::1]:48599 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TlxcG-0003at-FX for geb-bug-gnu-emacs@m.gmane.org; Fri, 21 Dec 2012 03:06:00 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:33274) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tlxc9-0003aa-Av for bug-gnu-emacs@gnu.org; Fri, 21 Dec 2012 03:05:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tlxc6-0006D5-64 for bug-gnu-emacs@gnu.org; Fri, 21 Dec 2012 03:05:53 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:43191) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tlxc6-0006D1-1z for bug-gnu-emacs@gnu.org; Fri, 21 Dec 2012 03:05:50 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TlxcI-0003ga-1R for bug-gnu-emacs@gnu.org; Fri, 21 Dec 2012 03:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Dec 2012 08:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13177 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13177-submit@debbugs.gnu.org id=B13177.135607711214087 (code B ref 13177); Fri, 21 Dec 2012 08:06:02 +0000 Original-Received: (at 13177) by debbugs.gnu.org; 21 Dec 2012 08:05:12 +0000 Original-Received: from localhost ([127.0.0.1]:53430 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlxbS-0003f8-Tg for submit@debbugs.gnu.org; Fri, 21 Dec 2012 03:05:12 -0500 Original-Received: from userp1040.oracle.com ([156.151.31.81]:25471) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TlxbQ-0003f0-8N for 13177@debbugs.gnu.org; Fri, 21 Dec 2012 03:05:09 -0500 Original-Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by userp1040.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id qBL84sER032743 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 21 Dec 2012 08:04:54 GMT Original-Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id qBL84rkx000761 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 21 Dec 2012 08:04:53 GMT Original-Received: from abhmt108.oracle.com (abhmt108.oracle.com [141.146.116.60]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id qBL84ra7012812; Fri, 21 Dec 2012 02:04:53 -0600 Original-Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 21 Dec 2012 00:04:52 -0800 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87d2y32641.fsf@gnu.org> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Thread-Index: Ac3fUFWXTybrbUqmSSSfTp3mkcR3kAAAFcLA X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:68831 Archived-At: > > It's called "read-char-by-name", so the intention is pretty > > clear: it should return a char. > > Agreed. I changed read-char-by-name on the trunk to signal > an error for invalid input. (This also avoids other wonky cases, > e.g. entering ## giving the empty symbol because `read-char-by-name' > uses `read'...) I don't understand why you did that, if you agree with Stefan. He proposed making `completing-read' require input that represents a valid char. Why let `completing-read' accept invalid input and then raise an error saying the input is invalid? Sorry, I don't get it - seems not very helpful. The function should require the user to provide matching input (name or valid code) or use `C-g' or `C-]' to cancel reading.