From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mou Tong Newsgroups: gmane.emacs.bugs Subject: bug#67674: 30.0.50; shr-heading's update broke racket-mode's documention read Date: Thu, 7 Dec 2023 02:49:20 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="_000_FC11C64D772B4F7894E7EDB6130EC472outlookcom_" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7877"; mail-complaints-to="usenet@ciao.gmane.io" To: 67674@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 07 03:56:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rB4Yc-0001r0-Ma for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Dec 2023 03:56:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rB4YP-0003iG-Sw; Wed, 06 Dec 2023 21:55:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rB4YJ-0003hx-Hm for bug-gnu-emacs@gnu.org; Wed, 06 Dec 2023 21:55:51 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rB4YI-0001DO-7m for bug-gnu-emacs@gnu.org; Wed, 06 Dec 2023 21:55:51 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rB4YU-0005ao-02 for bug-gnu-emacs@gnu.org; Wed, 06 Dec 2023 21:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mou Tong Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Dec 2023 02:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 67674 X-GNU-PR-Package: emacs X-Debbugs-Original-To: "bug-gnu-emacs@gnu.org" Original-Received: via spool by submit@debbugs.gnu.org id=B.170191770521425 (code B ref -1); Thu, 07 Dec 2023 02:56:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 7 Dec 2023 02:55:05 +0000 Original-Received: from localhost ([127.0.0.1]:40762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rB4XZ-0005ZV-0i for submit@debbugs.gnu.org; Wed, 06 Dec 2023 21:55:05 -0500 Original-Received: from lists.gnu.org ([2001:470:142::17]:59470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rB4XW-0005Ys-GE for submit@debbugs.gnu.org; Wed, 06 Dec 2023 21:55:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rB4XC-0003cB-0S for bug-gnu-emacs@gnu.org; Wed, 06 Dec 2023 21:54:42 -0500 Original-Received: from mail-mw2nam12olkn20820.outbound.protection.outlook.com ([2a01:111:f400:fe5a::820] helo=NAM12-MW2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rB4Wy-0000Xa-6c for bug-gnu-emacs@gnu.org; Wed, 06 Dec 2023 21:54:40 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cBo8QckW4TqLTEwAoR3mb3DEmKPhMaYOas9MNAuX/+BlHWDCuv7BUtNj5bNb8nSH6swTbnS/0Dve5RDl12+3fghWt9J8urPGRK+K6IcrppS93pULMhc562XXmyZ6Hk/0ju+vhqlHBX2MHOH2eCUlWHL/XWlRwGUtn+34s0gsdezVEGZg/iiwO0Vi9p+gT8DDlaKYV3Kb0Q2zUEV4KCNpvBi/H330TgNGvLIu3UP5AMQM5o9GH4GUcTyB5v4oNRbgUjqevoKxIcIOxBCnelE8zgsUBAbcoAqSJ+qGNCG/C8mDnUV8Evoo1wgxAodaCQ9eHng1SrJUlrNXhy25AJfCdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bwZyN//XUdCBqvhMatevDMZeaYFNEpeU7M7lRXS4QPE=; b=InUnBqoEODja/KqKbN3R861V2GaWCRK3mQNTK4vyGUdmWJbqisP6ZBRGwwtDWtWDXLH+T8Tu/C1JB572bf1kbANpj2kP8EIsBadP4xG2XDfE/C7Rbzr5lbDZmzmFCN9Iq08L6u4qkiwKQWBfU35BjqTKLGdVjxUqimIjpJOCKORuDuLtW0EcVgsBMpcSRmIm8CwYMRDOpwNgvYnhpAJK7oIDCCVUEK9jsCtcyS8pRPfWjQ8p+4P3WvMUkL0xYqgcqKD8yNzpo8J4fEylrq4Xn57S61I9n+aG1ACMHnVzYLl3aME0/mLbHz5aSlLVMDE7QpK2GMZ6UdqsFTGK3TfIyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bwZyN//XUdCBqvhMatevDMZeaYFNEpeU7M7lRXS4QPE=; b=p1Jp86/ZBMBh0N8IC87OdaVvUJNyfJ6DidqKY/dcetUm3McSU3GrKpLm5YvzX5x6Sa4rk4TVAm+qlGyaoTUEj1uJ/ucszxrKn3QGyg3ddJhD/7SXNv3JuBXY8FhuehsPMFNFIMd3Uv852Qd8sXQbAe+yoptAZBkRmtP89QMyVzKHpg18Lj68RGfCBFISCVepTJw85nnevqSVTOG6zl2bpwxPyRfBUS1ZglV7YznHDyjdFNeA/Ma6kistGepOhIWtzsJ12FPFUJPL8e6LL4xNDbXJGnNqs829QJuGWTCm8GkeIn/po98PQt5WTRL6uqi+TQPuciDU2lXhhuIrbtxiDQ== Original-Received: from SJ0P220MB0675.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:3ad::6) by SJ2P220MB1380.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:589::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.34; Thu, 7 Dec 2023 02:49:21 +0000 Original-Received: from SJ0P220MB0675.NAMP220.PROD.OUTLOOK.COM ([fe80::184:6498:1a43:539f]) by SJ0P220MB0675.NAMP220.PROD.OUTLOOK.COM ([fe80::184:6498:1a43:539f%4]) with mapi id 15.20.7046.034; Thu, 7 Dec 2023 02:49:21 +0000 Thread-Topic: 30.0.50; shr-heading's update broke racket-mode's documention read Thread-Index: AQHaKLf6XpfVcWNNek2gAS9f51fH9g== Accept-Language: zh-CN, en-US Content-Language: en-US x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [iuDJh51CuDLTJLKwy4TtEWR5DXJk+6Y0] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0P220MB0675:EE_|SJ2P220MB1380:EE_ x-ms-office365-filtering-correlation-id: 08219d58-ee21-45c3-fe77-08dbf6cf1cfe x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1gaXJ2S+49UCdxhOMCzJRf8TYfkWiRNJEKjolFptVwRPACDrZr+dW950afb02FxjDZ1sRNNM7QJo0KhAk0xjrOhz/ZfqZgnmfUXpAQyTnhXXFKwNovCDCPkjC2PnQawRPTCdjQxEOAFUQN+td74bAxuBqnUIzs9UC+6SeW10BVbfqH7N9VgNdEZyvoO8PEJV5Nfq/btYqFV1u/aHDDTWViJqlrUFEB5NbEfvp6AcZys/KEOLQamDTYYLR8aKyD14ca94K8SSupLaLa/ol7xxv5aUsWC/ZUp7lunyjXRediiudYzer+cAK65HlSnrzIc0Xb+i0PjhOzYonQ111zgV4x8frKvMGpKrJzNnUwdnomBTbvqA9Zgf6kh/vvZpLwWn/PabpYb7cjV3xI64TjZQad5E1iboPwso6vl0uI9mluUkHHXN3FBBqzGdFvvOhIqh969haaJp8Tr29oprZCtkjR4v9PZE1eWKiipDTb8/03TbBgbRYHuVx7ySBNijsIOorTuY/nn4yBXHTa3vJf1MEJ4v5BHgJR7AGRQj1NUZCSBKP+ffeUQGoXD3E2TdLoKU1Biz5vDHV5wdaIkDOTb0eFE1kbeEa3vOLhd3W3kjmvyu+g6xPsFj5Jf1zgDboGoX x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: vJSp/iY8zXnvwumx9fNJ5CHVoZC/pgOGae+xP72YVH6rwHEdYWmLLJb2SUtJ6gVYt2mJJBqz3hJUbr7PrL7R5sKyMJ9Of8zJodoWj0ybs2QXf8YEnyFt01jFM/zMrRLVR980IEgeHVJ8yaG9S/OAADSqyfXnrq6pOWE48LoJ+746db6QHpLaJGELAxGaH+hTActJdz5ANsG00+HlS1o+x35pwN0tWnHhK1qdb56NGdQ4MuTrGoRWx9lnjD5gfbwoeXmQl4y2zbA92RWA8aAVl/VH471+JRQ60Hu/YqFdmGhHYcs42TOCpR51Mh/t2Erj9LpjIdF0/aihNXYzIabO7natzDqzToeSdbHmQm+qpmFz1ytlKvNAT38F6hEDTtTd/6MidcgTj2aPRoLjG/JI3oB1aUV8yHb21WW1jkSo88917bzRMCMtmlq2oPN6HYbyUmGYP97QYycpwgDQIMBCvAA7d+IyLeXGztv0X66LIQG7d3Dra7ucKiL8YxIXg2/5U9ufBSTADc0yK6QBJiuuVWMNNvoGXpP8CuD/0fJ9/0r94JgfEdb3ZCrqgA+0aLJaNKmqG2DaVLCldn0AgyULU0hl22wWZRiaJBV/pT1DboxS198VSd8JAXjhoopM78EsXw/akbXDXYARmfIz1GmmKi9bN7mHDaXu65tk5mt8YKKtXmPGCfh5rvk2ignVGIIaTRmH3UjtKX/C+1jKM1C29l1HZ9o0ZwrCyEX5E/j4EX3O1adhTJ+/AqOb9c jQUuQX859MIPbhPhBDXS6QzXjrbeIVJBCo+Aa+9v8Vqi6FdSlL+yvybik4CuxIiDNzYmQQi/DDPkGcrNXk8EIi4QHparwi6bIg X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0P220MB0675.NAMP220.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 08219d58-ee21-45c3-fe77-08dbf6cf1cfe X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2023 02:49:20.8059 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2P220MB1380 Received-SPF: pass client-ip=2a01:111:f400:fe5a::820; envelope-from=mou.tong@outlook.com; helo=NAM12-MW2-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275639 Archived-At: --_000_FC11C64D772B4F7894E7EDB6130EC472outlookcom_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi there, I noticed that after this commit https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3Dd41a5e4b1bafbb974d= 2c886d3198d9bda7821591 There are some changes in the function `shr-heading`. ```diff (defun shr-heading (dom &rest types) (shr-ensure-paragraph) - (apply #'shr-fontize-dom dom types) + (let ((start (point)) + (level (string-to-number + (string-remove-prefix "shr-h" (symbol-name (car types)))))) + (apply #'shr-fontize-dom dom types) + (put-text-property start (pos-eol) 'outline-level level)) (shr-ensure-paragraph)) ``` In racket-mode, when looking for local docs, racket-mode will use the following function to `shr-heading`: (shr-heading dom face) Here `dom` is unrelated to this, problem occurs in `face`: `racket-mode` passed `face` (as an example, which value is `(variable-pitch (:height 1.6))`) to `shr-heading`, when `shr-heading` parses it: (symbol-name (car '((variable-patch (:height 1.6))))) error occurs: (wrong-type-argument symbolp (variable-patch (:height 1.6))) Does this counts as an Emacs's bug, or racket-mode's problem? thx --_000_FC11C64D772B4F7894E7EDB6130EC472outlookcom_ Content-Type: text/html; charset="us-ascii" Content-ID: <0204EEAAD4BBA049A4D9D88A9EDDDC90@NAMP220.PROD.OUTLOOK.COM> Content-Transfer-Encoding: quoted-printable
Hi there, I not= iced that after this commit

https://git.savannah.gnu.org/cgit/emacs.git/= commit/?id=3Dd41a5e4b1bafbb974d2c886d3198d9bda7821591

There are some = changes in the function `shr-heading`.

```diff<= /div>
 (defun sh= r-heading (dom &rest types)
   (s= hr-ensure-paragraph)
-  (apply = #'shr-fontize-dom dom types)
+  (let ((= start (point))
+     (level (string-to-number
+         (string-remove-prefix "shr-h" = (symbol-name (car types))))))
+   (apply= #'shr-fontize-dom dom types)
+   (put-t= ext-property start (pos-eol) 'outline-level level))
   (s= hr-ensure-paragraph))
```

In racket-mode,= when looking for local docs, racket-mode will use the
following funct= ion to `shr-heading`:

    (= shr-heading dom face)

Here `dom` is u= nrelated to this, problem occurs in `face`:

`racket-mode` p= assed `face` (as an example, which value is
`(variable-pitc= h (:height 1.6))`) to `shr-heading`, when `shr-heading`
parses it:

    (= symbol-name (car '((variable-patch (:height 1.6)))))

error occurs:

    (= wrong-type-argument symbolp (variable-patch (:height 1.6)))

Does this count= s as an Emacs's bug, or racket-mode's problem? thx

--_000_FC11C64D772B4F7894E7EDB6130EC472outlookcom_--