unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Mou Tong <mou.tong@outlook.com>
To: 67674@debbugs.gnu.org
Subject: bug#67674: 30.0.50; shr-heading's update broke racket-mode's documention read
Date: Thu, 7 Dec 2023 02:49:20 +0000	[thread overview]
Message-ID: <FC11C64D-772B-4F78-94E7-EDB6130EC472@outlook.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1149 bytes --]

Hi there, I noticed that after this commit

https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d41a5e4b1bafbb974d2c886d3198d9bda7821591

There are some changes in the function `shr-heading`.

```diff
 (defun shr-heading (dom &rest types)
   (shr-ensure-paragraph)
-  (apply #'shr-fontize-dom dom types)
+  (let ((start (point))
+     (level (string-to-number
+         (string-remove-prefix "shr-h" (symbol-name (car types))))))
+   (apply #'shr-fontize-dom dom types)
+   (put-text-property start (pos-eol) 'outline-level level))
   (shr-ensure-paragraph))
```

In racket-mode, when looking for local docs, racket-mode will use the
following function to `shr-heading`:

    (shr-heading dom face)

Here `dom` is unrelated to this, problem occurs in `face`:

`racket-mode` passed `face` (as an example, which value is
`(variable-pitch (:height 1.6))`) to `shr-heading`, when `shr-heading`
parses it:

    (symbol-name (car '((variable-patch (:height 1.6)))))

error occurs:

    (wrong-type-argument symbolp (variable-patch (:height 1.6)))

Does this counts as an Emacs's bug, or racket-mode's problem? thx


[-- Attachment #2: Type: text/html, Size: 4341 bytes --]

             reply	other threads:[~2023-12-07  2:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-07  2:49 Mou Tong [this message]
2023-12-08  1:09 ` bug#67674: 30.0.50; shr-heading's update broke racket-mode's documention Mou Tong
2023-12-08  6:45   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FC11C64D-772B-4F78-94E7-EDB6130EC472@outlook.com \
    --to=mou.tong@outlook.com \
    --cc=67674@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).