unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Mattias Engdegård" <mattiase@acm.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 48678@debbugs.gnu.org
Subject: bug#48678: [PATCH] lex floats with trailing dot and exponent correctly
Date: Sat, 29 May 2021 09:47:39 +0200	[thread overview]
Message-ID: <FA10B3A8-044A-48C8-A196-34025A5FCB40@acm.org> (raw)
In-Reply-To: <878s3yrs8x.fsf@gnus.org>

29 maj 2021 kl. 08.03 skrev Lars Ingebrigtsen <larsi@gnus.org>:

> There didn't seem to be any reported breakages from this yet.  It does
> seem quite NEWS-worthy, though, so I've added an entry, and I'm closing
> this bug report.

Excellent! I was going to write a NEWS entry, so thank you for forcing my hand. I took the liberty to make a few minor changes to it for precision; if it isn't to your liking, do tell.

>  If serious breakages do happen, we should consider
> backing out the change.

Most certainly, but I'm confident in the change. It wasn't done without serious preparation: I scanned hundreds of Emacs packages, and checked all boolean combinations in the reader condition to guarantee correctness (which showed that a flag in the condition was redundant and could be removed). There is now a serious test.

Looking for the origin I also ran Maclisp on a PDP-10 and can confirm that it does not have the bug, so it must have been endogenous to Emacs.






  reply	other threads:[~2021-05-29  7:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26 16:56 bug#48678: [PATCH] lex floats with trailing dot and exponent correctly Mattias Engdegård
2021-05-26 17:27 ` Eli Zaretskii
2021-05-26 22:13   ` Lars Ingebrigtsen
2021-05-27  7:32     ` Andreas Schwab
2021-05-27  7:40       ` Lars Ingebrigtsen
2021-05-27 12:28         ` Mattias Engdegård
2021-05-27 12:36         ` Philipp Stephani
2021-05-27 12:37           ` Philipp Stephani
2021-05-27 12:20   ` Mattias Engdegård
2021-05-29  6:03     ` Lars Ingebrigtsen
2021-05-29  7:47       ` Mattias Engdegård [this message]
2021-05-30  4:07         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FA10B3A8-044A-48C8-A196-34025A5FCB40@acm.org \
    --to=mattiase@acm.org \
    --cc=48678@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).