From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#50067: Context menus Date: Wed, 18 Aug 2021 19:46:45 +0200 Message-ID: References: <74BC00E9-2509-47DA-9428-1523FF7F3B33@acm.org> <87v942pvcj.fsf@mail.linkov.net> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23955"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50067@debbugs.gnu.org, Tak Kunihiro , tkk@misasa.okayama-u.ac.jp, Lars Ingebrigtsen , Alan Third To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 18 19:47:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mGPei-00061K-M5 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 18 Aug 2021 19:47:12 +0200 Original-Received: from localhost ([::1]:37470 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mGPeh-00007G-5S for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 18 Aug 2021 13:47:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37280) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGPeY-000073-Hn for bug-gnu-emacs@gnu.org; Wed, 18 Aug 2021 13:47:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45981) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mGPeY-0001zP-34 for bug-gnu-emacs@gnu.org; Wed, 18 Aug 2021 13:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mGPeX-0003lX-Vm for bug-gnu-emacs@gnu.org; Wed, 18 Aug 2021 13:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Aug 2021 17:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50067 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 50067-submit@debbugs.gnu.org id=B50067.162930882014468 (code B ref 50067); Wed, 18 Aug 2021 17:47:01 +0000 Original-Received: (at 50067) by debbugs.gnu.org; 18 Aug 2021 17:47:00 +0000 Original-Received: from localhost ([127.0.0.1]:57527 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGPeW-0003lH-J7 for submit@debbugs.gnu.org; Wed, 18 Aug 2021 13:47:00 -0400 Original-Received: from mail1459c50.megamailservers.eu ([91.136.14.59]:40856 helo=mail267c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGPeS-0003kz-GO for 50067@debbugs.gnu.org; Wed, 18 Aug 2021 13:46:58 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1629308809; bh=OKfdWL5Bak6QYLWYs42tBorpbj6n2NcUL3tlJBZiDG8=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=okuTuG8QrVJWdWl2rBEBAPcqlAg6jW2x3/5mZFEQhwXBQoIL0r/SUzyB3p51VyrrF 4h91xhpXXy4x1spHCaf3kwJHkpWzvaZe4JhtsD3Zr4/vSDR1E2SsDdIBaPfA6rOhmV 4NVS4VofgnbNehqY3PDJ561H9UPH5VFgdWQsjnXw= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail267c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 17IHkj64022241; Wed, 18 Aug 2021 17:46:47 +0000 In-Reply-To: <87v942pvcj.fsf@mail.linkov.net> X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F25.611D4789.0024, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=S9SnP7kP c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=IkcTkHD0fZMA:10 a=M51BFTxLslgA:10 a=ucMQw-l_AAAA:8 a=L4BmyjnkBGAdIlXQYDgA:9 a=QEXdDO2ut3YA:10 a=xkTruGkd22MpkFU079mG:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212168 Archived-At: 18 aug. 2021 kl. 18.42 skrev Juri Linkov : > The raison d'=C3=AAtre for the special mode context-menu-mode is to > rebind the default keys optionally. So it would make sense to bind > context-menu-entry conditionally: >=20 > 1. to [C-mouse-1] on macOS depending on =E2=80=98(featurep 'ns)=E2=80=99= ; > 2. to [down-mouse-3] everywhere else. >=20 > in the function body of context-menu-mode. We'd like both bindings to work on macOS (the user could have a mouse = with a right button) but that should be doable. > After trying to remove it altogether, there is no title at all, > but maybe it's platform-dependent (I tested on GTK): After your suggested change I still get the "Select" title; needs to be = investigated further. > Could you please provide a test case? Because I've thoroughly tested > =E2=80=9CFind Definition=E2=80=9D to apply where the click occurred, = and it works as expected. Yes it works for elisp, because its xref backend is simplistic enough to = just accept the symbol given as argument. An example of a package where = it doesn't work is merlin which is rather more sophisticated and wants = to find the exact context so that it can find the right definition, so = it ignores the argument. It would be useful to do this for elisp as well, so that it would work = for local variables etc.