From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#68244: hash-table improvements Date: Sat, 13 Jan 2024 21:06:06 +0100 Message-ID: References: <170438379722.3921.9312235725296561206@vcs2.savannah.gnu.org> <20240104155642.B4A99C00344@vcs2.savannah.gnu.org> <8d49ebdc-9da7-4e70-a080-d8e892b980b6@gutov.dev> <08314177-5AE9-4352-94A0-641830B4094D@gmail.com> <19265EA5-E6F3-446C-AD9B-763693CF0A48@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31766"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , Eli Zaretskii , 68244@debbugs.gnu.org, Stefan Kangas To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 13 21:07:30 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rOkHy-00088N-2H for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Jan 2024 21:07:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rOkHZ-0003Wu-AF; Sat, 13 Jan 2024 15:07:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOkHX-0003WG-P0 for bug-gnu-emacs@gnu.org; Sat, 13 Jan 2024 15:07:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rOkHX-00025P-GH for bug-gnu-emacs@gnu.org; Sat, 13 Jan 2024 15:07:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rOkHW-0004Na-79 for bug-gnu-emacs@gnu.org; Sat, 13 Jan 2024 15:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Jan 2024 20:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68244 X-GNU-PR-Package: emacs Original-Received: via spool by 68244-submit@debbugs.gnu.org id=B68244.170517637516755 (code B ref 68244); Sat, 13 Jan 2024 20:07:02 +0000 Original-Received: (at 68244) by debbugs.gnu.org; 13 Jan 2024 20:06:15 +0000 Original-Received: from localhost ([127.0.0.1]:41186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOkGk-0004MB-Ru for submit@debbugs.gnu.org; Sat, 13 Jan 2024 15:06:15 -0500 Original-Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]:55582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOkGi-0004Lx-LP for 68244@debbugs.gnu.org; Sat, 13 Jan 2024 15:06:13 -0500 Original-Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-50e759ece35so8475770e87.3 for <68244@debbugs.gnu.org>; Sat, 13 Jan 2024 12:06:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705176368; x=1705781168; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=RULZLHbQUFpp1fXq9pcL0rBV2yr7eEqecJYTJieRxMs=; b=ijBSpeAw0nQBGkQ+JIXzY0koOPkuCldkFi13vJ0zvUj/fZ2AaIBwDV7Cbj1Qh4hGz4 9q6A5mKkX5OoN0c6uAjme5RQdKm3YvuLWOmYEEbrr3uXCnFYcVi0gLQxQN6NQ84voWVL Achk/+5cVKLHE49OzNYQv8ovDXRYT9lMJAOBAaJUge+gja3hiMP9eHcxegh01aoz/lUH d28hyN2yQNaMOKXYgtSTOtCd8dz10L3QTp2VvumrmtE1U6T5nkgj7TZfxEwIlKOEabNe 4N1kaDbbMlI2G+fLtJ8enulR7FWJmldSnNWqzVG1d/e6zp5rYjwwFcObW06BnYbm8jMd Ld1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705176368; x=1705781168; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=RULZLHbQUFpp1fXq9pcL0rBV2yr7eEqecJYTJieRxMs=; b=pXD+3EzU24x1ckhKlLOnZAWEt/NbBiFiRVzo1kX+BaWcf9tXcRWM6ZNEUrhyWxDo5r t2CCpY2bkl/KX6kVn1cnyJLAKO4Aygx9eYqHalzkzHVyJBckxolb6QLKRGkbtguDkXA5 XZZI0fO74PHiYQxlAdB61jFT66sEDIWxaJqKB80iCVULbP5I3hFbkLrFk6PisT+JJ0eT pZNgEqNFCRWFUCp1imAPFO677aD9gzQf8jTBHVv5IgYjA6eOTOJS3PdVYQp/jreetvo8 G4sx27S+EqsD/KjyI9hHv90PtKYJ7ATqEZvl8M0IVk8yCxKrlRqCdRZhb559OqbfnLIo N8iw== X-Gm-Message-State: AOJu0Yy5EwhOsHXDV8qzrpcnVCrdmI+LPJ3iCCQou0Dxi0Vj1kVRhSaW EI8414DzrwvKcsYFhtqiOro= X-Google-Smtp-Source: AGHT+IGkWwsKiNsA2jXnIb3KD3WfHcfFbAdME82QSgMB/UK1ZFX5YN+6DKqiIPZhDjYGQuwB1u/jHg== X-Received: by 2002:a05:6512:2810:b0:50e:5958:5045 with SMTP id cf16-20020a056512281000b0050e59585045mr1688508lfb.22.1705176367648; Sat, 13 Jan 2024 12:06:07 -0800 (PST) Original-Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id j9-20020a05651231c900b0050ed70b8731sm926553lfe.249.2024.01.13.12.06.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 13 Jan 2024 12:06:07 -0800 (PST) In-Reply-To: X-Mailer: Apple Mail (2.3654.120.0.1.15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278158 Archived-At: All right, I've pushed the parts that I have little doubt about being a = definite improvement: a batch of refactoring steps, then the hash-table = printing reforms, the representation and growth algorithm improvements, = and finally documentation updates, all now on master. Not part of this yet: - unifying hash and next vectors (or hash, next and key_and_value) in a = single array: pending benchmarks. - Knuth range reduction: probably a gain as described earlier, but I = want to study the behaviour in more of an apples-to-apples comparison = since the table and index sizes were changed at the same time. - turning hash_table_test structures into Lisp objects so that they can = be referenced from a symbol property: seemed to worsen performance = slightly so putting this on hold for the time being. - adaptive index vector width: measurements needed. - fancier hashing: to be implemented. Maybe we should promote equal-including-properties to a first-class hash = table test? It's defined as a user test in two places in the Emacs = tree, and user tests are much slower than built-in ones.