From: "Orhan Kemal Yüksel" <orhan.kemal.yueksel@posteo.de>
To: 67615@debbugs.gnu.org
Cc: eliz@gnu.org
Subject: bug#67615: [PATCH v6] Add option Info-url-alist
Date: Sat, 20 Jan 2024 01:41:19 +0000 [thread overview]
Message-ID: <F4B8101E-FA09-45B2-BFB1-DA7E04344C48@posteo.de> (raw)
In-Reply-To: <87edec3jcl.fsf@posteo.de>
[-- Attachment #1: Type: text/plain, Size: 1919 bytes --]
On January 20, 2024 1:50:22 AM GMT+01:00, Mekeor Melire <mekeor@posteo.de> wrote:
>2024-01-13 11:51 eliz@gnu.org:
>
>> > From: Mekeor Melire <mekeor@posteo.de>
>> > Cc: 67615@debbugs.gnu.org
>> > Date: Mon, 08 Jan 2024 21:56:03 +0000
>
>> I was going to install this, but it causes info-tests in the test
>> suite to fail:
>
>> If we want the result to include the "html" extension (which might not
>> be correct, since perhaps we could have Minibuffer.htm?), then please
>> update the test. Otherwise, it sounds like the code needs some
>> adjustment to behave as before?
>
>I vote for keeping the ".html" suffix because I can imagine that Texinfo
>creates only files with that suffix and it's depends on the web-server
>and its configuration if the file is also served when the suffix is
>missed in the URL.
>
>Unfortunately, I was not able to verify this in the Texinfo
>documentation or source code.
>
>I had to make another adjustment info-test.el to make the test succeed:
>Previously, Info-node-for-url failed when the passed manual-name was
>neither "emacs" nor "elisp". In particular, it failed for "gnus". Now
>that "gnus" is a handled manual-name, it succeeds. But it should still
>error when the manual-name is not handled (by the default value of the
>newly introduced Info-url-alist).
>
>> Please also improve the commit log message to mention all the changes,
>> not just the new option. See CONTRIBUTE for details, and you can use
>> "git log" to see many examples of how we do that.
>
>I gave my best.
>
I will send another version of the patch. The %e provided to URL-SPECs in Info-url-alist should not contain the ".html"-suffix. Since we know that the webserver of gnu.org does serve the docs even if the URL omits the HTML-suffix, we should prefer that shorter version since it's easier on the eyes (and better e.g. for IRC etc.).
Sorry for the noise.
[-- Attachment #2: Type: text/html, Size: 3093 bytes --]
next prev parent reply other threads:[~2024-01-20 1:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 0:04 bug#67615: [PATCH] * lisp/info.el (Info-url-for-node): Support all Emacs info manuals Mekeor Melire
2023-12-04 0:30 ` Mekeor Melire
2023-12-04 10:02 ` bug#67615: [PATCH v2] " Mekeor Melire
2023-12-04 15:51 ` Mekeor Melire
2023-12-04 16:24 ` Eli Zaretskii
2023-12-05 1:06 ` bug#67615: Org-Mode story on how I gathered the list of Emacs-contained online-manuals Mekeor Melire
2023-12-07 2:48 ` bug#67615: [PATCH v2] * lisp/info.el (Info-url-for-node): Support all Emacs info manuals Richard Stallman
2023-12-07 7:19 ` Eli Zaretskii
2023-12-07 11:56 ` Mekeor Melire
2023-12-07 17:02 ` Eli Zaretskii
2023-12-09 4:05 ` Richard Stallman
2023-12-08 0:15 ` bug#67615: [PATCH v3] * lisp/info.el (Info-url-alist): New option mapping manuals to URLs Mekeor Melire
2023-12-09 9:42 ` Eli Zaretskii
2023-12-09 11:21 ` Mekeor Melire
2023-12-19 23:08 ` bug#67615: [PATCH v4] " Mekeor Melire
2023-12-23 10:05 ` Eli Zaretskii
2024-01-08 21:56 ` bug#67615: [PATCH v5] " Mekeor Melire
2024-01-13 9:51 ` Eli Zaretskii
2024-01-20 0:50 ` bug#67615: [PATCH v6] Add option Info-url-alist Mekeor Melire
2024-01-20 1:41 ` Orhan Kemal Yüksel [this message]
2024-01-20 7:23 ` Eli Zaretskii
2024-01-21 1:43 ` bug#67615: [PATCH v7] " Mekeor Melire
2024-01-27 10:21 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F4B8101E-FA09-45B2-BFB1-DA7E04344C48@posteo.de \
--to=orhan.kemal.yueksel@posteo.de \
--cc=67615@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).