* bug#40519: 28.0.50; decode-coding-string fails EOL conversion of ASCII string
@ 2020-04-09 8:26 Kazuhiro Ito
2020-04-09 9:22 ` Eli Zaretskii
2020-04-16 10:44 ` Mattias Engdegård
0 siblings, 2 replies; 4+ messages in thread
From: Kazuhiro Ito @ 2020-04-09 8:26 UTC (permalink / raw)
To: 40519
Since commit 4ed39549e3f9dbfeb2aea0e2674a7701dbc0e5ea (Avoid expensive
recoding for ASCII identity cases (bug#40407)), below code returns
unexpected result.
(let ((string "ABCD\x0d\nEFG")
inhibit-eol-conversion)
(decode-coding-string string 'raw-text-dos))
-> "ABCD^M
EFG"
expected result is
-> "ABCD
EFG"
It seems that the committed code does not take care of EOL conversion.
--
Kazuhiro Ito
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#40519: 28.0.50; decode-coding-string fails EOL conversion of ASCII string
2020-04-09 8:26 bug#40519: 28.0.50; decode-coding-string fails EOL conversion of ASCII string Kazuhiro Ito
@ 2020-04-09 9:22 ` Eli Zaretskii
2020-04-09 10:48 ` Kazuhiro Ito
2020-04-16 10:44 ` Mattias Engdegård
1 sibling, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2020-04-09 9:22 UTC (permalink / raw)
To: Kazuhiro Ito; +Cc: 40519
> Date: Thu, 09 Apr 2020 17:26:05 +0900
> From: Kazuhiro Ito <kzhr@d1.dion.ne.jp>
>
> Since commit 4ed39549e3f9dbfeb2aea0e2674a7701dbc0e5ea (Avoid expensive
> recoding for ASCII identity cases (bug#40407)), below code returns
> unexpected result.
>
> (let ((string "ABCD\x0d\nEFG")
> inhibit-eol-conversion)
> (decode-coding-string string 'raw-text-dos))
>
> -> "ABCD^M
> EFG"
>
> expected result is
> -> "ABCD
> EFG"
>
> It seems that the committed code does not take care of EOL conversion.
Thanks, I hope I fixed this now.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#40519: 28.0.50; decode-coding-string fails EOL conversion of ASCII string
2020-04-09 9:22 ` Eli Zaretskii
@ 2020-04-09 10:48 ` Kazuhiro Ito
0 siblings, 0 replies; 4+ messages in thread
From: Kazuhiro Ito @ 2020-04-09 10:48 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 40519
> > Since commit 4ed39549e3f9dbfeb2aea0e2674a7701dbc0e5ea (Avoid expensive
> > recoding for ASCII identity cases (bug#40407)), below code returns
> > unexpected result.
> >
> > (let ((string "ABCD\x0d\nEFG")
> > inhibit-eol-conversion)
> > (decode-coding-string string 'raw-text-dos))
> >
> > -> "ABCD^M
> > EFG"
> >
> > expected result is
> > -> "ABCD
> > EFG"
> >
> > It seems that the committed code does not take care of EOL conversion.
>
> Thanks, I hope I fixed this now.
Thank you. But there is still a problem in encode-coding-string.
(let ((string "ABCD\nEFG")
inhibit-eol-conversion)
(list
(encode-coding-string string 'raw-text-dos)
(encode-coding-string string 'raw-text-mac)))
-> ("ABCD
EFG" "ABCD
EFG")
--
Kazuhiro Ito
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#40519: 28.0.50; decode-coding-string fails EOL conversion of ASCII string
2020-04-09 8:26 bug#40519: 28.0.50; decode-coding-string fails EOL conversion of ASCII string Kazuhiro Ito
2020-04-09 9:22 ` Eli Zaretskii
@ 2020-04-16 10:44 ` Mattias Engdegård
1 sibling, 0 replies; 4+ messages in thread
From: Mattias Engdegård @ 2020-04-16 10:44 UTC (permalink / raw)
To: 40519-done; +Cc: Kazuhiro Ito
This was fixed as part of bug#40407 (e18c24b35a).
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-16 10:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-09 8:26 bug#40519: 28.0.50; decode-coding-string fails EOL conversion of ASCII string Kazuhiro Ito
2020-04-09 9:22 ` Eli Zaretskii
2020-04-09 10:48 ` Kazuhiro Ito
2020-04-16 10:44 ` Mattias Engdegård
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).