From: Matthew Malcomson <hardenedapple@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 62419@debbugs.gnu.org
Subject: bug#62419: 28.2; Elisp let-bound buffer-local variable and kill-local-variable
Date: Wed, 29 Mar 2023 11:56:32 +0100 [thread overview]
Message-ID: <F386A8CD-10FB-4A33-A071-082CCA88CE4E@gmail.com> (raw)
In-Reply-To: <jwv355r7d04.fsf-monnier+emacs@gnu.org>
Thanks!
Just for the record I’ve been running using essentially this patch (but with !=) since you suggested it and have not had any problems.
FWIW I also think the change to avoid `let` binding `auto-fill-function` in `normal-mode` is good.
Regards,
Matthew
> On 26 Mar 2023, at 16:30, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>
>> I.e. currently the behaviour of `setq` on automatic buffer-local variables is:
>> - Outside `let`, always affect buffer-local (creating if necessary)
>> - In `let` of global binding, affect global binding.
>> - In `let` of buffer-local binding, affect buffer-local
>> - In `let` of buffer-local binding but where buffer-local value has
>> been killed, affect global value.
>>
>> I believe that last condition is strange and the behaviour of `setq` would
>> be more understandable without it.
>
> I think the patch below would fix this corner case.
>
>
> Stefan
>
>
> diff --git a/src/eval.c b/src/eval.c
> index ef7ca33f834..82ada40b309 100644
> --- a/src/eval.c
> +++ b/src/eval.c
> @@ -3364,7 +3364,7 @@ DEFUN ("fetch-bytecode", Ffetch_bytecode, Sfetch_bytecode,
> return object;
> }
>
> -/* Return true if SYMBOL currently has a let-binding
> +/* Return true if SYMBOL's default currently has a let-binding
> which was made in the buffer that is now current. */
>
> bool
> @@ -3379,6 +3379,7 @@ let_shadows_buffer_binding_p (struct Lisp_Symbol *symbol)
> struct Lisp_Symbol *let_bound_symbol = XSYMBOL (specpdl_symbol (p));
> eassert (let_bound_symbol->u.s.redirect != SYMBOL_VARALIAS);
> if (symbol == let_bound_symbol
> + && !p->kind == SPECPDL_LET_LOCAL /* bug#62419 */
> && EQ (specpdl_where (p), buf))
> return 1;
> }
>
next prev parent reply other threads:[~2023-03-29 10:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 13:37 bug#62419: 28.2; Elisp let-bound buffer-local variable and kill-local-variable Matthew Malcomson
2023-03-25 11:49 ` Eli Zaretskii
2023-03-25 16:19 ` Matthew Malcomson
2023-03-26 14:01 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-26 14:34 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-26 15:01 ` Matthew Malcomson
2023-03-26 15:16 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-26 15:30 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-29 10:56 ` Matthew Malcomson [this message]
2023-04-02 21:55 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-12 0:00 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F386A8CD-10FB-4A33-A071-082CCA88CE4E@gmail.com \
--to=hardenedapple@gmail.com \
--cc=62419@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).