From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#62416: 30.0.50; Symbols skipped in the navigation in ruby-ts-mode Date: Thu, 30 Mar 2023 00:47:58 -0700 Message-ID: References: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11658"; mail-complaints-to="usenet@ciao.gmane.io" Cc: bosko.ivanisevic@gmail.com, 62416@debbugs.gnu.org, Dmitry Gutov To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 30 09:49:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1phn2D-0002oI-Lc for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Mar 2023 09:49:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1phn1s-00054d-Rw; Thu, 30 Mar 2023 03:49:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phn1q-00054R-B0 for bug-gnu-emacs@gnu.org; Thu, 30 Mar 2023 03:49:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1phn1q-0004gp-4R for bug-gnu-emacs@gnu.org; Thu, 30 Mar 2023 03:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1phn1p-00078d-V7 for bug-gnu-emacs@gnu.org; Thu, 30 Mar 2023 03:49:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Mar 2023 07:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62416 X-GNU-PR-Package: emacs Original-Received: via spool by 62416-submit@debbugs.gnu.org id=B62416.168016249927334 (code B ref 62416); Thu, 30 Mar 2023 07:49:01 +0000 Original-Received: (at 62416) by debbugs.gnu.org; 30 Mar 2023 07:48:19 +0000 Original-Received: from localhost ([127.0.0.1]:55642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phn18-00076n-QS for submit@debbugs.gnu.org; Thu, 30 Mar 2023 03:48:19 -0400 Original-Received: from mail-pl1-f169.google.com ([209.85.214.169]:40537) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phn17-000761-4B for 62416@debbugs.gnu.org; Thu, 30 Mar 2023 03:48:17 -0400 Original-Received: by mail-pl1-f169.google.com with SMTP id u10so17317100plz.7 for <62416@debbugs.gnu.org>; Thu, 30 Mar 2023 00:48:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680162491; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=E84/BiIekhJFjcf+LzuYNWDBw78lSOp1sbH45jiIERg=; b=XM4iR1qqt38dX0ndfY2CKk5CzMDD3I6lqGmFn6xuIakxmyNdPEeMlUdT/LO/e+Aard 4+my787RefLMDQMgP5/wrIYaRxerXD7LdSVyD868B7VzHTmjauRJxNKI/hZspXZyXGbG LKz7YLiPknx1NIewECFtGcz6RNYPHqYohORmPtR8frNAZWtUaGpATeFvhfpbm4W10rSE IJI5CwZuwkxjNf1Rmy/hX+9HjCzF5Iqy6AyJ8vBXfmigWPv8QvDGIwDKVfhakpZ99W7h 2QNYrJqqVTNzA5hj3IQQ+l3GAj2gERHk2KgLCz2uJUTHmtyr/4y+6bI4kPcuVqrDQxFL hDQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680162491; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E84/BiIekhJFjcf+LzuYNWDBw78lSOp1sbH45jiIERg=; b=yZ9v39ZKrj1ayVmpz6TFFx9hVPHQtRfBfk9tgDAW/5S6e5MIkad1+XM70BvRqNk9ny 8kEb7tssf7w2F/tZqi1PKgvELnFL7RHKuekK/XnNZKhVWM+wdcbO7e6PKCnr0et51zlp I3SQ88Uq1j7GOhHutZo1SJbdi5YXFvBFE6MpG0PqmWrbjI8DNRW/qjPaQCqkgqZA0byQ SpTnV9W1mddf1cgtoS3ldqnfLoDvEISXnW6lgkXMb8bmZ7+lHZK2rlI8uj3FMNJJsvCB r7Ply1Xx1w9VOz8SC6JOw6RpRHTnJ91mllKnPI+aLU9+8BXAGdUhmul5ay4KpY0c6Ak4 vJhw== X-Gm-Message-State: AO0yUKWnQU+xQ0jdlVvPCmEsTe7gz+DSCb3y9cGFLiNBm2ji3oc5pijx 9w1QqBBECA7L7QG3BoIMVFY= X-Google-Smtp-Source: AK7set/t+oDRaQrRMq0BY9ogEce4T3vsx+StlbVSAJR0KoPcnH+gu9f+pCjc4Hkz3NbS9ut/vUakTg== X-Received: by 2002:a05:6a20:3a9f:b0:d9:1aed:a05b with SMTP id d31-20020a056a203a9f00b000d91aeda05bmr19845247pzh.50.1680162490670; Thu, 30 Mar 2023 00:48:10 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id c22-20020aa78c16000000b006280ae74893sm18359854pfd.48.2023.03.30.00.48.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Mar 2023 00:48:10 -0700 (PDT) X-Mailer: Apple Mail (2.3731.400.51.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258898 Archived-At: Juri Linkov writes: >>> This will break other cases, e.g. >>> b =3D %Q{This is a "string"} >>> c =3D %w!foo >>> bar >>> baz! >>> d =3D %(hello (nested) world) >>> when point is after "b", 'C-M-f' will move to "c" instead of the end = of >>> line. >> >> That is because the string literals aren't recognized as sexps yet. = Try >> this: >> >> @@ -1129,8 +1129,11 @@ ruby-ts-mode >> "block" >> "do_block" >> "begin" >> - "binary" >> - "assignment"))) >> + "integer" >> + "simple_symbol" >> + "string" >> + "string_array" >> + ))) > > Thanks, this definitely is an improvement since it handles all = mentioned cases. > > However, there are still a lot of more things that need fixing. > When point is on the left curly bracket in > > b =3D %Q{This is a "string"} > > 'C-M-f' doesn't move to the right curly bracket. > Also double quotes inside the string are not matched by 'C-M-f'. > > In > > d =3D %(hello (nested) world) > > 'C-M-f' doesn't move to the closing parens from opening parens. Have someone fixed these two cases? Because when I tried to invoke (treesit-forward-sexp), point moved to the closing bracket/paren. Anyway, I just wonder if there=E2=80=99s any fundamental shortcoming = with how treesit-beginning/end-of-thing works? Yuan