* bug#40890: Add missing word "the" to file "custom.texi".
@ 2020-04-27 0:12 ej32u--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-04-27 6:39 ` Stefan Kangas
0 siblings, 1 reply; 6+ messages in thread
From: ej32u--- via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2020-04-27 0:12 UTC (permalink / raw)
To: 40890
[-- Attachment #1.1: Type: text/plain, Size: 73 bytes --]
Hello,
The word "the" was missing. Attached is a patch file.
Thank you.
[-- Attachment #1.2: Type: text/html, Size: 393 bytes --]
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Insert-missing-word-the.patch --]
[-- Type: text/x-patch; name="0001-Insert-missing-word-the.patch", Size: 648 bytes --]
---
doc/emacs/custom.texi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/emacs/custom.texi b/doc/emacs/custom.texi
index e7e879065e..eb409d9945 100644
--- a/doc/emacs/custom.texi
+++ b/doc/emacs/custom.texi
@@ -755,7 +755,7 @@ Variables
buffer, you need not worry about giving it an invalid type: the
customization buffer usually only allows you to enter meaningful
values. When in doubt, use @kbd{C-h v} (@code{describe-variable}) to
-check the variable's documentation string to see kind of value it
+check the variable's documentation string to see the kind of value it
expects (@pxref{Examining}).
@menu
--
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#40890: Add missing word "the" to file "custom.texi".
2020-04-27 0:12 bug#40890: Add missing word "the" to file "custom.texi" ej32u--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2020-04-27 6:39 ` Stefan Kangas
2020-04-27 8:43 ` Tomas Nordin
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Kangas @ 2020-04-27 6:39 UTC (permalink / raw)
To: ej32u; +Cc: 40890
ej32u@protonmail.com writes:
> The word "the" was missing. Attached is a patch file.
Thanks for pointing this out.
> values. When in doubt, use @kbd{C-h v} (@code{describe-variable}) to
> -check the variable's documentation string to see kind of value it
> +check the variable's documentation string to see the kind of value it
> expects (@pxref{Examining}).
Would that be better if written like this?
values. When in doubt, use @kbd{C-h v} (@code{describe-variable}) to
-check the variable's documentation string to see kind of value it
+check the variable's documentation string to see the kind of value it
expects (@pxref{Examining}).
Best regards,
Stefan Kangas
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#40890: Add missing word "the" to file "custom.texi".
2020-04-27 6:39 ` Stefan Kangas
@ 2020-04-27 8:43 ` Tomas Nordin
2020-04-27 10:16 ` Stefan Kangas
0 siblings, 1 reply; 6+ messages in thread
From: Tomas Nordin @ 2020-04-27 8:43 UTC (permalink / raw)
To: Stefan Kangas, ej32u; +Cc: 40890
Stefan Kangas <stefan@marxist.se> writes:
> ej32u@protonmail.com writes:
>
>> The word "the" was missing. Attached is a patch file.
>
> Thanks for pointing this out.
>
>> values. When in doubt, use @kbd{C-h v} (@code{describe-variable}) to
>> -check the variable's documentation string to see kind of value it
>> +check the variable's documentation string to see the kind of value it
>> expects (@pxref{Examining}).
>
> Would that be better if written like this?
>
> values. When in doubt, use @kbd{C-h v} (@code{describe-variable}) to
> -check the variable's documentation string to see kind of value it
> +check the variable's documentation string to see the kind of value it
> expects (@pxref{Examining}).
Isn't that what the patch suggest? But maybe ..*what* kind of value it..
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#40890: Add missing word "the" to file "custom.texi".
2020-04-27 8:43 ` Tomas Nordin
@ 2020-04-27 10:16 ` Stefan Kangas
2020-04-27 14:46 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Kangas @ 2020-04-27 10:16 UTC (permalink / raw)
To: Tomas Nordin; +Cc: 40890, ej32u
Tomas Nordin <tomasn@posteo.net> writes:
> Isn't that what the patch suggest? But maybe ..*what* kind of value it..
Sorry, I forgot to save the file before copying the diff. We have the
same idea, adding "what" instead of "the" here, fixed below:
values. When in doubt, use @kbd{C-h v} (@code{describe-variable}) to
-check the variable's documentation string to see kind of value it
+check the variable's documentation string to see what kind of value it
expects (@pxref{Examining}).
But English is not my native language, so I wanted to check here first
before pushing a fix.
Best regards,
Stefan Kangas
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#40890: Add missing word "the" to file "custom.texi".
2020-04-27 10:16 ` Stefan Kangas
@ 2020-04-27 14:46 ` Eli Zaretskii
2020-04-27 15:11 ` Stefan Kangas
0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2020-04-27 14:46 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 40890, tomasn, ej32u
> From: Stefan Kangas <stefan@marxist.se>
> Date: Mon, 27 Apr 2020 12:16:50 +0200
> Cc: 40890@debbugs.gnu.org, ej32u@protonmail.com
>
> values. When in doubt, use @kbd{C-h v} (@code{describe-variable}) to
> -check the variable's documentation string to see kind of value it
> +check the variable's documentation string to see what kind of value it
> expects (@pxref{Examining}).
>
> But English is not my native language, so I wanted to check here first
> before pushing a fix.
This change is fine, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#40890: Add missing word "the" to file "custom.texi".
2020-04-27 14:46 ` Eli Zaretskii
@ 2020-04-27 15:11 ` Stefan Kangas
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Kangas @ 2020-04-27 15:11 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 40890, tomasn, ej32u
close 40890 27.1
thanks
Eli Zaretskii <eliz@gnu.org> writes:
> This change is fine, thanks.
Pushed to emacs-27 as commit 0278741676. Closing this bug.
Best regards,
Stefan Kangas
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-04-27 15:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-27 0:12 bug#40890: Add missing word "the" to file "custom.texi" ej32u--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-04-27 6:39 ` Stefan Kangas
2020-04-27 8:43 ` Tomas Nordin
2020-04-27 10:16 ` Stefan Kangas
2020-04-27 14:46 ` Eli Zaretskii
2020-04-27 15:11 ` Stefan Kangas
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).