From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#62825: 29.0.90; c-ts-mode doesn't recognize DEFUN functions Date: Wed, 19 Apr 2023 12:11:18 -0700 Message-ID: References: <80353D80-21FD-4ADE-8982-4B67C59B7E7B@gmail.com> <83jzycb5we.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17191"; mail-complaints-to="usenet@ciao.gmane.io" Cc: theo@thornhill.no, 62825@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 19 21:12:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ppDDz-0004H5-7p for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Apr 2023 21:12:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ppDDp-0003gc-Hv; Wed, 19 Apr 2023 15:12:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppDDn-0003ej-8a for bug-gnu-emacs@gnu.org; Wed, 19 Apr 2023 15:12:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ppDDm-0000Ux-PB for bug-gnu-emacs@gnu.org; Wed, 19 Apr 2023 15:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ppDDl-0005iM-Is for bug-gnu-emacs@gnu.org; Wed, 19 Apr 2023 15:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Apr 2023 19:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62825 X-GNU-PR-Package: emacs Original-Received: via spool by 62825-submit@debbugs.gnu.org id=B62825.168193149721931 (code B ref 62825); Wed, 19 Apr 2023 19:12:01 +0000 Original-Received: (at 62825) by debbugs.gnu.org; 19 Apr 2023 19:11:37 +0000 Original-Received: from localhost ([127.0.0.1]:35870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ppDDM-0005hf-S0 for submit@debbugs.gnu.org; Wed, 19 Apr 2023 15:11:37 -0400 Original-Received: from mail-pj1-f45.google.com ([209.85.216.45]:50451) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ppDDL-0005hS-Pt for 62825@debbugs.gnu.org; Wed, 19 Apr 2023 15:11:36 -0400 Original-Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-24756a12ba0so65930a91.1 for <62825@debbugs.gnu.org>; Wed, 19 Apr 2023 12:11:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681931490; x=1684523490; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pqeZ44Kgs3u41b2tebHPwUpKKwQaaTYEphSi7u3FaR4=; b=sh5VvjMItUl5ucjfGdtjXvyrVFYmlNGRsXacJ6l0cJRsV96EkVTaj1UiKg+x8kVGvS zijn7jJrWr0doDrf4WkHMAa+fJU/811P9ZS7nFbqx35h7jtxVos3h/a9T2ucHt5JbIkT vj0C3lROgi9u63KE+jwNcaE6ZFsaV9WyvAIh0QrsulvTX2GiIgGOPhEMmnGGvrxRAdLc RFycbKtpmk+76n+47//yFvOl5dlLswqvTJCxc52BQo0Jaa+mJx7ppv9wtRlwp61WxD9Z CG8y0sIG/0mvj/ZaAGIlo4z0CSl1YdHR4zV7BZPlUOk5pQJJsprFZe4Q2z6ttgrqWj8i idQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681931490; x=1684523490; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pqeZ44Kgs3u41b2tebHPwUpKKwQaaTYEphSi7u3FaR4=; b=mCnRBlyGdmHOpRHa7nVRGWRUtJOUBNqk33PBcvDBnJ/6WyOzejb9FvZ5O3NKxcWdn4 CqnQu8zPMLMog6CHtDfPHgNlOO9KQz6O190ZfhKqIZe+kmlgAcHrYOybwUfjIKf5YG+A +t8TGvh0EDEn7mfbhd6GnsZ88Mni1tYyxgw1/UmfZZJWCSWsKUpitUr624KnuGT4LSQn /ejNXf99VaHCPuwEWWDtHvEYHJIH79aoTf0CqlBGkjZcdGcTPQyZRKbsBO5GWYE+Kl0q b2Stw0+kx2P3jc/kJrbGlr41GnIIFWXPryOkZ/Jwk4nkYR/F27E9uXlV0HAHEsVTBpRC labA== X-Gm-Message-State: AAQBX9fyrQxz+izpQqLP4h3kZrediF4cmuZmX8SYgIyPZzIHwuuNSsRt VcXKqShcpCiO/4xX56qaGk8nEamO6lT5bA== X-Google-Smtp-Source: AKy350a8G8CrRZgB2lt7TBZYaUuiZed/nzcG7bpzk84oW619ASYGIMcPqhJgZM26aYE7eypaXGPJPA== X-Received: by 2002:a17:90a:d42:b0:246:f8a8:af02 with SMTP id 2-20020a17090a0d4200b00246f8a8af02mr3727377pju.5.1681931489988; Wed, 19 Apr 2023 12:11:29 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id d23-20020a17090ad3d700b0023440af7aafsm1749731pjw.9.2023.04.19.12.11.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Apr 2023 12:11:29 -0700 (PDT) In-Reply-To: <83jzycb5we.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.500.231) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260292 Archived-At: > On Apr 16, 2023, at 1:14 AM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Sat, 15 Apr 2023 22:37:02 -0700 >> Cc: 62825@debbugs.gnu.org, >> theo@thornhill.no >>=20 >>=20 >> Eli Zaretskii writes: >>=20 >>> Thanks. But I wonder why do we need the c-ts-mode-emacs-devel knob. >>> Why not recognize DEFUN by default everywhere? CC Mode does that, >>> AFAIK, so why shouldn't c-ts-mode do the same? >>=20 >> I just thought the fix is a bit hacky, and does add some overhead, so >> people who don=E2=80=99t need it might not be happy to know that they = can=E2=80=99t turn >> it off. >=20 > OK, but I made it into a defcustom and turned this on by default. I > also renamed a few symbols, please take a look. Thanks. >=20 > Btw, should the code you added to c-ts-mode--defun-name recognize > DEFUN nodes only when this variable is non-nil? I don=E2=80=99t think it=E2=80=99s necessary, we only need to inhibit = creating DEFUN nodes when the feature is turned-off, ie, we only need to = control the entry points.=20 Yuan=