From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: tsuucat via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#23412: 25.1.50; GUI Emacs on Mac OS X: text is keeping shaking/re-displaying when insert text with external input method Date: Thu, 19 Dec 2019 00:55:25 +0900 Message-ID: References: <20191217202837.GA18094@breton.holly.idiocy.org> Reply-To: tsuucat Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Content-Type: multipart/alternative; boundary="Apple-Mail=_F453CB85-CE7A-4D54-9D51-8FBB8CAB775F" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="81544"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 23412@debbugs.gnu.org To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 18 17:54:37 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ihcar-000L4g-14 for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Dec 2019 17:54:37 +0100 Original-Received: from localhost ([::1]:57310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihcap-0005kY-Ke for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Dec 2019 11:54:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40422) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihcZL-0003Zf-4A for bug-gnu-emacs@gnu.org; Wed, 18 Dec 2019 11:53:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihcZK-0002Sh-22 for bug-gnu-emacs@gnu.org; Wed, 18 Dec 2019 11:53:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37876) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ihcZJ-0002Qh-Pc for bug-gnu-emacs@gnu.org; Wed, 18 Dec 2019 11:53:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ihcZJ-0006VR-P5 for bug-gnu-emacs@gnu.org; Wed, 18 Dec 2019 11:53:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: tsuucat Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Dec 2019 16:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23412 X-GNU-PR-Package: emacs Original-Received: via spool by 23412-submit@debbugs.gnu.org id=B23412.157668797224992 (code B ref 23412); Wed, 18 Dec 2019 16:53:01 +0000 Original-Received: (at 23412) by debbugs.gnu.org; 18 Dec 2019 16:52:52 +0000 Original-Received: from localhost ([127.0.0.1]:43849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihcZ9-0006V1-FX for submit@debbugs.gnu.org; Wed, 18 Dec 2019 11:52:52 -0500 Original-Received: from pv50p00im-zteg10021401.me.com ([17.58.6.47]:60309) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihbfi-00052i-IK for 23412@debbugs.gnu.org; Wed, 18 Dec 2019 10:55:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1576684528; bh=ZF30AKdCDsT6/95Y8zetg4rU99qptFTxYjQzfqWChbY=; h=From:Message-Id:Content-Type:Subject:Date:To; b=BFLW8McjFAUnQj8S0JXaD+t/3WZ0kiSWKayFMsKDlv9JQThcnEXf7pHrAxoQ46Rf5 17snOfCppz+SeJAa5pDyoZrgVkC81anP0ZVDRnudZsOBiwana05G6ROYq5OK8MwOmD 4UKQn/2E5mGuUuocsYywv/d0PNjGOG/2rUF0uN0mh7fM7gsM6PKamwHOyWmTO98fPB ngNKiyWuix0ruFtRd/Gucqn6sXV03AZwM1ZT26wdT0tNbB/0+8tiwgHYqXW3fU2kCA 73VbcR2/8yULn0owkN3rOjjSlMvMx94YAJjgOQwBpaMfBoFTKlYON5LuIu5eplLrAS E0g/FaMCxxPhQ== Original-Received: from [192.168.129.33] (i220-109-150-92.s41.a008.ap.plala.or.jp [220.109.150.92]) by pv50p00im-zteg10021401.me.com (Postfix) with ESMTPSA id 09D8E480F45; Wed, 18 Dec 2019 15:55:27 +0000 (UTC) In-Reply-To: <20191217202837.GA18094@breton.holly.idiocy.org> X-Mailer: Apple Mail (2.3445.104.11) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-12-18_04:, , signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 mlxscore=0 mlxlogscore=686 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1912180131 X-Mailman-Approved-At: Wed, 18 Dec 2019 11:52:49 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173524 Archived-At: --Apple-Mail=_F453CB85-CE7A-4D54-9D51-8FBB8CAB775F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > I had a quick look to see if I could see any way to sort it in the NS > specific code but couldn=E2=80=99t see anything and haven=E2=80=99t = really had a > chance to dig more deeply. Thanks. I made another patch. Unlike = before this is NS = specific version. -- tsuucat= --Apple-Mail=_F453CB85-CE7A-4D54-9D51-8FBB8CAB775F Content-Type: multipart/mixed; boundary="Apple-Mail=_5F92025B-0DD5-4256-9DA8-3807883A7134" --Apple-Mail=_5F92025B-0DD5-4256-9DA8-3807883A7134 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

I had a quick look to see if I could see any = way to sort it in the NS
specific code but couldn=E2=80=99t = see anything and haven=E2=80=99t really had a
chance to = dig more deeply.

Thanks.

I made = another patch. Unlike before = this is NS specific version.

= --Apple-Mail=_5F92025B-0DD5-4256-9DA8-3807883A7134 Content-Disposition: attachment; filename=0001-delete-workingText-last-in-insertText.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-delete-workingText-last-in-insertText.patch" Content-Transfer-Encoding: quoted-printable =46rom=20b163b00624ef3fa5cc3a31d62cdb12714cd6831f=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Masahiro=20Nakamura=20=0A= Date:=20Thu,=2019=20Dec=202019=2000:32:54=20+0900=0ASubject:=20[PATCH]=20= delete=20workingText=20last=20in=20insertText=0A=0A---=0A=20= lisp/term/ns-win.el=20|=203=20+--=0A=20src/nsterm.m=20=20=20=20=20=20=20=20= |=208=20++++----=0A=202=20files=20changed,=205=20insertions(+),=206=20= deletions(-)=0A=0Adiff=20--git=20a/lisp/term/ns-win.el=20= b/lisp/term/ns-win.el=0Aindex=201841e67..1cbe566=20100644=0A---=20= a/lisp/term/ns-win.el=0A+++=20b/lisp/term/ns-win.el=0A@@=20-317,8=20= +317,7=20@@=20ns-insert-working-text=0A=20=20=20(ns-delete-working-text)=0A= =20=20=20(let=20((start=20(point)))=0A=20=20=20=20=20(insert=20= ns-working-text)=0A-=20=20=20=20(overlay-put=20(setq=20= ns-working-overlay=20(make-overlay=20start=20(point)=0A-=09=09=09=09=09=09= =09(current-buffer)=20nil=20t))=0A+=20=20=20=20(overlay-put=20(setq=20= ns-working-overlay=20(make-overlay=20start=20(point)))=0A=20=09=09=20= 'face=20'ns-working-text-face)))=0A=20=0A=20(defun=20= ns-echo-working-text=20()=0Adiff=20--git=20a/src/nsterm.m=20= b/src/nsterm.m=0Aindex=2052a9830..c5cc182=20100644=0A---=20= a/src/nsterm.m=0A+++=20b/src/nsterm.m=0A@@=20-6430,10=20+6430,6=20@@=20-=20= (void)insertText:=20(id)aString=0A=20=20=20if=20(!emacs_event)=0A=20=20=20= =20=20return;=0A=20=0A-=20=20/*=20First,=20clear=20any=20working=20text.=20= =20*/=0A-=20=20if=20(workingText=20!=3D=20nil)=0A-=20=20=20=20[self=20= deleteWorkingText];=0A-=0A=20=20=20/*=20It=20might=20be=20preferable=20= to=20use=20getCharacters:range:=20below,=0A=20=20=20=20=20=20cf.=20= https://developer.apple.com/library/content/documentation/Cocoa/Conceptual= /CocoaPerformance/Articles/StringDrawing.html#//apple_ref/doc/uid/TP400014= 45-112378.=0A=20=20=20=20=20=20However,=20we=20probably=20can't=20use=20= SAFE_NALLOCA=20here=20because=20it=20might=0A@@=20-6462,6=20+6458,10=20= @@=20-=20(void)insertText:=20(id)aString=0A=20=20=20=20=20=20=20= emacs_event->code=20=3D=20code;=0A=20=20=20=20=20=20=20EV_TRAILER=20= ((id)nil);=0A=20=20=20=20=20}=0A+=0A+=20=20/*=20Last,=20clear=20any=20= working=20text.=20=20*/=0A+=20=20if=20(workingText=20!=3D=20nil)=0A+=20=20= =20=20[self=20deleteWorkingText];=0A=20}=0A=20=0A=20=0A--=20=0A2.21.0=0A=0A= --Apple-Mail=_5F92025B-0DD5-4256-9DA8-3807883A7134 Content-Transfer-Encoding: 7bit Content-Type: text/html; charset=us-ascii
--
tsuucat
--Apple-Mail=_5F92025B-0DD5-4256-9DA8-3807883A7134-- --Apple-Mail=_F453CB85-CE7A-4D54-9D51-8FBB8CAB775F--