From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#48902: 28.0.50; Directory names containing apostrophes and backticks cause problems Date: Tue, 8 Jun 2021 19:45:22 +0200 Message-ID: References: <51cb-60bf4900-1dd-2840bc80@23790836> <875yyoo9gy.fsf@gnus.org> <87r1hcmu2q.fsf@gnus.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10000"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48902@debbugs.gnu.org, Alan Third , Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= , naofumi@yasufuku.dev To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 08 19:46:41 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lqfoF-0002Iz-UQ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Jun 2021 19:46:39 +0200 Original-Received: from localhost ([::1]:59560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqfoE-0002Ny-Jm for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Jun 2021 13:46:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49970) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqfno-0002Mw-Pg for bug-gnu-emacs@gnu.org; Tue, 08 Jun 2021 13:46:15 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48180) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lqfne-0001zq-Bc for bug-gnu-emacs@gnu.org; Tue, 08 Jun 2021 13:46:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lqfne-0001iG-9b for bug-gnu-emacs@gnu.org; Tue, 08 Jun 2021 13:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Jun 2021 17:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48902 X-GNU-PR-Package: emacs Original-Received: via spool by 48902-submit@debbugs.gnu.org id=B48902.16231743476533 (code B ref 48902); Tue, 08 Jun 2021 17:46:02 +0000 Original-Received: (at 48902) by debbugs.gnu.org; 8 Jun 2021 17:45:47 +0000 Original-Received: from localhost ([127.0.0.1]:59720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqfnL-0001hF-Aw for submit@debbugs.gnu.org; Tue, 08 Jun 2021 13:45:47 -0400 Original-Received: from mail70c50.megamailservers.eu ([91.136.10.80]:33784) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqfnF-0001gz-B3 for 48902@debbugs.gnu.org; Tue, 08 Jun 2021 13:45:41 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1623174334; bh=uLx+rIl+rA3HfSilFY6SeRp2KQ4ZtpWaGtUkTsRQ4g0=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=c4iqKgEWbi0pRHo2vGbl0GIJt5Js8B3SyonGISIhswwxWGWwdcu7Z7ly44xpxSWUf OnKcB1H6PmvucnsppV+gOrA90lyY89HeHv2LaikQZSkWMzT3ixkTRtgJuK45I79mx6 4gv0L9Hg4oFbQlcEAn5FGe0/klyy/CZyJsgQRUpQ= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-b952e353.032-75-73746f71.bbcust.telenor.se [83.227.82.185]) (authenticated bits=0) by mail70c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 158HjNN5000671; Tue, 8 Jun 2021 17:45:30 +0000 In-Reply-To: <87r1hcmu2q.fsf@gnus.org> X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F19.60BFACBD.0057, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=G/ti7Os5 c=1 sm=1 tr=0 a=von4qPfY+hyqc0zmWf0tYQ==:117 a=von4qPfY+hyqc0zmWf0tYQ==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=OocQHUDgAAAA:8 a=iTruVrsCcesBPFVdC5gA:9 a=CjuIK1q_8ugA:10 a=xUZTl98r3Qw_uB5NK3jt:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208253 Archived-At: 8 juni 2021 kl. 14.14 skrev Lars Ingebrigtsen : >> It's always possible that stringWithLispString isn't doing the right >> thing. It's implemented at nsfns.m:3026. I know almost nothing about >> UTF8/UTF16 so while it looks like it's doing the right thing to me, I >> could be entirely wrong. >=20 > Right -- and that was written by Mattias, so I've added him to the = CCs. Thank you, but stringWithLispString: is actually fine, unless you count = its inability to produce useful results from wrong input! The image code seems to be quite confused with respect to whether the = file names being passed around are in encoded form. Until recently it = seems to have worked by pure chance since as long as the file name = encoding is UTF-8 and the low-level code accesses the raw string data we = do get the same result, but at least since 747a923b9a35 that's no longer = the case. Concretely, we have: 1. image_find_image_file probably expects its `file` argument to be = non-encoded, but the string it returns is always encoded. 2. native_image_load calls image_find_image_file and passes its return = value to ns_load_image. 3. ns_load_image calls [EmacsImage allocInitFromFile:] with its file = argument. 4. [EmacsImage allocInitFromFile: file] can apparently be called with = both a non-encoded or an encoded `file` argument (clearly not ideal), = and it does: found =3D image_find_image_file (file); // This is dubious when `file` is already encoded. found =3D ENCODE_FILE (found); // This is completely useless since `found` is already encoded! = Apparently ENCODE_FILE is idempotent, at least on macOS... [NSString stringWithLispString: found] // This produces nonsense as `found` is a string of raw bytes, so any = Unicode will be converted to stretches of U+FFFD REPLACEMENT CHAR. [NSString stringWithLispString: file] // Same problem again, with a different variable. The quick fix of reverting to stringWithUTF8String: will work, but the = real problem is that we have no control of the encodedness of lisp = strings being passed around. Comments would help, and I'd even go as far = to suggest typedef struct { Lisp_Object string; } encoded_file_name_t; with the appropriate constructors and accessors, to get C's static type = checking to work for us.