From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Newsgroups: gmane.emacs.bugs Subject: bug#56553: 29.0.50; ASAN error with fringe bitmaps on NS Date: Fri, 15 Jul 2022 17:10:18 +0200 Message-ID: References: <83cze7u7b7.fsf@gnu.org> <8569ECF9-6D19-4DCB-854C-2755D182F8AF@gmail.com> <8335f3tz02.fsf@gnu.org> <87cze6okcy.fsf@yahoo.com> <87ilny4eo4.fsf@igel.home> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28640"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , 56553@debbugs.gnu.org, Eli Zaretskii To: Andreas Schwab Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 15 17:11:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oCMyE-0007FG-L5 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Jul 2022 17:11:10 +0200 Original-Received: from localhost ([::1]:49940 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oCMyD-00070H-AG for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Jul 2022 11:11:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44548) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCMy6-000709-LE for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2022 11:11:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44231) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oCMy6-0007wC-C1 for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2022 11:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oCMy6-0004IA-5t for bug-gnu-emacs@gnu.org; Fri, 15 Jul 2022 11:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Jul 2022 15:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56553 X-GNU-PR-Package: emacs Original-Received: via spool by 56553-submit@debbugs.gnu.org id=B56553.165789783616464 (code B ref 56553); Fri, 15 Jul 2022 15:11:02 +0000 Original-Received: (at 56553) by debbugs.gnu.org; 15 Jul 2022 15:10:36 +0000 Original-Received: from localhost ([127.0.0.1]:41990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCMxc-0004HK-Se for submit@debbugs.gnu.org; Fri, 15 Jul 2022 11:10:36 -0400 Original-Received: from mail-ed1-f48.google.com ([209.85.208.48]:45676) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCMxX-0004Gs-PR for 56553@debbugs.gnu.org; Fri, 15 Jul 2022 11:10:31 -0400 Original-Received: by mail-ed1-f48.google.com with SMTP id g1so6649556edb.12 for <56553@debbugs.gnu.org>; Fri, 15 Jul 2022 08:10:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Y1+4J8XVVZlzeZ/OCEJHnxQIS+TEdt84T5sD91JeHzQ=; b=qRTSH3sPBp9s4yEfbc09eynliR89gVncpCRYEauiGY4M2aLVN1BUTixUXqTHugXoiI Vr2oULX+N8YHqZTi06jlkyWbYAo9CsKJEI15zLrIOmKYSY/UCvjBx8H558xwbMYdgoT9 mChP/FfMP7iPiTzacHXVs/h9izHc/2r0X5gU7HDn79uQV87+hvRSSoPSz/nTNnmvunt5 zGADmCORCpP2rPN7NoudMbDF+KWfKwvs5vwVeaX8LJWbaBPApt26vEdGg7Alwh3p2EbD NL4aCStwqyaFi7D+enf1LW3pqGU81CRYfu6zvYxvgXEC+jVwtZBTdB65rWEsaNKkee8L GgGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Y1+4J8XVVZlzeZ/OCEJHnxQIS+TEdt84T5sD91JeHzQ=; b=qQpotXTdG2y2VIbd2PB2A/bbOeOiPRD8OYsfFVuJqacZBultdL63cecjpamYdlz1E3 yW92eRsNu+l4+7uxouRWEYKhlkKCHts14Cr9acryjDl2XarUvOpp8UdcZPM+r2dpBIZ6 N5zw9ceKHDHHxoCud3f3eIvzxipJlzGIkvOF1SIZ4zxrsHimkiEMV6VEIGk1bcApStBN lu21qeeKTukIUu6zF2/6GWx4h444x8o3iT9ZPG6E5awSDGxKilPVE7zwxqtEl2R01jLQ 3pp/jAWKHb4dsEslbV8hB5BTfCo27pr3BdyVuN3l0N3feDPQcbNjxs0tnFB1MRy/Yo4M FXWA== X-Gm-Message-State: AJIora8TZudMBI2PrwzN0qFLyRp4m0A4vCt2llO+J2btHoQRsTV8CAAy ujHqpXPPNLY3ATn617jAwFo= X-Google-Smtp-Source: AGRyM1vFLJTwa35DQU5uHc87ZCQZDKGH/jbWY1+IpnR+Ssmh2qPSc/zMebeJpMoYbADjvatw10ve7g== X-Received: by 2002:a05:6402:3785:b0:435:5d0e:2a2e with SMTP id et5-20020a056402378500b004355d0e2a2emr20097563edb.307.1657897820871; Fri, 15 Jul 2022 08:10:20 -0700 (PDT) Original-Received: from smtpclient.apple (pd9e368e5.dip0.t-ipconnect.de. [217.227.104.229]) by smtp.gmail.com with ESMTPSA id qx21-20020a170906fcd500b0072abb95c9f4sm2107774ejb.193.2022.07.15.08.10.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Jul 2022 08:10:19 -0700 (PDT) In-Reply-To: <87ilny4eo4.fsf@igel.home> X-Mailer: Apple Mail (2.3696.100.31) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237111 Archived-At: > On 2022-07-15,, at 16:46 , Andreas Schwab wrote: > > Does this work? > > diff --git a/src/nsterm.m b/src/nsterm.m > index 8e0c4b84f0..30768baced 100644 > --- a/src/nsterm.m > +++ b/src/nsterm.m > @@ -2900,10 +2900,7 @@ Hide the window (X11 semantics) > for (int y = 0 ; y < h ; y++) > for (int x = 0 ; x < w ; x++) > { > - /* XBM rows are always round numbers of bytes, with any unused > - bits ignored. */ > - int byte = y * (w/8 + (w%8 ? 1 : 0)) + x/8; > - bool bit = bits[byte] & (0x80 >> x%8); > + bool bit = bits[y] & (1 << (w - x - 1)); > if (bit) > [p appendBezierPathWithRect:NSMakeRect (x, y, 1, 1)]; > } > It does indeed. Thanks!