unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Gerd Möllmann" <gerd.moellmann@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Po Lu <luangruo@yahoo.com>,
	56553@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#56553: 29.0.50; ASAN error with fringe bitmaps on NS
Date: Fri, 15 Jul 2022 17:10:18 +0200	[thread overview]
Message-ID: <ECAD1E29-8CE7-48E6-9E0F-85584B8E2C25@gmail.com> (raw)
In-Reply-To: <87ilny4eo4.fsf@igel.home>



> On 2022-07-15,, at 16:46 , Andreas Schwab <schwab@linux-m68k.org> wrote:
> 
> Does this work?
> 
> diff --git a/src/nsterm.m b/src/nsterm.m
> index 8e0c4b84f0..30768baced 100644
> --- a/src/nsterm.m
> +++ b/src/nsterm.m
> @@ -2900,10 +2900,7 @@ Hide the window (X11 semantics)
>   for (int y = 0 ; y < h ; y++)
>     for (int x = 0 ; x < w ; x++)
>       {
> -        /* XBM rows are always round numbers of bytes, with any unused
> -           bits ignored.  */
> -        int byte = y * (w/8 + (w%8 ? 1 : 0)) + x/8;
> -        bool bit = bits[byte] & (0x80 >> x%8);
> +        bool bit = bits[y] & (1 << (w - x - 1));
>         if (bit)
>           [p appendBezierPathWithRect:NSMakeRect (x, y, 1, 1)];
>       }
> 

It does indeed.  Thanks!






  reply	other threads:[~2022-07-15 15:10 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-14 13:03 bug#56553: 29.0.50; ASAN error with fringe bitmaps on NS Gerd Möllmann
2022-07-14 13:56 ` Eli Zaretskii
2022-07-14 14:18   ` Gerd Möllmann
2022-07-14 14:34     ` Gerd Möllmann
2022-07-14 16:55       ` Eli Zaretskii
2022-07-14 18:25         ` Gerd Möllmann
2022-07-15  8:23           ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-15  9:14             ` Gerd Möllmann
2022-07-15 10:37               ` Eli Zaretskii
2022-07-15 13:55                 ` Gerd Möllmann
2022-07-15 13:57                   ` Robert Pluim
2022-07-15 14:26                     ` Eli Zaretskii
2022-07-15 14:46               ` Andreas Schwab
2022-07-15 15:10                 ` Gerd Möllmann [this message]
2022-07-15 15:16                   ` Gerd Möllmann
2022-07-16  7:16                     ` Gerd Möllmann
2022-07-15 15:32                   ` Andreas Schwab
2022-07-15 10:35             ` Eli Zaretskii
2022-07-15 10:37               ` Gerd Möllmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ECAD1E29-8CE7-48E6-9E0F-85584B8E2C25@gmail.com \
    --to=gerd.moellmann@gmail.com \
    --cc=56553@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).