From: Adrian Robert <adrian.b.robert@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Philipp Stephani <p.stephani2@gmail.com>, 19977@debbugs.gnu.org
Subject: bug#19977: 24.4; Incorrect translation of Super modifier with Ctrl or Meta on OS X
Date: Tue, 29 Mar 2016 20:19:23 +0300 [thread overview]
Message-ID: <EAF8D4DC-8FF8-4CF7-AC15-914ADD3DD84C@gmail.com> (raw)
In-Reply-To: <83d1qdw7bt.fsf@gnu.org>
On 2016.3.29, at 19:57, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Philipp Stephani <p.stephani2@gmail.com>
>> Date: Tue, 29 Mar 2016 16:38:52 +0000
>> Cc: 19977@debbugs.gnu.org
>>
>> If I comment out the if block below the comment
>>
>> /* if super (default), take input manager's word so things like
>> dvorak / qwerty layout work */
>>
>> in nsterm.m, everything works. Unless somebody can explain why that if block exists at all (i.e. why
>> [theEvent characters] instead of [theEvent charactersIgnoringModifiers] is used), then I'd suggest to
>> remove the block completely.
>>
>> Attached a patch to remove this code.
>
> Adrian, any comments? It's your code from 7 years ago.
Heh, well of the top of my head… ;-)
Did you try testing Dvorak / Qwerty layout? If not, that’s under System Preferences, Keyboard, add new, English, select Dvorak or Dvorak / Qwerty.
From what I remember, the issue had to do with cmd-key shortcuts when one of those layouts was in use. I think users were expecting the letter reported for the cmd shortcut to either agree with or disagree with the dvorak layout. Using [theEvent characters] caused it to use what they were expecting.
It sounds like either this wasn’t the right solution, or user expectations vary. In either case I would agree with simplifying the code and removing the part you suggest.
-Adrian
next prev parent reply other threads:[~2016-03-29 17:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-01 16:36 bug#19977: 24.4; Incorrect translation of Super modifier with Ctrl or Meta on OS X Philipp Stephani
2016-03-29 10:17 ` Philipp Stephani
2016-03-29 15:10 ` Eli Zaretskii
2016-03-29 15:29 ` Philipp Stephani
2016-03-29 15:45 ` Philipp Stephani
2016-03-29 15:59 ` Eli Zaretskii
2016-03-29 16:31 ` Philipp Stephani
2016-03-29 16:38 ` Philipp Stephani
2016-03-29 16:57 ` Eli Zaretskii
2016-03-29 17:19 ` Adrian Robert [this message]
2016-03-29 17:44 ` Philipp Stephani
2016-03-29 17:56 ` Adrian Robert
2016-03-29 19:43 ` Philipp Stephani
2016-03-29 20:07 ` Philipp Stephani
2016-03-30 2:39 ` Eli Zaretskii
2016-03-30 17:35 ` Philipp Stephani
2017-12-26 17:42 ` Alan Third
2017-12-26 20:14 ` Philipp Stephani
2017-12-26 21:16 ` Alan Third
2018-02-04 19:07 ` Philipp Stephani
2018-02-04 20:18 ` Alan Third
2018-02-05 8:02 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EAF8D4DC-8FF8-4CF7-AC15-914ADD3DD84C@gmail.com \
--to=adrian.b.robert@gmail.com \
--cc=19977@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).