From: "Drew Adams" <drew.adams@oracle.com>
To: "'Lars Magne Ingebrigtsen'" <larsi@gnus.org>
Cc: 2030@debbugs.gnu.org
Subject: bug#2030: 23.0.60; doc string of dired-guess-shell-alist-user
Date: Mon, 11 Jul 2011 08:19:42 -0700 [thread overview]
Message-ID: <EAD1EDC08E5F4050879F684C80F47AEB@us.oracle.com> (raw)
In-Reply-To: <m3hb6tylkr.fsf@quimbies.gnus.org>
Lars, you marked this bug `fixed', but it seems that it was hardly addressed
(partly addressed). Please take another look at it.
> > The doc string should suggest that users use Customize. It
> > should not use a complex `setq' example as its only illustration:
Note: _only_.
> > (setq dired-guess-shell-alist-user
> > (list (list "\\.foo\\'" "FOO-COMMAND");; fixed rule
> > ;; possibly more rules ...
> > (list "\\.bar\'";; rule with condition test
> > '(if condition
> > "BAR-COMMAND-1"
> > "BAR-COMMAND-2"))))
>
> I think complicated variables are best served with non-Customize
> examples.
It's OK to have a code example, if that helps make things clear.
And yes, it's not obvious how to _show_ Customize in the doc. But that's not
what I suggested. The "doc string should suggest that users use Customize."
That's the point.
It is one thing to say that _showing_ Customize in the doc is not easy and
probably not worth it. It is another thing that the doc _only_ suggest to users
to use `setq'.
And even for a code example it would be better to use `customize-save-variable'
instead of `setq'. We should generally encourage this practice, since for many
user options it makes a difference:
If VARIABLE has a `custom-set' property, that is used for setting
VARIABLE, otherwise `set-default' is used.
If VARIABLE has a `variable-interactive' property, that is used as if
it were the arg to `interactive' (which see) to interactively read the value.
If VARIABLE has a `custom-type' property, it must be a widget and the
`:prompt-value' property of that widget will be used for reading the value.
> I've rewritten it to use a quote instead of all the `list' operations,
> which should make it clearer.
That's fine, but it does not respond to the bug report at all - it's something
else.
Please suggest to users that they use Customize. It's about the users, not our
ease in writing the doc and its examples. I agree that it is not easy or
worthwhile to show an illustration of Customize here. But we should
nevertheless suggest using Customize first, and show a code example only second,
if important, as a way to code things by hand.
> > If it's felt that an example of a _value_ for this option is needed,
> > then it's OK to show that directly:
> >
> > (("\\.foo\\'" "foo-command") ; unconditional rule
> > ("\\.bar\\'" ; conditional rule
> > (if (some-sexp) "bar-command-1" "bar-command-2")))
> >
> > But there is absolutely no reason to show setting the value using
> > `setq', especially since the expression evaluated by `setq' is 100%
> > constant.
>
> I disagree. A complete `setq' is convenient to cut and paste.
That's not something we necessarily want to encourage. Customize is much to be
preferred when it is appropriate. It is safer, does type-checking, etc.
It's not because some of us find the Customize UI to be ugly that we should not
encourage its use.
What's important for the illustration is what a value looks like. I recommend
that we (a) remove `setq', (2) not bother with `customize-save-variable', but
(3) show the example _value_, as I wrote initially.
next prev parent reply other threads:[~2011-07-11 15:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-24 19:09 bug#2030: 23.0.60; doc string of dired-guess-shell-alist-user Drew Adams
2011-07-11 13:48 ` Lars Magne Ingebrigtsen
2011-07-11 15:19 ` Drew Adams [this message]
2011-07-11 15:21 ` Lars Magne Ingebrigtsen
2011-07-11 16:03 ` Drew Adams
2011-07-16 18:35 ` Lars Magne Ingebrigtsen
2011-07-16 23:21 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EAD1EDC08E5F4050879F684C80F47AEB@us.oracle.com \
--to=drew.adams@oracle.com \
--cc=2030@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).