From: Yuan Fu <casouri@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Dmitry Gutov <dmitry@gutov.dev>, 71562@debbugs.gnu.org, sb@dod.no
Subject: bug#71562: treesit-install-language-grammar fails to install typescript
Date: Tue, 18 Jun 2024 23:33:50 -0700 [thread overview]
Message-ID: <EAC61EBC-C162-4F62-A3E3-1243ADDAACE0@gmail.com> (raw)
In-Reply-To: <86v829sc18.fsf@gnu.org>
> On Jun 15, 2024, at 10:16 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> Date: Sat, 15 Jun 2024 22:30:25 +0300
>> Cc: sb@dod.no, 71562@debbugs.gnu.org
>> From: Dmitry Gutov <dmitry@gutov.dev>
>>
>> On 15/06/2024 09:31, Eli Zaretskii wrote:
>>> We could look for directories names 'src' which have either parser.c
>>> or parser.cc, and take it from there, instead of hard-coding the place
>>> of the 'src' directory in the hierarchy.
>>
>> In the present case we have two problems:
>>
>> * https://github.com/tree-sitter/tree-sitter-typescript/ contains two
>> different files called parser.c in two different subdirectories (in
>> typescript/src and tsx/src).
>>
>> * The repository for the 'tsx' grammar does not match the common scheme
>> - instead it's the same repository as for 'typescript'.
>
> I'm saying that we should run the build commands in every subdirectory
> called 'src' that has parser.c or parser.cc in it. Each shared
> library thus created should be installed. The name of the library is
> derived from the parent of the 'src' subdirectory.
treesit-install-language-grammar works fine if you pass “typescript/src” instead of the default “src” to it, for the third argument, so I don’t think there’s anything to fix here. Installing multiple things “smartly” might be more confusing and error-prone than helpful, IMO.
For reference, the recipe for typescript is
(typescript "https://github.com/tree-sitter/tree-sitter-typescript” nil "typescript/src" nil nil)
Yuan
next prev parent reply other threads:[~2024-06-19 6:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 18:18 bug#71562: treesit-install-language-grammar fails to install typescript Steinar Bang
2024-06-14 22:18 ` Dmitry Gutov
2024-06-15 6:31 ` Eli Zaretskii
2024-06-15 19:30 ` Dmitry Gutov
2024-06-16 5:16 ` Eli Zaretskii
2024-06-19 6:33 ` Yuan Fu [this message]
2024-06-19 18:51 ` Steinar Bang
2024-06-19 19:14 ` Eli Zaretskii
2024-06-19 19:51 ` Dmitry Gutov
2024-06-20 4:54 ` Eli Zaretskii
2024-06-20 10:28 ` Dmitry Gutov
2024-06-20 10:45 ` Eli Zaretskii
2024-06-20 11:18 ` Dmitry Gutov
2024-06-20 11:31 ` Eli Zaretskii
2024-06-20 15:03 ` Dmitry Gutov
2024-06-20 15:59 ` Eli Zaretskii
2024-06-20 16:08 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EAC61EBC-C162-4F62-A3E3-1243ADDAACE0@gmail.com \
--to=casouri@gmail.com \
--cc=71562@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=eliz@gnu.org \
--cc=sb@dod.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).