From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daan Ro Newsgroups: gmane.emacs.bugs Subject: bug#74412: 31.0.50; Treesit-outline conflict with outli in Emacs 31 Date: Thu, 21 Nov 2024 00:51:12 +0700 Message-ID: References: <87serlzuvi.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="673e2190_3c0d46b_921" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30506"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "74412@debbugs.gnu.org" <74412@debbugs.gnu.org>, "liaotx2@gmail.com" To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 20 18:53:31 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tDotM-0007lx-Rf for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Nov 2024 18:53:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tDosy-0008VT-H5; Wed, 20 Nov 2024 12:53:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tDosw-0008VI-Qy for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2024 12:53:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tDosw-0002ZT-J1 for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2024 12:53:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:From:Date:To:Subject; bh=v3j/5nfqWVInVlh6C6KJWMmVwYOYX8N1ySbomI3DcoE=; b=q/WTeGXjNKgai4FENYU+w4DuJgGFNnI/HCbWZn7MIrSvNCyZHJFXv3mr+RgK1M4NkL+V3nNfeMCT52dEh9eofs6DWlNFY0G8zZ9KOmwBfusezWtaRdh9wLc+QUBAN6UDaq93FwkvRfl5iFCSGsM3bKSJLFCStdpp3Wt0WvYE//x8Nc84FZIyu1/1FmXet+O2II5v9XQ1TErepUIWVCA4N6C5UmUlJ/qRSFqXeTDdMDLHkLb0B39bVewvZFb7w86mLNN9MSNt9L+FhnBm9iFhDpD6eXcvGwOxEIA/+ywv0pLGbpGDWvXXda5fb1oAZS1Tl14HqpAISVb3DZPXRmkgKg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tDosw-0008PV-3d for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2024 12:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daan Ro Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Nov 2024 17:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74412 X-GNU-PR-Package: emacs Original-Received: via spool by 74412-submit@debbugs.gnu.org id=B74412.173212514332277 (code B ref 74412); Wed, 20 Nov 2024 17:53:02 +0000 Original-Received: (at 74412) by debbugs.gnu.org; 20 Nov 2024 17:52:23 +0000 Original-Received: from localhost ([127.0.0.1]:47673 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDosI-0008OX-Ss for submit@debbugs.gnu.org; Wed, 20 Nov 2024 12:52:23 -0500 Original-Received: from mail-pl1-f175.google.com ([209.85.214.175]:55472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDosG-0008OO-Lc for 74412@debbugs.gnu.org; Wed, 20 Nov 2024 12:52:21 -0500 Original-Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-21207f0d949so45392485ad.2 for <74412@debbugs.gnu.org>; Wed, 20 Nov 2024 09:52:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732125079; x=1732729879; darn=debbugs.gnu.org; h=mime-version:subject:references:in-reply-to:message-id:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=v3j/5nfqWVInVlh6C6KJWMmVwYOYX8N1ySbomI3DcoE=; b=HWQujYTynjyTdH/7Crd3vCQUGtx+aJOp+MCKjWX5X6Zj2fswf+nE/ryWUuDl/0U2Hy DoyDhM0/76aKh8gAt/sYHANeL11Xv3KUHAgc9qizBrK4UxIVgu68IEiV6Wpu7yVsGCCu aADfh4hCWC8/eAJnsnr+RL0zF1AVOZZqHxH0H35lex8IrV9OrnZDKd6WrfM6RVkoznJq JbryB0KjP+smVz6kJiUoS9ujwclCW4QxgGZtHAy7+nA8p2rSq8/hCtH/ro//zvMwo/Wh UMn58c4UA2RFV/PDSHaXDrW/nMijDzTMicbxXajdffVRekCjWVlaAPtCVqNiZUNHs+ng UKbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732125079; x=1732729879; h=mime-version:subject:references:in-reply-to:message-id:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=v3j/5nfqWVInVlh6C6KJWMmVwYOYX8N1ySbomI3DcoE=; b=fUETCZoTugp7/+ghweEat9A69WXoTPurDCbGirb6kcKv6O+qrduIP9TyF/MhNneAfM AV3hu4jjzvpRRDKoWIkgLqQcUdXmqABEbpQzsMNiIJZtx956zPsu2DKuOsuBB8nNnPw9 1IANy0aw+vhOVQWX0lrRtj9z9/YG95RhoEDa2AokBGn4NvgLiyKkj4q6IvSQ32WceoyM GDl2LMjPSF5MGLePgt9eSdFi1sZhywG9QV3WYzM8LxDMXN0Pn9pFbdVbpDaM0W/6qehX Je6nKh1PWEQyUtmGASd5UxROKQ8P7bNkGsiEkD4Y+89Oxu/JRoUz2MAZCPh34wXm+SgR n0DQ== X-Forwarded-Encrypted: i=1; AJvYcCX1Bd259YmQ/9wpegPxugNz0RNSIwFSq2XQ0tbb9HJZpPJA8ooB/uf5O69rDQySQLIhpvhWAA==@debbugs.gnu.org X-Gm-Message-State: AOJu0Ywq0Pasr67LUrDlfK0+Xhz/gA8oxDgYD76kwm5wwg60ltfdgOCa 4PmTmKrx3GjcVo2IZPfUFhHNdA+SeicK5mnRpqYIx91rD26Z4YywpQ2Af2QmfAg= X-Gm-Gg: ASbGnctZz0XNVpo7VfDKwKSbhLtKWBYQDDly58sj3cN/gxSZ3rqu5YTXwEFXz0Bf3fm to/BfEMNEAEo2cnJVN4yzLMCMg1tJ2ecN2JSSG7P9IflVUp/ohU7wGax1i08hQ23I8MPA0f7N4v 0SEJDt5oxJ1FLJuhArXH00Oc8eelWYWh/X8mpBvMUIbuQR3NDuyv7W1JlxTfsy+xV3UuEWS7jNx CNGFZe29cpHokcTccVA6g3PuYfDZdJ+3uPC+T8cp5N+w0XYiA== X-Google-Smtp-Source: AGHT+IFgqekMId2ZV1iun1TswEyyPtS77UftHQPXJOei5NrZTp+DaBe5R0ueWsXqi8laOxIiBYkGVg== X-Received: by 2002:a17:902:e84c:b0:20c:6399:d637 with SMTP id d9443c01a7336-2126fd8e088mr40654095ad.40.1732125079338; Wed, 20 Nov 2024 09:51:19 -0800 (PST) Original-Received: from dan-laptop ([2405:4802:bfff:6f10:4e7e:a8aa:eff7:d8f]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21263c9b946sm21786995ad.262.2024.11.20.09.51.18 for <74412@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Nov 2024 09:51:18 -0800 (PST) In-Reply-To: <87serlzuvi.fsf@mail.linkov.net> X-Mailer: Mailspring X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295687 Archived-At: --673e2190_3c0d46b_921 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline > So a new option could have a similar name, e.g. > 'treesit-disable-features' that the users could set to e.g. > > (setopt treesit-disable-features '(outline imenu)) That's much better, indeed. Daanturo On Nov 21 2024, at 12:18 am, Juri Linkov wrote: > > Personally I also find treesit's decision to set outline variables > > somewhat intrusive. I have to advice `treesit-major-mode-setup` to > > disable that. If only there is an easier way to do it like the > > attached patch. > > > > +(defcustom treesit-enable-outline-settings t > > + "Non-nil means Tree sitter-based outline settings are enabled." > > + :type 'boolean > > + :version "31.1") > > Should such an option be more general and allow > disabling some other features too? > > There is already 'treesit-font-lock-recompute-features'. > So a new option could have a similar name, e.g. > 'treesit-disable-features' that the users could set to e.g. > > (setopt treesit-disable-features '(outline imenu)) --673e2190_3c0d46b_921 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline
> So a new option could have a similar name, e.= g.
> 'treesit-disable-featur= es' that the users could set to e.g.
>
> (setopt treesit-di= sable-features '(outline imenu))

That's much better, indeed.

Daantu= ro
On Nov 21 2024, at 12:18 am, J= uri Linkov <juri=40linkov.net> wrote:
&g= t; Personally I also find treesit's decision to set outline variables
> somewhat intrusive. I have to advice =60treesit-major-mode-se= tup=60 to
> disable that. If only there is an easier way to = do it like the
> attached patch.
>
&g= t; +(defcustom treesit-enable-outline-settings t
> + =22Non-= nil means Tree sitter-based outline settings are enabled.=22
&g= t; + :type 'boolean
> + :version =2231.1=22)

S= hould such an option be more general and allow
disabling some o= ther features too=3F

There is already 'treesit-font-lock-re= compute-features'.
So a new option could have a similar name, e= .g.
'treesit-disable-features' that the users could set to e.g.=

(setopt treesit-disable-features '(outline imenu))
3D=22Sent --673e2190_3c0d46b_921--