From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#50067: Context menus Date: Fri, 20 Aug 2021 21:29:47 +0200 Message-ID: References: <74BC00E9-2509-47DA-9428-1523FF7F3B33@acm.org> <87v942pvcj.fsf@mail.linkov.net> <83zgte3asy.fsf@gnu.org> <87mtpepqzw.fsf@mail.linkov.net> <83sfz639lh.fsf@gnu.org> <8735r6ppf0.fsf@mail.linkov.net> <83o89u37gh.fsf@gnu.org> <87wnohx5zd.fsf@mail.linkov.net> <831r6p3lzc.fsf@gnu.org> <87o89sh96g.fsf@mail.linkov.net> <837dgg1hdg.fsf@gnu.org> <87mtpcf79p.fsf@mail.linkov.net> <83zgtcyp2k.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_F4AA7B89-ECDE-4EBC-A0E0-C79E2F75AAED" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24955"; mail-complaints-to="usenet@ciao.gmane.io" Cc: alan@idiocy.org, Juri Linkov , homeros.misasa@gmail.com, tkk@misasa.okayama-u.ac.jp, larsi@gnus.org, 50067@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 20 21:31:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mHAEU-0006I4-0r for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Aug 2021 21:31:14 +0200 Original-Received: from localhost ([::1]:47332 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mHAES-0004ra-Cx for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Aug 2021 15:31:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40032) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mHAEI-0004pA-Mv for bug-gnu-emacs@gnu.org; Fri, 20 Aug 2021 15:31:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52252) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mHAEI-0001O1-Ee for bug-gnu-emacs@gnu.org; Fri, 20 Aug 2021 15:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mHAEI-00079S-5G for bug-gnu-emacs@gnu.org; Fri, 20 Aug 2021 15:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Aug 2021 19:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50067 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 50067-submit@debbugs.gnu.org id=B50067.162948780427358 (code B ref 50067); Fri, 20 Aug 2021 19:31:02 +0000 Original-Received: (at 50067) by debbugs.gnu.org; 20 Aug 2021 19:30:04 +0000 Original-Received: from localhost ([127.0.0.1]:35564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mHADL-00077C-R3 for submit@debbugs.gnu.org; Fri, 20 Aug 2021 15:30:04 -0400 Original-Received: from mail1454c50.megamailservers.eu ([91.136.14.54]:50054 helo=mail266c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mHADI-00076E-QK for 50067@debbugs.gnu.org; Fri, 20 Aug 2021 15:30:02 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1629487794; bh=H+HL4DoRe1T+1qx4VYWb4kwn+C778D3Tx+JfzDfkPhU=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=iQUJxmv1gMU3VeZhA3IZZKEU70y5CkZUWCOL5osOnNkNpAIDncJbZLHZOo5Dv2EI+ PEVk5iBc8NS0AgLB9RFZgxK1dTROMOY7dgJHkarOfv1RyaFoYToabgRkLNMQmdEeIz qmVrsmghOJ64LX/oleUaAN34VtczGIKCHEEmZkFM= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail266c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 17KJTmae030582; Fri, 20 Aug 2021 19:29:50 +0000 In-Reply-To: <83zgtcyp2k.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F26.612002B2.0006, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=UeYvt5aN c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=aTpjW4tw5_cClw_LVMkA:9 a=CjuIK1q_8ugA:10 a=JUOl0zTICBLu7D2qXPMA:9 a=B2y7HmGcmWMA:10 a=tclcd6dtLQvEqt9_mmAA:9 a=_FVE-zBwftR9WsbkzFJk:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212303 Archived-At: --Apple-Mail=_F4AA7B89-ECDE-4EBC-A0E0-C79E2F75AAED Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 20 aug. 2021 kl. 19.59 skrev Eli Zaretskii : > OK, but where in that patch is the NS-specific "Select" title that > should be removed? I'm not Juri, but the following patch removes the default "Select" title = used by the NS port. Not sure why it was ever added -- perhaps something = Gnustep-specific? Works well with Cocoa in any case. --Apple-Mail=_F4AA7B89-ECDE-4EBC-A0E0-C79E2F75AAED Content-Disposition: attachment; filename=0001-Remove-default-Select-title-from-NS-popup-menus.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Remove-default-Select-title-from-NS-popup-menus.patch" Content-Transfer-Encoding: quoted-printable =46rom=20d08bba26704cbe2cd8c655279d95cfed88ff29ba=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Fri,=2020=20Aug=202021=2021:21:05=20+0200=0A= Subject:=20[PATCH]=20Remove=20default=20"Select"=20title=20from=20NS=20= popup=20menus=0A=0A*=20src/menu.c=20(x_popup_menu_1):=20Remove=20default=20= "Select"=20title.=0A*=20src/nsmenu.m=20(ns_menu_show):=20Allow=20title=20= to=20be=20absent.=0A---=0A=20src/menu.c=20=20=20|=204=20----=0A=20= src/nsmenu.m=20|=202=20+-=0A=202=20files=20changed,=201=20insertion(+),=20= 5=20deletions(-)=0A=0Adiff=20--git=20a/src/menu.c=20b/src/menu.c=0Aindex=20= 3b1d740257..e441d22ea0=20100644=0A---=20a/src/menu.c=0A+++=20= b/src/menu.c=0A@@=20-1286,10=20+1286,6=20@@=20x_popup_menu_1=20= (Lisp_Object=20position,=20Lisp_Object=20menu)=0A=20=20=20=20=20=20=20= prompt=20=3D=20Fkeymap_prompt=20(keymap);=0A=20=20=20=20=20=20=20if=20= (!NILP=20(prompt))=0A=20=09title=20=3D=20prompt;=0A-#ifdef=20HAVE_NS=09=09= /*=20Is=20that=20needed=20and=20NS-specific?=20=20--Stef=20=20*/=0A-=20=20= =20=20=20=20else=0A-=09title=20=3D=20build_string=20("Select");=0A= -#endif=0A=20=0A=20=20=20=20=20=20=20/*=20Make=20that=20be=20the=20pane=20= title=20of=20the=20first=20pane.=20=20*/=0A=20=20=20=20=20=20=20if=20= (!NILP=20(prompt)=20&&=20menu_items_n_panes=20>=3D=200)=0Adiff=20--git=20= a/src/nsmenu.m=20b/src/nsmenu.m=0Aindex=20bb0dd2634d..fe4f825832=20= 100644=0A---=20a/src/nsmenu.m=0A+++=20b/src/nsmenu.m=0A@@=20-959,7=20= +959,7=20@@=20-=20(void)menu:(NSMenu=20*)menu=20= willHighlightItem:(NSMenuItem=20*)item=0A=20=20=20=20=20}=0A=20=0A=20=20=20= pmenu=20=3D=20[[EmacsMenu=20alloc]=20initWithTitle:=0A-=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= [NSString=20stringWithLispString:=20title]];=0A+=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20NILP=20(title)=20?=20@""=20:=20[NSString=20= stringWithLispString:=20title]];=0A=20=20=20[pmenu=20= fillWithWidgetValue:=20first_wv->contents];=0A=20=20=20= free_menubar_widget_value_tree=20(first_wv);=0A=20=20=20unbind_to=20= (specpdl_count,=20Qnil);=0A--=20=0A2.21.1=20(Apple=20Git-122.3)=0A=0A= --Apple-Mail=_F4AA7B89-ECDE-4EBC-A0E0-C79E2F75AAED Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii --Apple-Mail=_F4AA7B89-ECDE-4EBC-A0E0-C79E2F75AAED--