From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#44418: 28.0.50; Spliced variable not matched as symbol in isearch Date: Sat, 24 Jun 2023 12:12:44 +0200 Message-ID: References: Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36520"; mail-complaints-to="usenet@ciao.gmane.io" Cc: contovob@tcd.ie, 44418@debbugs.gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 24 12:13:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qD0Gk-00099O-8w for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Jun 2023 12:13:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qD0GO-0006Ul-BA; Sat, 24 Jun 2023 06:13:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qD0GN-0006Ub-7U for bug-gnu-emacs@gnu.org; Sat, 24 Jun 2023 06:13:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qD0GM-0000VQ-7p for bug-gnu-emacs@gnu.org; Sat, 24 Jun 2023 06:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qD0GL-0000K1-OS for bug-gnu-emacs@gnu.org; Sat, 24 Jun 2023 06:13:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Jun 2023 10:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44418 X-GNU-PR-Package: emacs Original-Received: via spool by 44418-submit@debbugs.gnu.org id=B44418.16876015761225 (code B ref 44418); Sat, 24 Jun 2023 10:13:01 +0000 Original-Received: (at 44418) by debbugs.gnu.org; 24 Jun 2023 10:12:56 +0000 Original-Received: from localhost ([127.0.0.1]:39940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qD0GG-0000Jg-Gx for submit@debbugs.gnu.org; Sat, 24 Jun 2023 06:12:56 -0400 Original-Received: from mail-lf1-f47.google.com ([209.85.167.47]:62681) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qD0GC-0000JL-Fi for 44418@debbugs.gnu.org; Sat, 24 Jun 2023 06:12:54 -0400 Original-Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-4f8689fbf59so3242401e87.0 for <44418@debbugs.gnu.org>; Sat, 24 Jun 2023 03:12:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687601566; x=1690193566; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=PCY6Z8ZjjqUX75jOGsgTCgN/T3Q7Zc+zUfvcYuI7iHk=; b=mb96llv3OFv8tay/fb6QXi868ne18tQ9Of0eAG6uiPZTB67Aw32fUF+Oeu7uhMUcos oQKcLQmhrzgXVqxxF77SlBg518SG93towsWlARTTJMQk016wmzVWt5QzXBaytOWlTR2I SGo5T2lHPK39oeWJ8o+UNSvKPguXRyJSstipTy0VP5VjLpUqWLeep8GbTswjXsRU8ljG 3Ih+Ux4K+qITWOmAvuDI0XuEBgWRByIppjA4Y1K3xxTSwNPBRdSlCCy+nv331onnIMmv sGe1xVNi6w/O5q71zG2/PKyBMEoPSPkMB40AgAjqO7C+2d00T7A7dlEdL4yZC+AqjBF3 NOBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687601566; x=1690193566; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=PCY6Z8ZjjqUX75jOGsgTCgN/T3Q7Zc+zUfvcYuI7iHk=; b=Ptlj0Ns9L/UpTW9F8OBgvPtSUGikSctOacpaoClvvp0vV4aXnIN+Kvuuhf7r8BTw3D phEAkzjIJteZ84QCSF4+VFhLoOJ2W53tNohwBxlVEvmPMERpJxU9CmVxOXaq/o0td+8a Q0PVSGMVZpmHNiSPqLG2EMhJOv38KiLgHLRBlVPJT/neM9xV1dNNWBOSijU0H9a3qVmh r+RZboL9Al2owq6y6kHtBHZGGUICRU5PrpTLsYWq2+BPIlTH1FlJBG/B8P6S20ZQwF4I XxFEOWq7i1B0PX7Zm2r9WbDzemoB6vevNlEKwVPsBLaS6dbLnjyBuMKCGEZ/xU3EdG/H 4YLg== X-Gm-Message-State: AC+VfDwyyLc41YYUQxdMOKMW5zkqxQGlDUn3fUKSa8n22JdPiuz20ZDd i2SxfqgvouvvntBPe14xKnM= X-Google-Smtp-Source: ACHHUZ6W3bx1SbIHG7qa47R6g9+K+Ve6CD+A774t/amJGE3lvJ4pT8hDS1HRz19OfmNa3MegxE5BNQ== X-Received: by 2002:a05:6512:454:b0:4f8:565f:8ec7 with SMTP id y20-20020a056512045400b004f8565f8ec7mr8250486lfk.27.1687601565790; Sat, 24 Jun 2023 03:12:45 -0700 (PDT) Original-Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id t5-20020ac243a5000000b004eb44c2ab6bsm214364lfl.294.2023.06.24.03.12.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 24 Jun 2023 03:12:45 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3654.120.0.1.15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263981 Archived-At: 24 juni 2023 kl. 00.39 skrev Yuan Fu : > I want to point out that a) this will add complexity and make the = syntax > harder to read and learn (however minuscule the impact might be); b) = is > not enough by itself to make isearch symbol work with capture names: > whoever write the code must _use_ this syntax; and c) I don=E2=80=99t = think > isearch symbol itself is popular/important enough to justify the = change. Well, you are the treesit maintainer and get to decide, but perhaps I = could try to sway your opinion. First note that the change is very small = with no increase in complexity -- most treesit users would never bother = to learn that there is an alternative @SYMBOL notation in addition to = the standard (@ SYMBOL). Furthermore, the @SYMBOL notation is quite un-Lisp-like and alien to = Lisp programmers who definitely tend to make use of symbol search, which = is why this bug (about the ,@ prefix) was so annoying: it not only = prevented us from effectively finding all occurrences of a symbol, but = deprived us of a common way to check that the spelling of name is = correct and corresponds to its definition. A pity if we now introduce = the same kind of bug again, unforced. I did a quick translation of some treesit patterns in various language = modes from @SYMBOL to (@ SYMBOL) and the result was no less readable. = Try it yourself. Your decision to expose treesit queries as Elisp S-expressions was = fortunate, as can be seen by the fact that no Emacs editing mode seems = to use the other (string) syntax, and the modes make frequent use of = backquote forms to interpolate Lisp values into patterns.