unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Mattias Engdegård" <mattias.engdegard@gmail.com>
To: 64697@debbugs.gnu.org
Cc: Alan Third <alan@idiocy.org>
Subject: bug#64697: 29.0.92: cannot paste NUL on macOS (regression from Emacs 28)
Date: Tue, 18 Jul 2023 10:30:38 +0200	[thread overview]
Message-ID: <E86F9B13-CF79-4444-8ABE-7549E75A3630@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 406 bytes --]

In Emacs 29, text pasted from the clipboard on macOS will be truncated if containing NULs.

Reproduction: copy text with NUL in the middle from Emacs 28 (or any other application), and paste into Emacs 29.

This was probably caused by 7e3c2b553f, where construction of a Lisp string was changed from make_string to build_string.

Suggested patch attached. If valid, would it qualify for emacs-29?


[-- Attachment #2: lispString.diff --]
[-- Type: application/octet-stream, Size: 453 bytes --]

diff --git a/src/nsfns.m b/src/nsfns.m
index 8804a7df7cf..d7ad0fa8341 100644
--- a/src/nsfns.m
+++ b/src/nsfns.m
@@ -3829,7 +3829,8 @@ handled fairly well by the NS libraries (displayed with distinct
 /* Make a Lisp string from an NSString.  */
 - (Lisp_Object)lispString
 {
-  return build_string ([self UTF8String]);
+  return make_string ([self UTF8String],
+                      [self lengthOfBytesUsingEncoding: NSUTF8StringEncoding]);
 }
 @end
 

             reply	other threads:[~2023-07-18  8:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-18  8:30 Mattias Engdegård [this message]
2023-07-18  9:22 ` bug#64697: 29.0.92: cannot paste NUL on macOS (regression from Emacs 28) Alan Third
2023-07-18 11:31   ` Eli Zaretskii
2023-07-18 11:28 ` Eli Zaretskii
2023-07-18 12:00   ` Mattias Engdegård
2023-07-18 13:02     ` Eli Zaretskii
2023-07-18 13:56       ` Mattias Engdegård
2023-08-19 17:34         ` Mattias Engdegård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E86F9B13-CF79-4444-8ABE-7549E75A3630@gmail.com \
    --to=mattias.engdegard@gmail.com \
    --cc=64697@debbugs.gnu.org \
    --cc=alan@idiocy.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).